[Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-06-01-preview #14814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @amitelran Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Since operation 'DataConnections_dataConnectionValidation' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1420 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2997 |
|
| Based on the response model schema, operation 'KustoPools_ListByWorkspace' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L139 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'KustoPoolModel'. Consider using the plural form of 'KustoPool' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L62 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: kustoPoolsStop Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L467 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
|
The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L25 |
|
The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/firewallRule.json#L203 |
|
The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L85 |
|
The response of operation:'Keys_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/keys.json#L75 |
|
The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/library.json#L25 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateEndpointConnections.json#L46 |
|
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L75 |
|
The response of operation:'PrivateLinkHubPrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L175 |
|
The response of operation:'PrivateLinkHubs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/privatelinkhub.json#L86 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 8 Errors, 68 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:preview/2021-06-01-preview/bigDataPool.json compared with base:stable/2021-05-01/bigDataPool.json
- current:preview/2021-06-01-preview/bigDataPool.json compared with base:preview/2021-04-01-preview/bigDataPool.json
- current:preview/2021-06-01-preview/checkNameAvailability.json compared with base:stable/2021-05-01/checkNameAvailability.json
- current:preview/2021-06-01-preview/checkNameAvailability.json compared with base:preview/2021-04-01-preview/checkNameAvailability.json
- current:preview/2021-06-01-preview/firewallRule.json compared with base:stable/2021-05-01/firewallRule.json
- current:preview/2021-06-01-preview/firewallRule.json compared with base:preview/2021-04-01-preview/firewallRule.json
- current:preview/2021-06-01-preview/integrationRuntime.json compared with base:stable/2021-05-01/integrationRuntime.json
- current:preview/2021-06-01-preview/integrationRuntime.json compared with base:preview/2021-04-01-preview/integrationRuntime.json
- current:preview/2021-06-01-preview/keys.json compared with base:stable/2021-05-01/keys.json
- current:preview/2021-06-01-preview/keys.json compared with base:preview/2021-04-01-preview/keys.json
- current:preview/2021-06-01-preview/kustoPool.json compared with base:preview/2021-04-01-preview/kustoPool.json
- current:preview/2021-06-01-preview/library.json compared with base:stable/2021-05-01/library.json
- current:preview/2021-06-01-preview/library.json compared with base:preview/2021-04-01-preview/library.json
- current:preview/2021-06-01-preview/operations.json compared with base:stable/2021-05-01/operations.json
- current:preview/2021-06-01-preview/operations.json compared with base:preview/2021-04-01-preview/operations.json
- current:preview/2021-06-01-preview/privateEndpointConnections.json compared with base:stable/2021-05-01/privateEndpointConnections.json
- current:preview/2021-06-01-preview/privateEndpointConnections.json compared with base:preview/2021-04-01-preview/privateEndpointConnections.json
- current:preview/2021-06-01-preview/privateLinkResources.json compared with base:stable/2021-05-01/privateLinkResources.json
- current:preview/2021-06-01-preview/privateLinkResources.json compared with base:preview/2021-04-01-preview/privateLinkResources.json
- current:preview/2021-06-01-preview/privatelinkhub.json compared with base:stable/2021-05-01/privatelinkhub.json
- current:preview/2021-06-01-preview/privatelinkhub.json compared with base:preview/2021-04-01-preview/privatelinkhub.json
- current:preview/2021-06-01-preview/sqlPool.json compared with base:stable/2021-05-01/sqlPool.json
- current:preview/2021-06-01-preview/sqlPool.json compared with base:preview/2021-04-01-preview/sqlPool.json
- current:preview/2021-06-01-preview/sqlServer.json compared with base:stable/2021-05-01/sqlServer.json
- current:preview/2021-06-01-preview/sqlServer.json compared with base:preview/2021-04-01-preview/sqlServer.json
- current:preview/2021-06-01-preview/workspace.json compared with base:stable/2021-05-01/workspace.json
- current:preview/2021-06-01-preview/workspace.json compared with base:preview/2021-04-01-preview/workspace.json
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1468", properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"The schema 'KekIdentityProperties-useSystemAssignedIdentity' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#/components/schemas/KekIdentityProperties-useSystemAssignedIdentity" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
| 💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"synapse/resource-manager/readme.md", "tag":"package-preview-2021-06", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
ghost
added
the
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=229067&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory" |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v55.5.0️✔️azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v55.5.0❌azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v55.5.0+ Field `HaveLibraryRequirementsChanged` of struct `BigDataPoolResourceProperties` has been removed
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.0.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Synapse [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
️✔️@azure/arm-synapse [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js... cmderr [npmPack] created ./dist/arm-synapse.js in 1.6s
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-07-05 02:24:51 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.1;1.0.0-beta.2" cmderr [generate.py] 2021-07-05 02:24:51 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2" cmderr [generate.py] 2021-07-05 02:24:51 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [generate.py] 2021-07-05 02:26:40 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-synapse cmderr [generate.py] 2021-07-05 02:26:40 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-07-05 02:26:40 INFO [POM][Skip] pom already has module azure-resourcemanager-synapse cmderr [generate.py] 2021-07-05 02:26:40 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-07-05 02:26:40 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-07-05 02:26:40 INFO [POM][Skip] pom already has module sdk/synapse cmderr [generate.py] 2021-07-05 02:26:40 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-synapse [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-synapse-1.0.0-beta.2-sources.jar
- azure-resourcemanager-synapse-1.0.0-beta.2-javadoc.jar
- azure-resourcemanager-synapse-1.0.0-beta.2.jar
cmderr [Inst] 2021-07-05 02:30:51 DEBUG Got artifact_id: azure-resourcemanager-synapse cmderr [Inst] 2021-07-05 02:30:51 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-07-05 02:30:51 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2-sources.jar cmderr [Inst] 2021-07-05 02:30:51 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2-javadoc.jar cmderr [Inst] 2021-07-05 02:30:51 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2.jar cmderr [Inst] 2021-07-05 02:30:51 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.2.jar cmderr [Inst] 2021-07-05 02:30:51 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14814/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.2.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-synapse [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model CustomerManagedKeyDetails has a new parameter kek_identity info [Changelog] - Model Workspace has a new parameter csp_workspace_admin_properties info [Changelog] - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get info [Changelog] - Added operation group DatabasesOperations info [Changelog] - Added operation group KustoPoolsOperations info [Changelog] - Added operation group DataConnectionsOperations info [Changelog] - Added operation group KustoPoolPrincipalAssignmentsOperations info [Changelog] - Added operation group DatabasePrincipalAssignmentsOperations info [Changelog] - Added operation group AttachedDatabaseConfigurationsOperations info [Changelog] - Added operation group KustoPoolOperations info [Changelog] - Added operation group KustoPoolChildResourceOperations info [Changelog] - Added operation group KustoOperationsOperations
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️synapse/mgmt/2021-03-01/synapse [View full logs] [Release SDK Changes]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU` info [Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA` info [Changelog] info [Changelog] Total 0 breaking change(s), 2 additive change(s). info [Changelog]
- Only show 40 items here, please refer to log for details.
️✔️synapse/mgmt/2020-12-01/synapse [View full logs]info [Changelog] info [Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU` info [Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA` info [Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)` info [Changelog] - New function `*LibraryListResponseIterator.Next() error` info [Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `LibraryListResponseIterator.Response() LibraryListResponse` info [Changelog] - New function `LibraryClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)` info [Changelog] - New function `LibraryClient.GetSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `LibraryClient.Get(context.Context, string, string, string) (LibraryResource, error)` info [Changelog] - New function `*LibraryListResponseIterator.NextWithContext(context.Context) error` info [Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage` info [Changelog] - New function `LibraryClient.GetResponder(*http.Response) (LibraryResource, error)` info [Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error` info [Changelog] - New function `NewLibraryClient(string) LibraryClient` info [Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient` info [Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `LibraryListResponseIterator.NotDone() bool` info [Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource` info [Changelog] - New function `NewLibrariesClientWithBaseURI(string, string) LibrariesClient` info [Changelog] - New function `LibraryListResponsePage.Values() []LibraryResource` info [Changelog] - New function `LibrariesClient.ListByWorkspace(context.Context, string, string) (LibraryListResponsePage, error)` info [Changelog] - New function `LibrariesClient.ListByWorkspaceComplete(context.Context, string, string) (LibraryListResponseIterator, error)` info [Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)` info [Changelog] - New function `LibraryListResponsePage.NotDone() bool` info [Changelog] - New function `NewLibrariesClient(string) LibrariesClient` info [Changelog] - New function `*LibraryListResponsePage.Next() error` info [Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error` info [Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse` info [Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator` info [Changelog] - New function `LibraryListResponse.IsEmpty() bool` info [Changelog] - New struct `LibrariesClient` info [Changelog] - New struct `LibraryClient` info [Changelog] - New struct `LibraryListResponse` info [Changelog] - New struct `LibraryListResponseIterator` info [Changelog] - New struct `LibraryListResponsePage` info [Changelog] - New struct `LibraryResource` info [Changelog] info [Changelog] Total 0 breaking change(s), 42 additive change(s). info [Changelog]
- Only show 40 items here, please refer to log for details.
️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs] Breaking Change Detectedinfo [Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)` info [Changelog] - New function `MaintenanceWindows.MarshalJSON() ([]byte, error)` info [Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdatePreparer(context.Context, string, string, string, GeoBackupPolicy) (*http.Request, error)` info [Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListPreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `NewSQLPoolRecommendedSensitivityLabelsClientWithBaseURI(string, string) SQLPoolRecommendedSensitivityLabelsClient` info [Changelog] - New struct `DynamicExecutorAllocation` info [Changelog] - New struct `LibraryInfo` info [Changelog] - New struct `MaintenanceWindowOptions` info [Changelog] - New struct `MaintenanceWindowOptionsProperties` info [Changelog] - New struct `MaintenanceWindowTimeRange` info [Changelog] - New struct `MaintenanceWindows` info [Changelog] - New struct `MaintenanceWindowsProperties` info [Changelog] - New struct `ManagedVirtualNetworkReference` info [Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient` info [Changelog] - New struct `RecommendedSensitivityLabelUpdate` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateList` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties` info [Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient` info [Changelog] - New struct `SQLPoolMaintenanceWindowsClient` info [Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient` info [Changelog] - New struct `SensitivityLabelUpdate` info [Changelog] - New struct `SensitivityLabelUpdateList` info [Changelog] - New struct `SensitivityLabelUpdateProperties` info [Changelog] - New field `ManagedBy` in struct `SensitivityLabel` info [Changelog] - New field `TableName` in struct `SensitivityLabelProperties` info [Changelog] - New field `Rank` in struct `SensitivityLabelProperties` info [Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime` info [Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties` info [Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties` info [Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] info [Changelog] Total 1 breaking change(s), 119 additive change(s). info [Changelog]
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️synapse [View full logs] [Release Schema Changes]
This was referenced Jun 15, 2021
added 9 commits
June 15, 2021 13:11
added 3 commits
June 17, 2021 16:42
Hi @idear1203 @ruowan, |
idear1203
approved these changes
Jun 28, 2021
idear1203
removed
the
DoNotMerge
added 2 commits
June 29, 2021 11:33
…ps://github.com/amitelran/azure-rest-api-specs into kusto-pool-Microsoft.Synapse-2021-06-01-preview
docohe
reviewed
Jun 29, 2021
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json
Show resolved
Hide resolved
|
Hi @ruowan, |
pilor
reviewed
Jun 29, 2021
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json
Show resolved
Hide resolved
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json
Show resolved
Hide resolved
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json
Show resolved
Hide resolved
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json
Show resolved
Hide resolved
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json
Show resolved
Hide resolved
pilor
added
the
ARMChangesRequested
pilor
added
ARMSignedOff
JeffreyRichter
added
the
Approved-BreakingChange
This was referenced Jul 5, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jul 5, 2021
…pse to add version preview/2021-06-01-preview (#1788) Create to sync Azure/azure-rest-api-specs#14814 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/synapse?expand=1)
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…review/2021-06-01-preview (Azure#14814) * Adds base for updating Microsoft.Synapse from version stable/2021-05-01 to version 2021-06-01-preview * Updates readme * Updates API version in new specs and examples * Add kustoPool.json to new API version + examples files + in readme.md * Add "type": "object" to definitions * Modify SKU to new name & size instead of previous name & tier * Add KustoPool stop * fix KustoPool Stop example params * Add KustoPool Start + example * Add KustoPool LanguageExtension Add/List/Remove * Add "type": "object" to LanguageExtensionsList * Add KustoPoolFollowerDatabases DETACH and LIST + examples * Add KustoPoolDatabasePrincipals ADD & LIST + examples * Add missing DatabasePrincipalListRequest definition * Add "type": "object" to FollowerDatabaseListResult, DatabasePrincipalListRequest, DatabasePrincipalListResult * Add KustoPoolDatabasePrincipalsRemove + example * Remove redundant newline * Add AttachedDatabaseConfigurations to KustoPool + examples * Add AttachedDatabaseConfigurationNameParameter * Fixes for AttachedDatabaseConfiguration * Add "type": "object" to TableLevelSharingProperties * Fix example of KustoPoolAttachedDatabaseConfigurationCreateOrUpdate.json * Add DataConnectionValidation to kustoPool.json + example * Fixes to DataConnectionValidation * Remove properties from KustoPoolDataConnectionValidation.json * Fix object instead of array at KustoPoolDataConnectionValidation.json example * Fix indentation at KustoPoolDataConnectionValidation.json * Add KustoPoolPrincipalAssignmentCheckNameAvailability to kustoPool.json + example * Remove redundant slash * Add KustoPoolDatabasePrincipalAssignmentsCheckNameAvailability to kustoPool.json + example * Fix in KustoPoolDatabasePrincipalAssignmentsCheckNameAvailability.json * Add KustoPoolDataConnectionCheckNameAvailability.json + example * Add KustoPoolListSkus + example * Add kustoSkus path to kustoPool.json + example * Remove {databaseName}/addPrincipals, listPrincipals, removePrincipals. Remove related definitions + example files * Change workspaceUid to workspaceUID to keep convention with Workspace resource * Add new KustoPool properties: optimizedAutoscale enableStreamingIngest enablePurge languageExtensions * Change "KustoCluster" to "KustoPool" and remove engineType property * Change "kustoSkus" endpoint to "skus" * Add KustoPool databases CheckNameAvailability + examples * Re-position kustoPoolCheckNameAvailability * Fix typo in example * Minor adjustments in KustoPool databases CheckNameAvailability * Change to "validateDataConnection" * Revert back to DataConnectionValidation to keep consistency with kusto swagger Co-authored-by: Amit Elran <amelran@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.