[AutoPR @azure/arm-synapse] [Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-06-01-preview #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14814/@azure_arm-synapse
branch
from
8a6587e to
74847c2
Compare
26 tasks
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14814/@azure_arm-synapse
branch
10 times, most recently
from
9f588d8 to
0e24f45
Compare
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Always use x-ms-date for Hmac * Try to fix phone number tests * Still another error in phone number tests * Update phoneNumber session records * Update phone numbers node sessions * Manually fix node record sessions for phone numbers * Update missed session files Co-authored-by: JP Chen <jiach@microsoft.com>
This PR makes three changes to our deployment template: - Add networkAcls to the Managed HSM properties - Remove the 60 second sleep after activation - Speed up challenge auth tests for KV Keys by using methods that don't require creating and deleting keys. The first is now needed, and without it deployment will fail. The second is no longer needed, since it looks like the az cli appropriately waits before coming back. Finally, the third is something I noticed - there's no reason to create and purge keys which takes a long time in order to test CAE.
## What - Bump @opentelemetry/api to 0.20.0 in @azure/core-tracing - Move all packages that are on core-http to the next core-tracing version - Remove version collision check from the tracer cache ## Why This is part of our effort to move everyone to OTel 0.20.0 - but we have to stage it due to a transitive dependency and a breaking change in OTel. This PR updates core-tracing to use the latest OTel, fixes any breaking changes, and moves packages that we can move to the latest version of core-tracing. Once core-rest-pipeline 1.1.0 is GA'd we'll be able to move the rest of the packages over to the latest core-tracing as well. Removing the version collision came out of an offline discussion after these changes were reviewed - since it's a common source of pain and hasn't added much benefit (tracer conflicts incompatibility was never a problem) we decided to remove that logic and always grab a unique symbol per OT compatibility. ## Callouts The packages that are already on core-v2 will _not_ be upgraded at this time - we'll coordinate that with the GA of core-rest-pipeline 1.1.0
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14814/@azure_arm-synapse
branch
12 times, most recently
from
7baa6af to
2b48d37
Compare
* adds simple background refresh * Adds setInterval with unref * cleanup * wip prenock * wip * Removes recorder, fixes timeout in tests * extract api * fix lint * format * Adds flag * lint * Fix parition spelling * modify endpoint check * fix tests * Comment proxy * adds back copyright * skip session spec * Fix session token * Fix session spec on emulator
* Support track2 management packages
Perf test packages should not be using the eslint plugin
Fixes the below error
```
ESLint couldn't find the plugin "@azure/eslint-plugin-azure-sdk".
(The package "@azure/eslint-plugin-azure-sdk" was not found when loaded as a Node module from the directory "/home/vsts/work/1/s/sdk".)
It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm install @azure/eslint-plugin-azure-sdk@latest --save-dev
The plugin "@azure/eslint-plugin-azure-sdk" was referenced from the config file in "../../../.eslintrc.json".
```
…est-pipeline (Azure#16045) This PR updates the newly added `@azure-rest/core-client-paging` package to use the same version of `@azure/core-rest-pipeline` that the other packages use. We recently GA'd (on main, not released yet) version 1.1.0 of `@azure/core-rest-pipeline` and want to keep everyone on the latest version.
Follow up for Azure#16046 to fix the resulting linter errors
…16010) Update to latest core packages and improve pipeline robustness.
As part of the development of the new pipeline, event grid was hand ported to use the new pipeline. Now that the code generator targets the new pipeline, we can start using it to generate the code. Since EventGrid includes the `/api/events` path segment in the Endpoint, We need to do a small amount of post processing of the generated code, to ensure `/api/events` is not appended to the endpoint (we do this by setting an empty path in the operation spec, which is as things were before moving over to the generator). Fixes Azure#15823
…dential (Azure#15856) * [Identity] Add support for Bridge to Kubernetes to ManagedIdentityCredential * one very simple test * forgot this line
…ers (Azure#15932) * [Monitor Exporter] Separate tests into internal and public folders * fix build * put tests in internal * prettier * console log for testing * testing * format * console * try flush processor * format * remove console logs
## What
- Adds warning filter to ignore known rollup warnings that are safe to ignore
- Ignore `this has been rewritten to undefined` in synapse
- Ignore circular dependencies in synapse
## Why
These are both known warnings, are safe to ignore, and add noise to the build output unnecessarily.
The first is totally safe to ignore:
```
var __spreadArray = (this && this.__spreadArray) || function (to, from) {
```
Is emitted from TypeScript in the OTel ESM and is safe to use.
The second is a known issue in OTel 1.0.0 that is not harmful at runtime.
Finally, we have precedent for doing the exact same thing in other packages like service-bus.
The watchful eyes of @vishnureddy17 found that we still have reference to Node.js 8 in our Contributing Guide!! This PR fixes that. Related to #7022
* Update identity to 2.0.0-beta.4 for quantum jobs * Fix CI Errors * Fix CI Errors
Based on the Retry-After specification, 503 should also be supported when considering the Retry-After header. This also aligns with upcoming Identity plans.
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14814/@azure_arm-synapse
branch
5 times, most recently
from
0dc1270 to
96b20b9
Compare
…5853) This PR enables PKCE on the InteractiveBrowserCredential. We don’t have tests for this yet. I’ll make sure to test it manually, at least. Fixes Azure#15168
…ludeVisualization option. (Azure#16058) * Big update to use the latest stable swagger files for all of the Log Analytics services. Each reference is by git commit ID this time to prevent any accidental drift. Also, added in the includeRender header (via the `includeVisualization` option). Fixes Azure#15771 * Fixing codeowners to reflect the proper owners for the package: @KarishmaGhiya - main owner @maorleger - backup owner * Formatting!
* Convenience Method to create a synonymmap object * Update sdk/search/search-documents/src/synonymMapHelper.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Fix for PR Comments Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14814/@azure_arm-synapse
branch
from
96b20b9 to
abc7555
Compare
Merge 280142b80c1ebd805abd27f41054a976cf850538 into 91ac14531f0d05b3d6fcf4a817ea0defde59fe63
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14814/@azure_arm-synapse
branch
from
abc7555 to
58a2814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#14814
Installation Instructions
You can install the package
@azure/arm-synapseof this PR using the following command:curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14814/azure-sdk-for-js/@azure_arm-synapse/azure-arm-synapse-5.1.0.tgz" -o azure-arm-synapse-5.1.0.tgz npm install azure-arm-synapse-5.1.0.tgzDirect Download
The generated package can be directly downloaded from here: