Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Public private branch 'yuwzho/deprecate-appplatform-api-version' #17506

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Jan 26, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@yuwzho
Copy link
Contributor Author

yuwzho commented Jan 26, 2022

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/5810

@openapi-workflow-bot
Copy link

Hi, @yuwzho Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2022

    Swagger Validation Report

    ️❌BreakingChange: 64 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L19:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/listTestKeys' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L226:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/regenerateTestKey' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L268:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/disableTestEndpoint' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L319:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/enableTestEndpoint' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L357:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L398:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L617:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/getResourceUploadUrl' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L662:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/bindings/{bindingName}' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L707:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/bindings' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L911:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/certificates/{certificateName}' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L959:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/certificates' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1099:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AppPlatform/locations/{location}/checkNameAvailability' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1144:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/domains/{domainName}' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1196:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/domains' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1400:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/domains/validate' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1448:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/deployments/{deploymentName}' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1501:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/deployments' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1731:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/deployments' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1791:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/deployments/{deploymentName}/start' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1848:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/deployments/{deploymentName}/stop' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1900:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/deployments/{deploymentName}/restart' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L1952:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring/{serviceName}/apps/{appName}/deployments/{deploymentName}/getLogFileUrl' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2004:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AppPlatform/Spring' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2055:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppPlatform/Spring' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2094:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AppPlatform/operations' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2136:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AppPlatform/runtimeVersions' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2172:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AppPlatform/skus' removed or restructured?
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2205:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ServiceResource' removed or renamed?
    New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L19:3
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2244:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ClusterResourceProperties' removed or renamed?
    New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L19:3
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2244:3
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armappplatform - 0.4.0
    +	Function `CloudErrorBody.MarshalJSON` has been removed
    +	Struct `CloudErrorBody` has been removed
    +	Struct `CloudError` has been removed
    +	Type of `AppResourceProperties.AddonConfigs` has been changed from `map[string]map[string]map[string]interface{}` to `map[string]map[string]interface{}`
    +	Type of `BindingResourceProperties.BindingParameters` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
    +	Type of `DeploymentSettings.AddonConfigs` has been changed from `map[string]map[string]map[string]interface{}` to `map[string]map[string]interface{}`
    ️✔️azure-sdk-for-go - appplatform/mgmt/2020-07-01/appplatform - v61.3.0
    azure-sdk-for-go - preview/appplatform/mgmt/2022-01-01-preview/appplatform - v61.3.0
    +	Function `BuildServiceAgentPoolClient.UpdatePutPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, BuildServiceAgentPoolSizeProperties)` to `(context.Context, string, string, string, string, BuildServiceAgentPoolResource)`
    +	Function `BuildServiceAgentPoolClient.UpdatePut` parameter(s) have been changed from `(context.Context, string, string, string, string, BuildServiceAgentPoolSizeProperties)` to `(context.Context, string, string, string, string, BuildServiceAgentPoolResource)`
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2021-09-01-preview/appplatform - v61.3.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2021-06-01-preview/appplatform - v61.3.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2020-11-01-preview/appplatform - v61.3.0
    azure-sdk-for-go - preview/appplatform/mgmt/2019-05-01-preview/appplatform - v61.3.0
    +	Package was removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-appplatform - Approved - 6.1.0
    +	Removed operation group SkuOperations
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 5d23498. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      Resource not accessible by integration
      HttpError: Resource not accessible by integration
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit+request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.AppPlatform [View full logs
      error	Fatal error: Resource not accessible by integration
      error	The following packages are still pending:
      error		Az.AppPlatform
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5d23498. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appplatform [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation AppsOperations.begin_set_active_deployments
      info	[Changelog]   - Added operation DeploymentsOperations.begin_generate_heap_dump
      info	[Changelog]   - Added operation DeploymentsOperations.begin_generate_thread_dump
      info	[Changelog]   - Added operation DeploymentsOperations.begin_start_jfr
      info	[Changelog]   - Added operation ServicesOperations.begin_start
      info	[Changelog]   - Added operation ServicesOperations.begin_stop
      info	[Changelog]   - Added operation group ApiPortalCustomDomainsOperations
      info	[Changelog]   - Added operation group ApiPortalsOperations
      info	[Changelog]   - Added operation group BuildServiceAgentPoolOperations
      info	[Changelog]   - Added operation group BuildServiceBuilderOperations
      info	[Changelog]   - Added operation group BuildServiceOperations
      info	[Changelog]   - Added operation group BuildpackBindingOperations
      info	[Changelog]   - Added operation group ConfigurationServicesOperations
      info	[Changelog]   - Added operation group GatewayCustomDomainsOperations
      info	[Changelog]   - Added operation group GatewayRouteConfigsOperations
      info	[Changelog]   - Added operation group GatewaysOperations
      info	[Changelog]   - Added operation group ServiceRegistriesOperations
      info	[Changelog]   - Added operation group StoragesOperations
      info	[Changelog]   - Model AppResource has a new parameter system_data
      info	[Changelog]   - Model AppResourceProperties has a new parameter addon_configs
      info	[Changelog]   - Model AppResourceProperties has a new parameter custom_persistent_disks
      info	[Changelog]   - Model AppResourceProperties has a new parameter loaded_certificates
      info	[Changelog]   - Model BindingResource has a new parameter system_data
      info	[Changelog]   - Model CertificateResource has a new parameter system_data
      info	[Changelog]   - Model ClusterResourceProperties has a new parameter fqdn
      info	[Changelog]   - Model ClusterResourceProperties has a new parameter power_state
      info	[Changelog]   - Model ClusterResourceProperties has a new parameter zone_redundant
      info	[Changelog]   - Model ConfigServerResource has a new parameter system_data
      info	[Changelog]   - Model CustomDomainResource has a new parameter system_data
      info	[Changelog]   - Model DeploymentInstance has a new parameter zone
      info	[Changelog]   - Model DeploymentResource has a new parameter system_data
      info	[Changelog]   - Model DeploymentSettings has a new parameter addon_configs
      info	[Changelog]   - Model DeploymentSettings has a new parameter container_probe_settings
      info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_namespace
      info	[Changelog]   - Model MonitoringSettingResource has a new parameter system_data
      info	[Changelog]   - Model OperationDetail has a new parameter action_type
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model ServiceResource has a new parameter system_data
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model AppResourceProperties no longer has parameter active_deployment_name
      info	[Changelog]   - Model AppResourceProperties no longer has parameter created_time
      info	[Changelog]   - Model CertificateProperties has a new required parameter type
      info	[Changelog]   - Model CertificateProperties no longer has parameter cert_version
      info	[Changelog]   - Model CertificateProperties no longer has parameter key_vault_cert_name
      info	[Changelog]   - Model CertificateProperties no longer has parameter vault_uri
      info	[Changelog]   - Model DeploymentResourceProperties no longer has parameter app_name
      info	[Changelog]   - Model DeploymentResourceProperties no longer has parameter created_time
      info	[Changelog]   - Model DeploymentSettings no longer has parameter cpu
      info	[Changelog]   - Model DeploymentSettings no longer has parameter jvm_options
      info	[Changelog]   - Model DeploymentSettings no longer has parameter memory_in_gb
      info	[Changelog]   - Model DeploymentSettings no longer has parameter net_core_main_entry_path
      info	[Changelog]   - Model DeploymentSettings no longer has parameter runtime_version
      info	[Changelog]   - Model UserSourceInfo no longer has parameter artifact_selector
      info	[Changelog]   - Model UserSourceInfo no longer has parameter custom_container
      info	[Changelog]   - Model UserSourceInfo no longer has parameter relative_path
      info	[Changelog]   - Parameter type of model UserSourceInfo is now required
      info	[Changelog]   - Removed operation group SkuOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5d23498. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-02-08 07:54:35 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-appplatform-generated"
      cmderr	[generate.py] 2022-02-08 07:54:35 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2022-02-08 07:54:35 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/appplatform/azure-resourcemanager-appplatform-generated --java.namespace=com.azure.resourcemanager.appplatform.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
      cmderr	[generate.py] 2022-02-08 07:55:26 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2022-02-08 07:55:26 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-02-08 07:55:26 INFO [POM][Skip] pom already has module azure-resourcemanager-appplatform-generated
      cmderr	[generate.py] 2022-02-08 07:55:26 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-02-08 07:55:26 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-02-08 07:55:26 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] 2022-02-08 07:57:10 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-appplatform-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2022-02-08 07:57:15 DEBUG Got artifact_id: azure-resourcemanager-appplatform-generated
      cmderr	[Inst] 2022-02-08 07:57:15 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-02-08 07:57:15 DEBUG Got artifact: azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-02-08 07:57:15 DEBUG Match jar package: azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-02-08 07:57:15 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17506/azure-sdk-for-java/azure-resourcemanager-appplatform-generated/azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-appplatform-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5d23498. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.AppPlatform [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5d23498. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-appplatform [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5d23498. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️appplatform/mgmt/2020-07-01/appplatform [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `Outbound`
      info	[Changelog] - New const `Internal`
      info	[Changelog] - New const `Inbound`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `RequiredTraffic.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
      info	[Changelog] - New struct `RequiredTraffic`
      info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
      info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 13 additive change(s).
    • ️✔️preview/appplatform/mgmt/2022-01-01-preview/appplatform [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `BuildServiceAgentPoolClient.UpdatePut` parameter(s) have been changed from `(context.Context, string, string, string, string, BuildServiceAgentPoolSizeProperties)` to `(context.Context, string, string, string, string, BuildServiceAgentPoolResource)`
      info	[Changelog] - Function `BuildServiceAgentPoolClient.UpdatePutPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, BuildServiceAgentPoolSizeProperties)` to `(context.Context, string, string, string, string, BuildServiceAgentPoolResource)`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
    • ️✔️preview/appplatform/mgmt/2021-09-01-preview/appplatform [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
    • ️✔️preview/appplatform/mgmt/2021-06-01-preview/appplatform [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 5 additive change(s).
    • ️✔️preview/appplatform/mgmt/2020-11-01-preview/appplatform [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `Internal`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5d23498. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armappplatform [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `DeploymentSettings.AddonConfigs` has been changed from `map[string]map[string]map[string]interface{}` to `map[string]map[string]interface{}`
      info	[Changelog] - Type of `BindingResourceProperties.BindingParameters` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
      info	[Changelog] - Type of `AppResourceProperties.AddonConfigs` has been changed from `map[string]map[string]map[string]interface{}` to `map[string]map[string]interface{}`
      info	[Changelog] - Function `CloudErrorBody.MarshalJSON` has been removed
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Struct `CloudErrorBody` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New function `ActionType.ToPtr() *ActionType`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog]
      info	[Changelog] Total 8 breaking change(s), 4 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5d23498. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️appplatform [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @yuwzho, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @raych1
    Copy link
    Member

    raych1 commented Jan 26, 2022

    @ArcturusZhang @msyyc , do you have any comment on this version retirement?

    @raych1 raych1 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 26, 2022
    @raych1
    Copy link
    Member

    raych1 commented Jan 26, 2022

    I approved breaking change as it's approved in private spec repo PR.

    @msyyc
    Copy link
    Member

    msyyc commented Jan 26, 2022

    @raych1 raych1 merged commit 5d23498 into main Feb 8, 2022
    @yuwzho yuwzho deleted the published/VSChina/azure-rest-api-specs-pr/yuwzho/deprecate-appplatform-api-version branch February 8, 2022 07:48
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    …pi-version' (Azure#17506)
    
    * Deprecate AppPlatform 2019-05-01-preview API version
    
    * remove related SDK code
    
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    jiec-msft added a commit that referenced this pull request Mar 19, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Python CI-BreakingChange-Go-V2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants