-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update services with latest specs #672
Conversation
@@ -0,0 +1,8 @@ | |||
# 0.2 (2022-03) | |||
|
|||
- generated from azure-rest-api-specs [commit from 2022-03-02](https://github.com/Azure/azure-rest-api-specs/commit/c56b44b794ff17caad4d31c6ab64b07e28253504) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the commit used. It is now in the CHANGELOG.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared files and a sampling of generated files LGTM.
@@ -33,4 +33,3 @@ no-default-version = [] | |||
"package-preview-2021-06" = [] | |||
"package-preview-2020-11" = [] | |||
"package-2020-07" = [] | |||
"package-2019-05-01-preview" = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting to see a version removed. What prompted this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec was removed. The easiest way to find the changes is to go to its readme and then look at history. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/appplatform/resource-manager/readme.md . That will take you to Azure/azure-rest-api-specs#17506 where it was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were going to bump the revs of all of the crates when regenerating with updated specs.
Even the crates with changes, I don't see version bumps.
I also added a CHANGELOG.md for the generated services.
I'm checking all the features in https://github.com/cataggar/azure-sdk-for-rust/actions/runs/1924895767 . If it runs for 6 hours , we are good.