Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update services with latest specs #672

Merged
merged 6 commits into from
Mar 3, 2022
Merged

Conversation

cataggar
Copy link
Member

@cataggar cataggar commented Mar 2, 2022

I also added a CHANGELOG.md for the generated services.

I'm checking all the features in https://github.com/cataggar/azure-sdk-for-rust/actions/runs/1924895767 . If it runs for 6 hours , we are good.

@@ -0,0 +1,8 @@
# 0.2 (2022-03)

- generated from azure-rest-api-specs [commit from 2022-03-02](https://github.com/Azure/azure-rest-api-specs/commit/c56b44b794ff17caad4d31c6ab64b07e28253504)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit used. It is now in the CHANGELOG.md.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared files and a sampling of generated files LGTM.

@@ -33,4 +33,3 @@ no-default-version = []
"package-preview-2021-06" = []
"package-preview-2020-11" = []
"package-2020-07" = []
"package-2019-05-01-preview" = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting to see a version removed. What prompted this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec was removed. The easiest way to find the changes is to go to its readme and then look at history. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/appplatform/resource-manager/readme.md . That will take you to Azure/azure-rest-api-specs#17506 where it was removed.

Copy link
Contributor

@bmc-msft bmc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to bump the revs of all of the crates when regenerating with updated specs.

Even the crates with changes, I don't see version bumps.

@cataggar cataggar merged commit 5292850 into Azure:main Mar 3, 2022
@cataggar cataggar deleted the services-0.2 branch March 3, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants