gallery 01-03 release #17985
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "{subscription-id}", | ||
| "location": "myLocation", | ||
| "api-version": "2022-01-03", | ||
| "publicGalleryName": "publicGalleryName", | ||
| "galleryImageName": "myGalleryImageName" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": { | ||
| "publishedDate": "2018-03-20T09:12:28Z", | ||
| "endOfLifeDate": "2022-03-20T09:12:28Z", | ||
| "excludeFromLatest": false, | ||
| "storageProfile": { | ||
| "osDiskImage": { | ||
| "diskSizeGB": 29, | ||
| "hostCaching": "None" | ||
| } | ||
| } | ||
| }, | ||
| "location": "myLocation", | ||
| "name": "myGalleryImageVersionName", | ||
| "identifier": { | ||
| "uniqueId": "/CommunityGalleries/publicGalleryName/Images/myGalleryImageName/Versions/myGalleryImageVersionName" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "http://svchost:99/subscriptions/{subscription-Id}/providers/Microsoft.Compute/communityGalleries/publicGalleryName/images/myGalleryImageName/versions?$skiptoken={token}/communityGalleries/publicGalleryName/images/myGalleryImageName/versions/myGalleryImageVersionName" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "{subscription-id}", | ||
| "location": "myLocation", | ||
| "api-version": "2022-01-03", | ||
| "publicGalleryName": "publicGalleryName" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": { | ||
| "osType": "Windows", | ||
| "osState": "Generalized", | ||
| "hyperVGeneration": "V1", | ||
| "identifier": { | ||
| "publisher": "myPublisherName", | ||
| "offer": "myOfferName", | ||
| "sku": "mySkuName" | ||
| } | ||
| }, | ||
| "location": "myLocation", | ||
| "name": "myGalleryImageName", | ||
| "identifier": { | ||
| "uniqueId": "/CommunityGalleries/publicGalleryName/Images/myGalleryImageName" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "http://svchost:99/subscriptions/{subscription-Id}/providers/Microsoft.Compute/communityGalleries/publicGalleryName/images?$skiptoken={token}/communityGalleries/publicGalleryName/images/myGalleryImageName" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ | |
| "targetRegions": [ | ||
| { | ||
|
There was a problem hiding this comment. thank you for catching this error @kangsun-ctrl |
||
| "name": "West US", | ||
| "regionalReplicaCount": 2, | ||
| "encryption": { | ||
| "osDiskImage": { | ||
| "diskEncryptionSetId": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/diskEncryptionSet/myWestUSDiskEncryptionSet" | ||
|
|
@@ -68,7 +68,7 @@ | |
| "targetRegions": [ | ||
| { | ||
| "name": "West US", | ||
| "regionalReplicaCount": 2, | ||
| "storageAccountType": "Standard_LRS", | ||
| "encryption": { | ||
| "osDiskImage": { | ||
|
|
@@ -140,7 +140,7 @@ | |
| "targetRegions": [ | ||
| { | ||
| "name": "West US", | ||
| "regionalReplicaCount": 2, | ||
| "storageAccountType": "Standard_LRS", | ||
| "encryption": { | ||
| "osDiskImage": { | ||
|
|
@@ -212,7 +212,7 @@ | |
| "targetRegions": [ | ||
| { | ||
| "name": "West US", | ||
| "regionalReplicaCount": 2, | ||
| "storageAccountType": "Standard_LRS", | ||
| "encryption": { | ||
| "osDiskImage": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARM recommends string enums instead of booleans. Rather than adding booleans for selection filters, you could think of an include or exclude property with enum values, e.g. include: { All, AllButLatest }. If you use modelAsString: true, then over time you can add more enum values without adding a new API version. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are the same api model in the backend as https://github.com/kangsun-ctrl/azure-rest-api-specs/blob/4d0adaa99964df094beae44cecb08f01ea6e66e0/specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery.json#L2440-L2443. So I think we can try to change them all in the new api version since we need this release go in fast for our public preview.