Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery 01-03 release #17985

Merged

Conversation

kangsun-ctrl
Copy link
Contributor

@kangsun-ctrl kangsun-ctrl commented Feb 24, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 25, 2022

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 3 Warnings warning [Detail]
The following errors/warnings are introduced by current PR:
Rule Message
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: excludeFromLatest
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L467
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: excludeFromLatest
Location: stable/2022-01-03/GalleryRP/sharedGallery.json#L612
⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get a community gallery.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L72


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1772
R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2069
R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2251
R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2319
R4037 - MissingTypeObject The schema 'PirCommunityGalleryResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L267
R4037 - MissingTypeObject The schema 'CommunityGalleryIdentifier' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L291
R4037 - MissingTypeObject The schema 'CommunityGallery' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L300
R4037 - MissingTypeObject The schema 'CommunityGalleryImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L330
R4037 - MissingTypeObject The schema 'CommunityGalleryImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L344
R4037 - MissingTypeObject The schema 'CommunityGalleryImageVersion' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L441
R4037 - MissingTypeObject The schema 'CommunityGalleryImageVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/communityGallery.json#L455
R4037 - MissingTypeObject The schema 'Gallery' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1735
R4037 - MissingTypeObject The schema 'GalleryUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1749
R4037 - MissingTypeObject The schema 'GalleryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1763
R4037 - MissingTypeObject The schema 'GalleryIdentifier' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1799
R4037 - MissingTypeObject The schema 'SharingProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1809
R4037 - MissingTypeObject The schema 'SharingProfileGroup' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1842
R4037 - MissingTypeObject The schema 'GalleryApplication' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1967
R4037 - MissingTypeObject The schema 'GalleryApplicationUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1981
R4037 - MissingTypeObject The schema 'GalleryApplicationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L1995
R4037 - MissingTypeObject The schema 'GalleryApplicationVersion' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2036
R4037 - MissingTypeObject The schema 'GalleryApplicationVersionUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2050
R4037 - MissingTypeObject The schema 'GalleryApplicationVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2064
R4037 - MissingTypeObject The schema 'GalleryApplicationVersionPublishingProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2093
R4037 - MissingTypeObject The schema 'UserArtifactSource' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2116
R4037 - MissingTypeObject The schema 'UserArtifactManage' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2132
R4037 - MissingTypeObject The schema 'GalleryImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2152
R4037 - MissingTypeObject The schema 'GalleryImageUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2166
R4037 - MissingTypeObject The schema 'GalleryImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2180
R4037 - MissingTypeObject The schema 'GalleryImageVersion' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2022-01-03/GalleryRP/gallery.json#L2286
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/compute/resource-manager/readme.md
tag: specification/compute/resource-manager/readme.md#tag-package-2022-01-03
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 1 Errors, 3 Warnings failed [Detail]
The following breaking changes are detected by comparison with the latest stable version:
Rule Message
1019 - RemovedEnumValue The new version is removing enum value(s) 'Community' from the old version.
New: stable/2022-01-03/GalleryRP/gallery.json#L1845:9
Old: Microsoft.Compute/stable/2021-10-01/gallery.json#L1844:9


The following breaking changes are detected by comparison with latest preview version:

Rule Message
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'LocationNameParamter' removed or renamed?
New: azure-rest-api-specs/blob/fd6bae5f5c9407bf8f66ce57792a425202eb85ed/revision:1024:2
Old: Microsoft.Compute/preview/2020-09-30/sharedGallery.json#L762:3
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
New: stable/2022-01-03/GalleryRP/gallery.json#L2509:9
Old: Microsoft.Compute/preview/2020-09-30/gallery.json#L2358:9
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
New: stable/2022-01-03/GalleryRP/gallery.json#L2525:5
Old: Microsoft.Compute/preview/2020-09-30/gallery.json#L2371:5
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 25, 2022

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 26.1.0
+	Model VirtualMachineImage no longer has parameter architecture
⚠️azure-sdk-for-go-track2 - armcompute - 0.6.0
+	Const `ArchitectureTypesArm64` has been removed
+	Const `ArchitectureTypesX64` has been removed
+	Const `DataAccessAuthModeAzureActiveDirectory` has been removed
+	Const `DataAccessAuthModeNone` has been removed
+	Const `SharingProfileGroupTypesCommunity` has been removed
+	Field `Architecture` of struct `SupportedCapabilities` has been removed
+	Field `Architecture` of struct `VirtualMachineImageProperties` has been removed
+	Field `DataAccessAuthMode` of struct `DiskProperties` has been removed
+	Field `DataAccessAuthMode` of struct `DiskUpdateProperties` has been removed
+	Field `DataAccessAuthMode` of struct `SnapshotProperties` has been removed
+	Field `DataAccessAuthMode` of struct `SnapshotUpdateProperties` has been removed
+	Function `ArchitectureTypes.ToPtr` has been removed
+	Function `DataAccessAuthMode.ToPtr` has been removed
+	Function `PossibleArchitectureTypesValues` has been removed
+	Function `PossibleDataAccessAuthModeValues` has been removed
⚠️azure-sdk-for-js - @azure/arm-compute - 18.0.0
+	Enum KnownSharingProfileGroupTypes no longer has value Community
+	Interface DiskUpdate no longer has parameter dataAccessAuthMode
+	Interface SnapshotUpdate no longer has parameter dataAccessAuthMode
+	Interface SupportedCapabilities no longer has parameter architecture
+	Removed Enum KnownArchitectureTypes
+	Removed Enum KnownDataAccessAuthMode
+	Type Alias Disk no longer has parameter dataAccessAuthMode
+	Type Alias Snapshot no longer has parameter dataAccessAuthMode
+	Type Alias VirtualMachineImage no longer has parameter architecture
️❌ azure-sdk-for-net failed [Detail]
  • Failed [Logs] Generate from 616c3676b7216b5f092a0e760b3403fb964f31fe. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-6.0
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • Microsoft.Azure.Management.Compute [View full logs]  [Preview SDK Changes]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 616c3676b7216b5f092a0e760b3403fb964f31fe. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.4` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation CommunityGalleryImageVersionsOperations.list
    info	[Changelog]   - Added operation CommunityGalleryImagesOperations.list
    info	[Changelog]   - Model CommunityGalleryImage has a new parameter architecture
    info	[Changelog]   - Model CommunityGalleryImageVersion has a new parameter exclude_from_latest
    info	[Changelog]   - Model CommunityGalleryImageVersion has a new parameter storage_profile
    info	[Changelog]   - Model SharedGalleryImage has a new parameter architecture
    info	[Changelog]   - Model SharedGalleryImageVersion has a new parameter exclude_from_latest
    info	[Changelog]   - Model SharedGalleryImageVersion has a new parameter storage_profile
    info	[Changelog]
    info	[Changelog] **Breaking changes**
    info	[Changelog]
    info	[Changelog]   - Model VirtualMachineImage no longer has parameter architecture
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs] Generate from 616c3676b7216b5f092a0e760b3403fb964f31fe. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    cmderr	[automation_init.sh] npm WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
    cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
    cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
    cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
    cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation CommunityGalleryImages.list
    info	[Changelog]   - Added operation CommunityGalleryImageVersions.list
    info	[Changelog]   - Added Interface CommunityGalleryImageList
    info	[Changelog]   - Added Interface CommunityGalleryImagesListNextOptionalParams
    info	[Changelog]   - Added Interface CommunityGalleryImagesListOptionalParams
    info	[Changelog]   - Added Interface CommunityGalleryImageVersionList
    info	[Changelog]   - Added Interface CommunityGalleryImageVersionsListNextOptionalParams
    info	[Changelog]   - Added Interface CommunityGalleryImageVersionsListOptionalParams
    info	[Changelog]   - Added Interface SharedGalleryDiskImage
    info	[Changelog]   - Added Interface SharedGalleryImageVersionStorageProfile
    info	[Changelog]   - Added Type Alias CommunityGalleryImagesListNextResponse
    info	[Changelog]   - Added Type Alias CommunityGalleryImagesListResponse
    info	[Changelog]   - Added Type Alias CommunityGalleryImageVersionsListNextResponse
    info	[Changelog]   - Added Type Alias CommunityGalleryImageVersionsListResponse
    info	[Changelog]   - Added Type Alias SharedGalleryDataDiskImage
    info	[Changelog]   - Added Type Alias SharedGalleryHostCaching
    info	[Changelog]   - Added Type Alias SharedGalleryOSDiskImage
    info	[Changelog]   - Type Alias CommunityGalleryImage has a new parameter architecture
    info	[Changelog]   - Type Alias CommunityGalleryImageVersion has a new parameter excludeFromLatest
    info	[Changelog]   - Type Alias CommunityGalleryImageVersion has a new parameter storageProfile
    info	[Changelog]   - Type Alias SharedGalleryImage has a new parameter architecture
    info	[Changelog]   - Type Alias SharedGalleryImageVersion has a new parameter excludeFromLatest
    info	[Changelog]   - Type Alias SharedGalleryImageVersion has a new parameter storageProfile
    info	[Changelog]   - Added Enum KnownSharedGalleryHostCaching
    info	[Changelog]   - Enum KnownGallerySharingPermissionTypes has a new value Community
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Interface DiskUpdate no longer has parameter dataAccessAuthMode
    info	[Changelog]   - Interface SnapshotUpdate no longer has parameter dataAccessAuthMode
    info	[Changelog]   - Interface SupportedCapabilities no longer has parameter architecture
    info	[Changelog]   - Type Alias Disk no longer has parameter dataAccessAuthMode
    info	[Changelog]   - Type Alias Snapshot no longer has parameter dataAccessAuthMode
    info	[Changelog]   - Type Alias VirtualMachineImage no longer has parameter architecture
    info	[Changelog]   - Removed Enum KnownArchitectureTypes
    info	[Changelog]   - Removed Enum KnownDataAccessAuthMode
    info	[Changelog]   - Enum KnownSharingProfileGroupTypes no longer has value Community
️❌ azure-sdk-for-go failed [Detail]
  • Failed [Logs] Generate from 616c3676b7216b5f092a0e760b3403fb964f31fe. SDK Automation 14.0.0
    command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    cmderr	[generator automation] [AUTOREST]
    cmderr	[generator automation] [AUTOREST] ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    cmderr	[generator automation] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/gallery.json:2732:4 ($.definitions.ApiError)
    cmderr	[generator automation] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json:3619:4 ($.definitions.ApiError)
    cmderr	[generator automation] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/runCommands.json:1346:4 ($.definitions.ApiError)
    cmderr	[generator automation] [AUTOREST]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json:14558:4 ($.definitions.ApiError)
    cmderr	[generator automation] [AUTOREST]   Cancellation requested.
    cmderr	[generator automation] [ERROR] total 1 error(s):
    cmderr	[generator automation] [ERROR] failed to execute autorest: autorest error with arguments '--use=@microsoft.azure/autorest.go@2.1.187, --go, --verbose, --go-sdk-folder=., --use-onever, --version=2.0.4421, --go.license-header=MICROSOFT_MIT_NO_VERSION, --pass-thru:schema-validator-swagger, --enum-prefix, --tag=package-2021-08-01, --metadata-output-folder=/home/vsts/work/1/s/azure-sdk-for-go_tmp/generation-metadata-1647286985/package-2021-08-01, ../../../../../azure-rest-api-specs/specification/compute/resource-manager/readme.md':
    cmderr	[generator automation] [ERROR] exit status 1
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation
    warn	Skip package processing as generation is failed
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 616c3676b7216b5f092a0e760b3403fb964f31fe. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️armcompute [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Const `DataAccessAuthModeAzureActiveDirectory` has been removed
    info	[Changelog] - Const `SharingProfileGroupTypesCommunity` has been removed
    info	[Changelog] - Const `ArchitectureTypesX64` has been removed
    info	[Changelog] - Const `DataAccessAuthModeNone` has been removed
    info	[Changelog] - Const `ArchitectureTypesArm64` has been removed
    info	[Changelog] - Function `PossibleDataAccessAuthModeValues` has been removed
    info	[Changelog] - Function `DataAccessAuthMode.ToPtr` has been removed
    info	[Changelog] - Function `ArchitectureTypes.ToPtr` has been removed
    info	[Changelog] - Function `PossibleArchitectureTypesValues` has been removed
    info	[Changelog] - Field `DataAccessAuthMode` of struct `DiskUpdateProperties` has been removed
    info	[Changelog] - Field `Architecture` of struct `SupportedCapabilities` has been removed
    info	[Changelog] - Field `DataAccessAuthMode` of struct `DiskProperties` has been removed
    info	[Changelog] - Field `DataAccessAuthMode` of struct `SnapshotUpdateProperties` has been removed
    info	[Changelog] - Field `DataAccessAuthMode` of struct `SnapshotProperties` has been removed
    info	[Changelog] - Field `Architecture` of struct `VirtualMachineImageProperties` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New const `SharedGalleryHostCachingReadOnly`
    info	[Changelog] - New const `SharedGalleryHostCachingReadWrite`
    info	[Changelog] - New const `SharedGalleryHostCachingNone`
    info	[Changelog] - New const `GallerySharingPermissionTypesCommunity`
    info	[Changelog] - New function `SharedGalleryHostCaching.ToPtr() *SharedGalleryHostCaching`
    info	[Changelog] - New function `*CommunityGalleryImageVersionsClientListPager.NextPage(context.Context) bool`
    info	[Changelog] - New function `CommunityGalleryImageList.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `*CommunityGalleryImageVersionsClientListPager.PageResponse() CommunityGalleryImageVersionsClientListResponse`
    info	[Changelog] - New function `*CommunityGalleryImageVersionsClient.List(string, string, string, *CommunityGalleryImageVersionsClientListOptions) *CommunityGalleryImageVersionsClientListPager`
    info	[Changelog] - New function `*CommunityGalleryImagesClientListPager.NextPage(context.Context) bool`
    info	[Changelog] - New function `*CommunityGalleryImageVersionsClientListPager.Err() error`
    info	[Changelog] - New function `*CommunityGalleryImagesClientListPager.PageResponse() CommunityGalleryImagesClientListResponse`
    info	[Changelog] - New function `*CommunityGalleryImagesClientListPager.Err() error`
    info	[Changelog] - New function `CommunityGalleryImageVersionList.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `*CommunityGalleryImagesClient.List(string, string, *CommunityGalleryImagesClientListOptions) *CommunityGalleryImagesClientListPager`
    info	[Changelog] - New function `SharedGalleryImageVersionStorageProfile.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `PossibleSharedGalleryHostCachingValues() []SharedGalleryHostCaching`
    info	[Changelog] - New struct `CommunityGalleryImageList`
    info	[Changelog] - New struct `CommunityGalleryImageVersionList`
    info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListOptions`
    info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListPager`
    info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListResponse`
    info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListResult`
    info	[Changelog] - New struct `CommunityGalleryImagesClientListOptions`
    info	[Changelog] - New struct `CommunityGalleryImagesClientListPager`
    info	[Changelog] - New struct `CommunityGalleryImagesClientListResponse`
    info	[Changelog] - New struct `CommunityGalleryImagesClientListResult`
    info	[Changelog] - New struct `SharedGalleryDataDiskImage`
    info	[Changelog] - New struct `SharedGalleryDiskImage`
    info	[Changelog] - New struct `SharedGalleryImageVersionStorageProfile`
    info	[Changelog] - New struct `SharedGalleryOSDiskImage`
    info	[Changelog] - New field `Architecture` in struct `SharedGalleryImageProperties`
    info	[Changelog] - New field `StorageProfile` in struct `CommunityGalleryImageVersionProperties`
    info	[Changelog] - New field `ExcludeFromLatest` in struct `CommunityGalleryImageVersionProperties`
    info	[Changelog] - New field `ExcludeFromLatest` in struct `SharedGalleryImageVersionProperties`
    info	[Changelog] - New field `StorageProfile` in struct `SharedGalleryImageVersionProperties`
    info	[Changelog] - New field `Architecture` in struct `CommunityGalleryImageProperties`
    info	[Changelog]
    info	[Changelog] Total 15 breaking change(s), 49 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 616c3676b7216b5f092a0e760b3403fb964f31fe. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
    cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
    cmderr	[initScript.sh] npm WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
    cmderr	[initScript.sh] npm WARN old lockfile
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️compute [View full logs]  [Preview Schema Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi @kangsun-ctrl, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

TaskHow to fixPriority
AvocadoFix-AvocadoHigh
Semantic validationFix-SemanticValidation-ErrorHigh
Model validationFix-ModelValidation-ErrorHigh
LintDiffFix-LintDiffhigh
If you need further help, please feedback via swagger feedback.

@Jing-song
Copy link
Contributor

Hi @kangsun-ctrl permissions does not contain community(link), Could you please fix it

@@ -13,7 +13,7 @@
"targetRegions": [
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for catching this error @kangsun-ctrl

Copy link
Member

@grizzlytheodore grizzlytheodore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. One breaking change to get approval

@mentat9
Copy link
Member

mentat9 commented Mar 10, 2022

@kangsun-ctrl - Couple of things needed before your PR is ready for ARM review:

  1. This is a new API version for Microsoft.Compute, so your submission form should check [ ] new API version instead of [ ] new service onboarding. Fixing that will drive automation and correct handling of your PR.
  2. Please study the materials described in the submission form and attest to that by checking the box:
    [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

@mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 10, 2022
@kangsun-ctrl
Copy link
Contributor Author

@kangsun-ctrl - Couple of things needed before your PR is ready for ARM review:

  1. This is a new API version for Microsoft.Compute, so your submission form should check [ ] new API version instead of [ ] new service onboarding. Fixing that will drive automation and correct handling of your PR.
  2. Please study the materials described in the submission form and attest to that by checking the box:
    [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

Hi Chris @mentat9, thanks for the headsup, i have chosen the right checkbox for this pr and I read the rp guidelines previously when I request ARM review. I think I am ready for the review, let me know if there is anything you need.

Also, I am requesting breaking change approval from Jeffrey Richter at the same time. Thanks!

@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 10, 2022
@@ -325,6 +463,14 @@
"type": "string",
"format": "date-time",
"description": "The end of life date of the gallery image version Definition. This property can be used for decommissioning purposes. This property is updatable."
},
"excludeFromLatest": {
Copy link
Member

@mentat9 mentat9 Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excludeFromLatest

ARM recommends string enums instead of booleans. Rather than adding booleans for selection filters, you could think of an include or exclude property with enum values, e.g. include: { All, AllButLatest }. If you use modelAsString: true, then over time you can add more enum values without adding a new API version. #Resolved

Copy link
Contributor Author

@kangsun-ctrl kangsun-ctrl Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the same api model in the backend as https://github.com/kangsun-ctrl/azure-rest-api-specs/blob/4d0adaa99964df094beae44cecb08f01ea6e66e0/specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery.json#L2440-L2443. So I think we can try to change them all in the new api version since we need this release go in fast for our public preview.

@@ -605,6 +608,14 @@
"type": "string",
"format": "date-time",
"description": "The end of life date of the gallery image version Definition. This property can be used for decommissioning purposes. This property is updatable."
},
"excludeFromLatest": {
Copy link
Member

@mentat9 mentat9 Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excludeFromLatest

See earlier comment about boolean vs. enum. #Resolved

@mentat9 mentat9 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 10, 2022
@mentat9 mentat9 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 10, 2022
@Sandido
Copy link
Member

Sandido commented Mar 14, 2022

@ArcturusZhang , we would like this to be merged ASAP. We are working on resolving the enum error and have approval for the breaking change.
Please review this and be ready to merge it soon. Then we'll open a PR to merge the feature branch to main, we just want the review to occur now if possible.

@ArcturusZhang ArcturusZhang merged commit 597c65c into Azure:feature/cplat-2022-01-03 Mar 15, 2022
Sandido pushed a commit that referenced this pull request May 5, 2022
* save

* update

* update

* update

* update

* update

* update

* nit

* 'save'

* add

* update

* add architecture

* update

* update

* Update readme

add `package-2022-01-03-only` tag for python

* save

* nit

Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Sandido pushed a commit that referenced this pull request May 5, 2022
* save

* update

* update

* update

* update

* update

* update

* nit

* 'save'

* add

* update

* add architecture

* update

* update

* Update readme

add `package-2022-01-03-only` tag for python

* save

* nit

Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Sandido pushed a commit that referenced this pull request May 5, 2022
* save

* update

* update

* update

* update

* update

* update

* nit

* 'save'

* add

* update

* add architecture

* update

* update

* Update readme

add `package-2022-01-03-only` tag for python

* save

* nit

Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Sandido pushed a commit that referenced this pull request May 9, 2022
* save

* update

* update

* update

* update

* update

* update

* nit

* 'save'

* add

* update

* add architecture

* update

* update

* Update readme

add `package-2022-01-03-only` tag for python

* save

* nit

Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
@Sandido Sandido mentioned this pull request May 9, 2022
25 tasks
ArcturusZhang pushed a commit that referenced this pull request May 23, 2022
* set up feature branch

setup feature branch and update common.json

Update gallery.json

fix mistake made in example name

readme and python

readme from main sync

main sync

common.json optional location

* gallery 01-03 release (#17985)

* save

* update

* update

* update

* update

* update

* update

* nit

* 'save'

* add

* update

* add architecture

* update

* update

* Update readme

add `package-2022-01-03-only` tag for python

* save

* nit

Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>

* Add privacyStatement/Uri to communtiy gallery image (#18680)

* update

* update

* update

* update

* update

* update

* Adds settings and advancedSettings to gallery application version (#18722)

* adds settings and advancedSettings to gallery application version

* fix spell checker and LintDiff

* added description and ran prettifier again

* fix typo in description

* Addressed PR comments

* updated description to use full name of the VMApp extension, i.e. vm-application-manager

Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com>
Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com>
Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript Compute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants