-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds settings and advancedSettings to gallery application version #18722
Adds settings and advancedSettings to gallery application version #18722
Conversation
Hi, @D1v38om83r Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
R4037 - MissingTypeObject |
The schema 'Gallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1735 |
R4037 - MissingTypeObject |
The schema 'GalleryUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1749 |
R4037 - MissingTypeObject |
The schema 'GalleryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1763 |
R4037 - MissingTypeObject |
The schema 'GalleryIdentifier' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1789 |
R4037 - MissingTypeObject |
The schema 'SharingProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1799 |
R4037 - MissingTypeObject |
The schema 'SharingProfileGroup' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1832 |
R4037 - MissingTypeObject |
The schema 'GalleryApplication' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1957 |
R4037 - MissingTypeObject |
The schema 'GalleryApplicationUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1971 |
R4037 - MissingTypeObject |
The schema 'GalleryApplicationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L1985 |
R4037 - MissingTypeObject |
The schema 'GalleryApplicationVersion' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2026 |
R4037 - MissingTypeObject |
The schema 'GalleryApplicationVersionUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2040 |
R4037 - MissingTypeObject |
The schema 'GalleryApplicationVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2054 |
R4037 - MissingTypeObject |
The schema 'GalleryApplicationVersionPublishingProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2073 |
R4037 - MissingTypeObject |
The schema 'UserArtifactSource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2106 |
R4037 - MissingTypeObject |
The schema 'UserArtifactManage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2122 |
R4037 - MissingTypeObject |
The schema 'GalleryImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2156 |
R4037 - MissingTypeObject |
The schema 'GalleryImageUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2170 |
R4037 - MissingTypeObject |
The schema 'GalleryImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2184 |
R4037 - MissingTypeObject |
The schema 'GalleryImageVersion' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2280 |
R4037 - MissingTypeObject |
The schema 'GalleryImageVersionUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2294 |
R4037 - MissingTypeObject |
The schema 'GalleryImageVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2308 |
R4037 - MissingTypeObject |
The schema 'GalleryArtifactPublishingProfileBase' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2330 |
R4037 - MissingTypeObject |
The schema 'TargetRegion' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2401 |
R4037 - MissingTypeObject |
The schema 'EncryptionImages' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2491 |
R4037 - MissingTypeObject |
The schema 'DataDiskImageEncryption' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2548 |
R4037 - MissingTypeObject |
The schema 'DiskImageEncryption' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2566 |
R4037 - MissingTypeObject |
The schema 'GalleryArtifactSource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2575 |
R4037 - MissingTypeObject |
The schema 'ManagedArtifact' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2586 |
R4037 - MissingTypeObject |
The schema 'GalleryImageVersionStorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2606 |
R4037 - MissingTypeObject |
The schema 'GalleryArtifactVersionSource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-01-03/GalleryRP/gallery.json#L2627 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-01-03 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 1 Errors, 2 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:2022-01-03/GalleryRP/gallery.json compared with base:stable/2021-10-01/gallery.json
- current:2022-01-03/GalleryRP/gallery.json compared with base:preview/2020-09-30/gallery.json
Rule | Message |
---|---|
1019 - RemovedEnumValue |
The new version is removing enum value(s) 'Community' from the old version. New: stable/2022-01-03/GalleryRP/gallery.json#L1835:9 Old: Microsoft.Compute/stable/2021-10-01/gallery.json#L1844:9 |
The following breaking changes are detected by comparison with latest preview version:
Rule | Message |
---|---|
The new version has a different type 'object' than the previous one ''. New: stable/2022-01-03/GalleryRP/gallery.json#L2493:9 Old: Microsoft.Compute/preview/2020-09-30/gallery.json#L2358:9 |
|
The new version has a different type 'object' than the previous one ''. New: stable/2022-01-03/GalleryRP/gallery.json#L2509:5 Old: Microsoft.Compute/preview/2020-09-30/gallery.json#L2371:5 |
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Updaing the swagger as per changes made in PR 4764473 for CAPS |
Hi @D1v38om83r, Your PR has some issues. Please fix the CI sequentially by following the order of
|
SDK PR for the changes Azure/azure-sdk-for-net#28250 |
...e/stable/2022-01-03/GalleryRP/examples/galleryExamples/GalleryApplicationVersion_Create.json
Outdated
Show resolved
Hide resolved
...e/stable/2022-01-03/GalleryRP/examples/galleryExamples/GalleryApplicationVersion_Create.json
Outdated
Show resolved
Hide resolved
.../GalleryRP/examples/galleryExamples/GalleryApplicationVersion_Get_WithReplicationStatus.json
Outdated
Show resolved
Hide resolved
...fication/compute/resource-manager/Microsoft.Compute/stable/2022-01-03/GalleryRP/gallery.json
Outdated
Show resolved
Hide resolved
...fication/compute/resource-manager/Microsoft.Compute/stable/2022-01-03/GalleryRP/gallery.json
Outdated
Show resolved
Hide resolved
...e/stable/2022-01-03/GalleryRP/examples/galleryExamples/GalleryApplicationVersion_Create.json
Show resolved
Hide resolved
...fication/compute/resource-manager/Microsoft.Compute/stable/2022-01-03/GalleryRP/gallery.json
Outdated
Show resolved
Hide resolved
...fication/compute/resource-manager/Microsoft.Compute/stable/2022-01-03/GalleryRP/gallery.json
Show resolved
Hide resolved
…application-manager
…8722) * adds settings and advancedSettings to gallery application version * fix spell checker and LintDiff * added description and ran prettifier again * fix typo in description * Addressed PR comments * updated description to use full name of the VMApp extension, i.e. vm-application-manager
…8722) * adds settings and advancedSettings to gallery application version * fix spell checker and LintDiff * added description and ran prettifier again * fix typo in description * Addressed PR comments * updated description to use full name of the VMApp extension, i.e. vm-application-manager
…8722) * adds settings and advancedSettings to gallery application version * fix spell checker and LintDiff * added description and ran prettifier again * fix typo in description * Addressed PR comments * updated description to use full name of the VMApp extension, i.e. vm-application-manager
…8722) * adds settings and advancedSettings to gallery application version * fix spell checker and LintDiff * added description and ran prettifier again * fix typo in description * Addressed PR comments * updated description to use full name of the VMApp extension, i.e. vm-application-manager
* set up feature branch setup feature branch and update common.json Update gallery.json fix mistake made in example name readme and python readme from main sync main sync common.json optional location * gallery 01-03 release (#17985) * save * update * update * update * update * update * update * nit * 'save' * add * update * add architecture * update * update * Update readme add `package-2022-01-03-only` tag for python * save * nit Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com> * Add privacyStatement/Uri to communtiy gallery image (#18680) * update * update * update * update * update * update * Adds settings and advancedSettings to gallery application version (#18722) * adds settings and advancedSettings to gallery application version * fix spell checker and LintDiff * added description and ran prettifier again * fix typo in description * Addressed PR comments * updated description to use full name of the VMApp extension, i.e. vm-application-manager Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Jiefeng Chen <51037443+BigCat20196@users.noreply.github.com> Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
This PR introduces new properties for Gallery Application Version resource type.
The property "settings" for Gallery Application Version allow the user to specify the file name that the downloaded packages and configurations to be named to. These names can then be referenced in the user provided script to install, update, remove the VMApp, or in Custom Actions.
The property "advancedSettings" are tweaks for the behavior of the vm-application-manager extension that manages the installation, update and delete of Gallery Application Version.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.