Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds settings and advancedSettings to gallery application version #18722

Merged
merged 6 commits into from
May 5, 2022
Merged

Adds settings and advancedSettings to gallery application version #18722

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
34a1335
adds settings and advancedSettings to gallery application version
D1v38om83r Apr 18, 2022
2cd3ee7
fix spell checker and LintDiff
D1v38om83r Apr 18, 2022
7d8da6e
added description and ran prettifier again
D1v38om83r Apr 18, 2022
0c46c6c
fix typo in description
D1v38om83r Apr 19, 2022
c22bf98
Addressed PR comments
D1v38om83r Apr 20, 2022
58f92cc
updated description to use full name of the VMApp extension, i.e. vm-…
D1v38om83r Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...table/2022-01-03/GalleryRP/examples/galleryExamples/GalleryApplicationVersion_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@
"remove": "del C:\\package "
Sandido marked this conversation as resolved.
Show resolved Hide resolved
},
"enableHealthCheck": false,
"settings": {
"packageFileName": "package.zip",
"configFileName": "configuration.cfg"
},
"advancedSettings": {
"timoeut": "300",
D1v38om83r marked this conversation as resolved.
Show resolved Hide resolved
"user": "root"
},
"targetRegions": [
{
"name": "West US",
Expand Down Expand Up @@ -81,6 +89,14 @@
"remove": "del C:\\package "
},
"enableHealthCheck": false,
"settings": {
"packageFileName": "package.zip",
"configFileName": "configuration.cfg"
},
"advancedSettings": {
"timoeut": "300",
D1v38om83r marked this conversation as resolved.
Show resolved Hide resolved
"user": "root"
},
"targetRegions": [
{
"name": "West US",
Expand Down
8 changes: 8 additions & 0 deletions ...lleryRP/examples/galleryExamples/GalleryApplicationVersion_Get_WithReplicationStatus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@
"remove": "del C:\\package "
},
"enableHealthCheck": false,
"settings": {
"packageFileName": "package.zip",
"configFileName": "configuration.cfg"
},
"advancedSettings": {
"timoeut": "300",
D1v38om83r marked this conversation as resolved.
Show resolved Hide resolved
"user": "root"
},
"targetRegions": [
{
"name": "West US",
Expand Down
24 changes: 24 additions & 0 deletions ...ation/compute/resource-manager/Microsoft.Compute/stable/2022-01-03/GalleryRP/gallery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2098,6 +2098,16 @@
"manageActions": {
"$ref": "#/definitions/UserArtifactManage"
},
"settings": {
"$ref": "#/definitions/UserArtifactSettings"
},
"advancedSettings": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Optional. Additional settings to pass to the VMApp extension. For advanced used only."
D1v38om83r marked this conversation as resolved.
Show resolved Hide resolved
},
"enableHealthCheck": {
"type": "boolean",
"description": "Optional. Whether or not this application reports health."
Expand Down Expand Up @@ -2149,6 +2159,20 @@
"remove"
]
},
"UserArtifactSettings": {
"type": "object",
"properties": {
"packageFileName": {
"type": "string",
"description": "Optional. The file to rename the downloaded package to on the VM. If not present, then the file will be called <app name>. This is limited to 4096 characters."
D1v38om83r marked this conversation as resolved.
Show resolved Hide resolved
},
"configFileName": {
"type": "string",
"description": "Optional. The file to rename the downloaded config to on the VM. If not present, then the file will be called <app name>_config. This is limited to 4096 characters."
}
},
"description": "Additional settings for the VM app that contains the target package and config file name when it is deployed to target VM or VM scale set."
},
"GalleryImage": {
"properties": {
"properties": {
Expand Down