Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Swagger spec for Connection Monitor VMSS #19203

Merged
merged 2 commits into from
May 26, 2022
Merged

Update Swagger spec for Connection Monitor VMSS #19203

merged 2 commits into from
May 26, 2022

Conversation

kumaam
Copy link
Contributor

@kumaam kumaam commented May 24, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@kumaam kumaam requested a review from MikhailTryakhov as a code owner May 24, 2022 12:13
@openapi-workflow-bot
Copy link

Hi, @kumaam Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 24, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2344
    ❌ R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2344
    ❌ R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2344
    ❌ R4037 - MissingTypeObject The schema 'NetworkWatcher' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2354
    ❌ R4037 - MissingTypeObject The schema 'NetworkWatcherPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2374
    ❌ R4037 - MissingTypeObject The schema 'NetworkWatcherListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2384
    ❌ R4037 - MissingTypeObject The schema 'TopologyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2396
    ❌ R4037 - MissingTypeObject The schema 'Topology' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2413
    ❌ R4037 - MissingTypeObject The schema 'TopologyResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2442
    ❌ R4037 - MissingTypeObject The schema 'TopologyAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2466
    ❌ R4037 - MissingTypeObject The schema 'VerificationIPFlowParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2491
    ❌ R4037 - MissingTypeObject The schema 'VerificationIPFlowResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2545
    ❌ R4037 - MissingTypeObject The schema 'NextHopParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2558
    ❌ R4037 - MissingTypeObject The schema 'NextHopResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2584
    ❌ R4037 - MissingTypeObject The schema 'SecurityGroupViewParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2613
    ❌ R4037 - MissingTypeObject The schema 'SecurityGroupViewResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2625
    ❌ R4037 - MissingTypeObject The schema 'SecurityGroupNetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2637
    ❌ R4037 - MissingTypeObject The schema 'SecurityRuleAssociations' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2650
    ❌ R4037 - MissingTypeObject The schema 'NetworkInterfaceAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2677
    ❌ R4037 - MissingTypeObject The schema 'SubnetAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2694
    ❌ R4037 - MissingTypeObject The schema 'PacketCapture' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2711
    ❌ R4037 - MissingTypeObject The schema 'PacketCaptureParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2724
    ❌ R4037 - MissingTypeObject The schema 'PacketCaptureStorageLocation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2772
    ❌ R4037 - MissingTypeObject The schema 'PacketCaptureFilter' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2789
    ❌ R4037 - MissingTypeObject The schema 'PacketCaptureListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2824
    ❌ R4037 - MissingTypeObject The schema 'PacketCaptureResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2836
    ❌ R4037 - MissingTypeObject The schema 'PacketCaptureResultProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2861
    ❌ R4037 - MissingTypeObject The schema 'PacketCaptureQueryStatusResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2876
    ❌ R4037 - MissingTypeObject The schema 'TroubleshootingParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2931
    ❌ R4037 - MissingTypeObject The schema 'QueryTroubleshootingParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-01-01/networkWatcher.json#L2949
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 24, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armnetwork - 1.1.0
    ️✔️azure-sdk-for-js - @azure/arm-network - 29.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-08-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-05-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-03-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-02-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-11-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-08-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-07-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-06-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-05-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-04-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-03-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-12-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-11-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-09-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-08-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-07-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-06-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-04-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-02-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-12-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-11-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-10-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-08-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-07-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-06-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-04-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-02-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-01-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-11-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-10-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2015-06-15/network - v65.0.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-03-01-preview/network - v65.0.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-02-01-preview/network - v65.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-network - 20.0.0
    ️❌ azure-sdk-for-net failed [Detail]   
  
    • ❌Failed [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.10.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.10.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.10.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-network        [View full logs]         [Preview SDK Changes]      
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ApplicationGatewayRoutingRule has a new parameter priority
    ️⚠️ azure-sdk-for-java warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-network-generated        [View full logs]         [Preview SDK Changes]      
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️network/mgmt/2021-08-01/network        [View full logs]         [Preview SDK Changes]      
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-05-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-03-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-02-01/network        [View full logs]       
            Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `ResourceGUID` in struct `PrivateLinkServiceProperties`
info	[Changelog] - New field `ProvisioningState` in struct `PrivateDNSZonePropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    • ️✔️network/mgmt/2020-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-08-01/network        [View full logs]       
            Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `VNetExtendedLocationResourceID` in struct `VirtualNetworkGatewayPropertiesFormat`
info	[Changelog] - New field `ApplicationGatewayIPConfigurations` in struct `SubnetPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 35 additive change(s).
    • ️✔️network/mgmt/2020-07-01/network        [View full logs]       
            Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `LinkedPublicIPAddress` in struct `PublicIPAddressPropertiesFormat`
info	[Changelog] - New field `VNetExtendedLocationResourceID` in struct `VirtualNetworkGatewayPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 27 additive change(s).
    • ️✔️network/mgmt/2020-06-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-05-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-04-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-03-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-12-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-09-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-08-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-07-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-06-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-04-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-02-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-12-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-10-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-08-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-07-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-06-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-04-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-02-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-01-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-10-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2015-06-15/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-03-01-preview/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-02-01-preview/network        [View full logs]       
      info	[Changelog] This is a new package
info	[Changelog]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armnetwork        [View full logs]         [Preview SDK Changes]      
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `WebApplicationFirewallOperatorAny`
info	[Changelog] - New const `ApplicationGatewaySSLPolicyTypeCustomV2`
info	[Changelog] - New const `EndpointTypeAzureVMSS`
info	[Changelog] - New const `ApplicationGatewaySSLProtocolTLSv13`
info	[Changelog] - New const `EndpointTypeAzureArcVM`
info	[Changelog] - New const `ApplicationGatewaySSLPolicyNameAppGwSSLPolicy20220101S`
info	[Changelog] - New const `ApplicationGatewaySSLPolicyNameAppGwSSLPolicy20220101`
info	[Changelog] - New function `ExpressRouteProviderPort.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ManagementClient.ExpressRouteProviderPort(context.Context, string, *ManagementClientExpressRouteProviderPortOptions) (ManagementClientExpressRouteProviderPortResponse, error)`
info	[Changelog] - New struct `ExpressRouteProviderPort`
info	[Changelog] - New struct `ExpressRouteProviderPortListResult`
info	[Changelog] - New struct `ExpressRouteProviderPortProperties`
info	[Changelog] - New struct `ExpressRouteProviderPortsLocationClientListOptions`
info	[Changelog] - New struct `ExpressRouteProviderPortsLocationClientListResponse`
info	[Changelog] - New struct `ManagementClientExpressRouteProviderPortOptions`
info	[Changelog] - New struct `ManagementClientExpressRouteProviderPortResponse`
info	[Changelog] - New struct `VirtualRouterAutoScaleConfiguration`
info	[Changelog] - New field `EnablePacFile` in struct `ExplicitProxySettings`
info	[Changelog] - New field `VirtualRouterAutoScaleConfiguration` in struct `VirtualHubProperties`
info	[Changelog] - New field `Priority` in struct `ApplicationGatewayRoutingRulePropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 28 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ExpressRouteProviderPortsLocation
info	[Changelog]   - Added Interface ExpressRouteProviderPortListResult
info	[Changelog]   - Added Interface ExpressRouteProviderPortOptionalParams
info	[Changelog]   - Added Interface ExpressRouteProviderPortsLocationListOptionalParams
info	[Changelog]   - Added Interface VirtualRouterAutoScaleConfiguration
info	[Changelog]   - Added Type Alias ExpressRouteProviderPort
info	[Changelog]   - Added Type Alias ExpressRouteProviderPortResponse
info	[Changelog]   - Added Type Alias ExpressRouteProviderPortsLocationListResponse
info	[Changelog]   - Interface ExplicitProxySettings has a new optional parameter enablePacFile
info	[Changelog]   - Class NetworkManagementClient has a new parameter expressRouteProviderPortsLocation
info	[Changelog]   - Type Alias ApplicationGatewayRoutingRule has a new parameter priority
info	[Changelog]   - Type Alias VirtualHub has a new parameter virtualRouterAutoScaleConfiguration
info	[Changelog]   - Enum KnownApplicationGatewaySslPolicyName has a new value AppGwSslPolicy20220101
info	[Changelog]   - Enum KnownApplicationGatewaySslPolicyName has a new value AppGwSslPolicy20220101S
info	[Changelog]   - Enum KnownApplicationGatewaySslPolicyType has a new value CustomV2
info	[Changelog]   - Enum KnownApplicationGatewaySslProtocol has a new value TLSv13
info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcVM
info	[Changelog]   - Enum KnownEndpointType has a new value AzureVmss
info	[Changelog]   - Enum KnownWebApplicationFirewallOperator has a new value Any
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface NetworkManagementClientOptionalParams no longer has parameter apiVersion
info	[Changelog]   - Class NetworkManagementClient no longer has parameter apiVersion
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]   
  
    • ❌Failed [Logs] Generate from 70750e63f3b7bfaf7cb0824b72642d9a4efc6079. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.network        [View full logs]         [Preview SDK Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @ghost
  ghost


          added
  the 

  Network

 label


      May 24, 2022

    
    
  
    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced May 24, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced May 24, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    




    

      
    
  
        



    

      
    
  
        



    

      
    
  
          
    
  
    
    
  
    
  
    


        @lirenhe
  lirenhe



        merged commit 7133261
      into

      
  
    Azure:network-2022-01-01
  


    May 26, 2022

  
    

    


    

  

    
  
    
  
  
    
    
  lirenhe 

      pushed a commit
      that referenced
      this pull request

    
      Jun 23, 2022
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @MikhailTryakhov
      
        @uditmisra52
        
    
      
        @jashsing-mic
      
        @creepyghost
      
        @AndriiKalinichenko
      
        @ankaliniMS
      
        @vinaymundada27
      
        @kaushik-ms
      
        @snagpal99
      
        @kumaam
      
        @Satya-anshu
      
        @yanfa317
      
        @gitlwh
      
        @anchalkpr
      
        @Gizachew-Eshetie
  
    

    


      
    
        
          Mitryakh/network 2022 01 01 (#19412)
        

          
            
          

      
    

      
    
          

    
    
    

  

    


      
    

      
    
      
    

      
      
    
        
          61e9487
        
      
    
    
    
  
    
    
    
      
    * Adds base for updating Microsoft.Network from version stable/2021-08-01 to version 2022-01-01

* Updates readme

* Updates API version in new specs and examples

* Updated Explicit proxy settings by adding one boolean field to it (#19011)

* API for provider port (#19041)

* Update readme.md

* Create expressRouteProviderPort.json

* Create expressRouteProviderPortList.json

* Create expressRouteProviderPort.json

* Update custom-words.txt

* Update expressRouteProviderPort.json

* Update expressRouteProviderPortList.json

* Update expressRouteProviderPort.json

* Add WAF match variable operators (#18925)

### webapplicationfirewall.json
* Add GreaterThanOrEquals operator and Any operator to custom rule
  match conditions in WAF policy spec

* Add VirtualHub Router autoscale configuration (#19131)

Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com>

* Adding rule priority to Tls Proxy routing rule object model (#19135)

Co-authored-by: Vinay Mundada <vimundad@microsoft.com>

* swagger changes for new ssl policies (#19183)

* Update Swagger Spec for VMSS Packet Capture (#19202)

* Update Swagger Spec for VMSS Packet Capture

* Remove extra line

* Update Swagger spec for Connection Monitor VMSS (#19203)

* Adding new endpoint in ConnectionMonitor

* Changing ConnectionMonitor endpoints order

* Add flushConnection to NSG (#19085)

* Merge NetworkManger into 2022-01-01 (#19169)

* Merge NetworkManger into 2022-01-01

* Remove EffectiveVnet APIs

* Remove SecurityUser Resource

* update readme

* Fix as comments

* fix as comments

* remove network group type

* Add new parameter noInternetAdvertise to CustomIPPrefix (#19340)

* fix

* fix

Co-authored-by: Weiheng Li <weihl@microsoft.com>

* Route Server Integration feature swagger changes (#19215)

* Route Server Integration feature swagger changes

* prettier run changes

* updating api version in examples file

* fixing test errors

* fixing test errors

* fixing modelvalidation errors

* fixing test errors

* fixing modelvalidation errors

* changes based on review comments

* fixing lintdiff failure

* updating examples

* update wrong enum value for customipprefix (#19382)

* fix

* fix

* fix

Co-authored-by: Weiheng Li <weihl@microsoft.com>

* Updated ExplicitProxySettings to ExplicitProxy on Firewall Policy ver2022-01-01 (#19299)

Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com>

* Add resource type (#19434)

Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com>

* Fix prettier errors (#19462)

Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com>

Co-authored-by: uditmisra52 <103006702+uditmisra52@users.noreply.github.com>
Co-authored-by: jashsing-mic <79445297+jashsing-mic@users.noreply.github.com>
Co-authored-by: Anurag Kishore <kishore.1337.anurag@gmail.com>
Co-authored-by: AndriiKalinichenko <kalinichenkoandrew@gmail.com>
Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com>
Co-authored-by: Vinay Jayant Mundada <vinaymundada27@gmail.com>
Co-authored-by: Vinay Mundada <vimundad@microsoft.com>
Co-authored-by: kaushik-ms <103559254+kaushik-ms@users.noreply.github.com>
Co-authored-by: snagpal99 <95475229+snagpal99@users.noreply.github.com>
Co-authored-by: kumaam <102141910+kumaam@users.noreply.github.com>
Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com>
Co-authored-by: yanfa317 <53584318+yanfa317@users.noreply.github.com>
Co-authored-by: Weiheng Li <weihengli.tj@gmail.com>
Co-authored-by: Weiheng Li <weihl@microsoft.com>
Co-authored-by: Anchal Kapoor <ankapoo@microsoft.com>
Co-authored-by: Gizachew-Eshetie <gizchanie@gmail.com>
Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com>
    
    
    

    

    
    
  
    

    

  
  



    





  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @lirenhe
  
    lirenhe



          
            
              
            
          
          lirenhe approved these changes

        
    
      
    
          

  
      @MikhailTryakhov
  
    MikhailTryakhov


                Awaiting requested review from MikhailTryakhov


        
      
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @lirenhe
  
    lirenhe
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    CI-BreakingChange-JavaScript

  

    Network



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      2 participants
    
    
    
    
        
          @kumaam 
        
          @lirenhe