Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADF V2 Integration Runtime APIs - Fixed the model validation issues #2056

Merged
merged 22 commits into from
Nov 29, 2017
Merged

Add ADF V2 Integration Runtime APIs - Fixed the model validation issues #2056

merged 22 commits into from
Nov 29, 2017

Conversation

zhangyd2015
Copy link
Contributor

@zhangyd2015 zhangyd2015 commented Nov 28, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@zhangyd2015
Copy link
Contributor Author

zhangyd2015 commented Nov 28, 2017

@jianghaolu I addressed the issues in PR #2027 and created the new PR.

@jianghaolu
Copy link
Contributor

Thank you! Just be aware this change introduces breaking changes so you would need to address them in PowerShell and CLI.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@jianghaolu
Copy link
Contributor

@lmazuel Hi Laurent, Can you help me understand why this PR is failing Python validation? https://travis-ci.org/Azure/azure-rest-api-specs/jobs/308328040

@zhangyd2015
Copy link
Contributor Author

@jianghaolu Thanks. This breaking changes was introduced by adding an enum definition, which was also suggested by the model validation. So I believe it is good to go.

@jianghaolu
Copy link
Contributor

One linter issue - #2057.

@jianghaolu jianghaolu merged commit 90cd0b9 into Azure:current Nov 29, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants