Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFActory] Update #1656

Merged
merged 3 commits into from
Dec 1, 2017
Merged

[DataFActory] Update #1656

merged 3 commits into from
Dec 1, 2017

Conversation

AutorestCI
Copy link
Contributor

Generated from RestAPI PR: Azure/azure-rest-api-specs#2056

@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #1656 into master will decrease coverage by 0.01%.
The diff coverage is 55.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
- Coverage   55.37%   55.35%   -0.02%     
==========================================
  Files        4095     4188      +93     
  Lines       98361    99523    +1162     
==========================================
+ Hits        54465    55091     +626     
- Misses      43896    44432     +536
Impacted Files Coverage Δ
...ls/managed_integration_runtime_operation_result.py 45.45% <0%> (-4.55%) ⬇️
...ry/azure/mgmt/datafactory/models/linked_service.py 100% <100%> (ø) ⬆️
...ory/azure/mgmt/datafactory/models/copy_activity.py 100% <100%> (ø) ⬆️
...datafactory/models/azure_storage_linked_service.py 100% <100%> (ø) ⬆️
...tory/azure/mgmt/datafactory/operations/__init__.py 100% <100%> (ø) ⬆️
...datafactory/operations/activity_runs_operations.py 87.5% <100%> (+0.32%) ⬆️
...afactory/azure/mgmt/datafactory/models/__init__.py 100% <100%> (ø) ⬆️
...ry/azure/mgmt/datafactory/operations/operations.py 44.44% <100%> (+2.13%) ⬆️
...y/azure/mgmt/datafactory/models/lookup_activity.py 100% <100%> (ø) ⬆️
...ure/mgmt/datafactory/models/integration_runtime.py 100% <100%> (ø) ⬆️
... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000dff5...8a5b8cb. Read the comment docs.

@lmazuel lmazuel requested a review from hvermis November 30, 2017 00:30
@lmazuel lmazuel changed the title Automatic PR from RestAPI-PR2056 [DataFActory] Update Nov 30, 2017
@hvermis
Copy link
Contributor

hvermis commented Nov 30, 2017

Changes look good.
We also need to update the ADF SDK version to 0.3.0 to match our .Net SDK version, also because this release for ADF has client breaking changes. I will submit a PR for that after this one is merged.

@lmazuel lmazuel merged commit 059fcb8 into Azure:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants