Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant "rotate" from Keys API #25714

Merged
merged 3 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2193,10 +2193,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2205,15 +2204,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
heaths marked this conversation as resolved.
Show resolved Hide resolved
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2221,10 +2221,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2233,15 +2232,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2199,10 +2199,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2211,15 +2210,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2194,10 +2194,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2206,15 +2205,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2194,10 +2194,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2206,15 +2205,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
4 changes: 0 additions & 4 deletions specification/keyvault/data-plane/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -496,10 +496,6 @@ directive:
from: securitydomain.json
where: $.definitions.TransferKey.properties.key_format
reason: Consistency with other properties
- suppress: EnumUniqueValue
from: keys.json
where: $.definitions.LifetimeActionsType.properties.type
reason: SDK, docs workaround for current service behavior.
- suppress: DOUBLE_FORWARD_SLASHES_IN_URL
from: rbac.json
reason: / is a valid scope in this scenario.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -593,10 +593,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -605,15 +604,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -623,15 +622,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -623,15 +622,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -612,10 +612,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -624,15 +623,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -625,15 +624,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -625,15 +624,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -542,10 +542,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -554,15 +553,11 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
"description": "Trigger Event Grid events. Defaults to 30 days before expiry. Key Vault only."
"description": "Trigger Event Grid events."
}
]
}
Expand Down
Loading