Service Fabric Managed Clusters - api version 2023-09-01-preview #25779

a-santamaria · 2023-09-13T21:53:53Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-09-13T21:53:55Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-09-13T21:53:56Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
nodetype.json	2023-07-01-preview(dc827af)	2023-07-01-preview(main)

Rule	Message
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L961:9 Old: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L962:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L604:5 Old: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L604:5

️❌Breaking Change(Cross-Version): 17 Errors, 4 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
managedapplication.json	2023-09-01-preview(dc827af)	2022-01-01(main)
managedapplication.json	2023-09-01-preview(dc827af)	2023-07-01-preview(main)
managedcluster.json	2023-09-01-preview(dc827af)	2022-01-01(main)
managedcluster.json	2023-09-01-preview(dc827af)	2023-07-01-preview(main)
nodetype.json	2023-09-01-preview(dc827af)	2022-01-01(main)
nodetype.json	2023-09-01-preview(dc827af)	2023-07-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured? Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L37:5
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json#L665:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L576:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json#L670:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L580:9
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L1179:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1006:7
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json#L890:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L1225:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1052:11
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L150:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L150:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L187:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L187:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L208:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L208:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L214:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L214:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L275:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L265:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L1165:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L995:5
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L1355:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L1473:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L871:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L1607:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json#L665:9 Old: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L634:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json#L670:9 Old: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L638:9
⚠️ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json#L1114:9 Old: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L962:9
⚠️ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json#L636:5 Old: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L604:5

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-07-preview	package-2023-07-preview(dc827af)	package-2023-07-preview(main)
package-2023-09-preview	package-2023-09-preview(dc827af)	default(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'ManagedClusterVersion_List' does not match the response definition in the individual GET operation 'ManagedClusterVersion_Get' . Location: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L561
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'ManagedClusterVersion_ListByEnvironment' does not match the response definition in the individual GET operation 'ManagedClusterVersion_GetByEnvironment' . Location: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L601
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getazresiliencystatus' in:'managedAzResiliencyStatus_Get'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L353
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getmaintenancewindowstatus' in:'managedMaintenanceWindowStatus_Get'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L396
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'applymaintenancewindow' in:'managedApplyMaintenanceWindow_Post'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L439
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Maintenance Window Status Location: Microsoft.ServiceFabric/preview/2023-09-01-preview/managedcluster.json#L454

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-13T21:53:57Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 70d1faf. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.ServiceFabricManagedClusters [View full logs] [Release SDK Changes]
- Azure.ResourceManager.ServiceFabricManagedClusters.1.1.0-alpha.20230927.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 70d1faf. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group ManagedApplyMaintenanceWindowOperations
info	[Changelog]   - Added operation group ManagedMaintenanceWindowStatusOperations
info	[Changelog]   - Model ManagedCluster has a new parameter ddos_protection_plan_id
info	[Changelog]   - Model ManagedCluster has a new parameter public_ip_prefix_id
info	[Changelog]   - Model NodeType has a new parameter additional_network_interface_configurations
info	[Changelog]   - Model NodeType has a new parameter dscp_configuration_id
info	[Changelog]   - Model NodeType has a new parameter enable_node_public_i_pv6
info	[Changelog]   - Model NodeType has a new parameter nat_gateway_id
info	[Changelog]   - Model NodeType has a new parameter service_artifact_reference_id
info	[Changelog]   - Model NodeType has a new parameter vm_image_plan
info	[Changelog]   - Model VMSSExtension has a new parameter setup_order

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 70d1faf. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️servicefabricmanagedclusters [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 70d1faf. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.servicefabricmanagedclusters.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.servicefabricmanagedclusters.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-13T21:53:58Z

Generated ApiView

Language	Package Name	ApiView Link
.Net	Azure.ResourceManager.ServiceFabricManagedClusters	https://apiview.dev/Assemblies/Review/2322fe094f334a43b636d4926f90595a

openapi-workflow-bot · 2023-09-13T22:00:10Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

openapi-workflow-bot · 2023-09-13T22:00:11Z

Hi @a-santamaria! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

a-santamaria · 2023-09-13T22:15:44Z

/azp run

azure-pipelines · 2023-09-13T22:15:55Z

Azure Pipelines successfully started running 2 pipeline(s).

sjanamma · 2023-09-16T22:01:46Z

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/applications/{applicationName}/upgrade/read": {

This is not a valid path.

To fetch the application status you could possibly use this URI

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/applications/{applicationName}/fetchUpgradeStatus" #Resolved

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/managedapplication.json:582 in 4b9057d. [](commit_id = 4b9057d, deletion_comment = False)

sjanamma · 2023-09-16T22:04:14Z

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/applications/{applicationName}/upgrade/read": {

/upgrade/ segment can be removed and action can be /rollbackUpgrade

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/applications/{applicationName}/rollbackUpgrade: {

#Resolved

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/managedapplication.json:582 in 4b9057d. [](commit_id = 4b9057d, deletion_comment = False)

sjanamma · 2023-09-16T22:04:51Z

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/applications/{applicationName}/upgrade/resume": {

Please review all the post call paths #Resolved

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/managedapplication.json:682 in 4b9057d. [](commit_id = 4b9057d, deletion_comment = False)

sjanamma · 2023-09-16T22:08:42Z

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services/{serviceName}/partitions/readList": {

This is supposed to be List call. Also, the number of segments is more than what is allowed. You may need to model this differently to follow the standards.

lso, this is violating the multiple levels of nested types in this URI #Resolved

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/managedapplication.json:1085 in 4b9057d. [](commit_id = 4b9057d, deletion_comment = False)

...edclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json

a-santamaria · 2023-09-18T21:06:25Z

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/applications/{applicationName}/upgrade/read": {
This is not a valid path.

To fetch the application status you could possibly use this URI

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/applications/{applicationName}/fetchUpgradeStatus"

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/managedapplication.json:582 in 4b9057d. [](commit_id = 4b9057d, deletion_comment = False)

Thanks for the review @sjanamma. Is it not valid because upgrade is not model as a resource?
We found this doc about actions https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#performing-an-action. Is there any other that we need to look at?

a-santamaria · 2023-09-18T21:07:09Z

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services/{serviceName}/partitions/readList": {
This is supposed to be List call. Also, the number of segments is more than what is allowed. You may need to model this differently to follow the standards.

lso, this is violating the multiple levels of nested types in this URI

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/managedapplication.json:1085 in 4b9057d. [](commit_id = 4b9057d, deletion_comment = False)

@sjanamma what is the allowed number of segments? and what do you mean by "violating the multiple levels of nested types in this URI" ?

a-santamaria · 2023-09-18T21:38:24Z

@sjanamma I have reverted app actions. We will add them in the next api because we will need changes on our service

a-santamaria · 2023-09-26T18:09:49Z

@rkmanda can you merge the pr please. its already signed off

a-santamaria · 2023-09-26T18:10:59Z

/pr RequestMerge

openapi-pipeline-app · 2023-09-27T16:02:25Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

danielrbradley · 2023-10-03T10:24:22Z

@raosuhas and @a-santamaria hello, I'm having some issues with downstream tooling having consumed this update 👋

This version introduces two versions of the IP Tag definition - in nodetype.json and managedcluster.json.
In managedcluster.json it's named #/definitions/IPTag.
In nodetype.json it's named #/definitions/IpTag.

This causes an issue because both types exist in the same namespace, but only vary by case. We use these type names to generate files, but dependant on the case-insensitivity of the filesystem, these two files then conflict with one another.

Other versions of this specification only use the capitalized IPTag version. Would it be possible to upate the definition in nodetype.json to match?

) * remove default on eviction type * initial commit copy from 2023-07-01-preview * udpate specs * update examples * add format arm-id * revert app actions --------- Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

Alfredo Santamaria Gomez added 4 commits September 5, 2023 12:47

remove default on eviction type

db16b2c

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs

ce17cdb

initial commit copy from 2023-07-01-preview

c23781b

udpate specs

5330549

openapi-assignment-bot bot assigned rkmanda Sep 13, 2023

update examples

4b9057d

a-santamaria force-pushed the sfmc-2023-09-01-preview branch from f280982 to 4b9057d Compare September 13, 2023 22:00

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 13, 2023

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 14, 2023

a-santamaria added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 14, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 14, 2023

a-santamaria removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 14, 2023

sjanamma reviewed Sep 17, 2023

View reviewed changes

...edclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json Show resolved Hide resolved

sjanamma reviewed Sep 17, 2023

View reviewed changes

...edclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-09-01-preview/nodetype.json Show resolved Hide resolved

sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 17, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 17, 2023

Alfredo Santamaria Gomez added 2 commits September 18, 2023 14:36

add format arm-id

e1835c8

revert app actions

dc827af

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 18, 2023

a-santamaria removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 19, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2023

visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 19, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2023

github-actions bot added the MergeRequested label Sep 26, 2023

raosuhas approved these changes Sep 27, 2023

View reviewed changes

raosuhas merged commit 70d1faf into Azure:main Sep 27, 2023
29 of 30 checks passed

danielrbradley mentioned this pull request Oct 3, 2023

Nightly generation failure pulumi/pulumi-azure-native#2796

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Service Fabric Managed Clusters - api version 2023-09-01-preview #25779

Service Fabric Managed Clusters - api version 2023-09-01-preview #25779

a-santamaria commented Sep 13, 2023

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

openapi-workflow-bot bot commented Sep 13, 2023

openapi-workflow-bot bot commented Sep 13, 2023

a-santamaria commented Sep 13, 2023

azure-pipelines bot commented Sep 13, 2023

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading

a-santamaria commented Sep 18, 2023

a-santamaria commented Sep 18, 2023

a-santamaria commented Sep 18, 2023

a-santamaria commented Sep 26, 2023

a-santamaria commented Sep 26, 2023

openapi-pipeline-app bot commented Sep 27, 2023

danielrbradley commented Oct 3, 2023

Service Fabric Managed Clusters - api version 2023-09-01-preview #25779

Service Fabric Managed Clusters - api version 2023-09-01-preview #25779

Conversation

a-santamaria commented Sep 13, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Sep 13, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 13, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 13, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 13, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 13, 2023

openapi-workflow-bot bot commented Sep 13, 2023

a-santamaria commented Sep 13, 2023

azure-pipelines bot commented Sep 13, 2023

sjanamma commented Sep 16, 2023 • edited by visingla-ms Loading

sjanamma commented Sep 16, 2023 • edited by visingla-ms Loading

sjanamma commented Sep 16, 2023 • edited by visingla-ms Loading

sjanamma commented Sep 16, 2023 • edited by visingla-ms Loading

a-santamaria commented Sep 18, 2023

a-santamaria commented Sep 18, 2023

a-santamaria commented Sep 18, 2023

a-santamaria commented Sep 26, 2023

a-santamaria commented Sep 26, 2023

openapi-pipeline-app bot commented Sep 27, 2023

danielrbradley commented Oct 3, 2023

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 13, 2023 •

edited

Loading

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading

sjanamma commented Sep 16, 2023 •

edited by visingla-ms

Loading