Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly generation failure #2796

Closed
danielrbradley opened this issue Oct 3, 2023 · 0 comments · Fixed by #2799
Closed

Nightly generation failure #2796

danielrbradley opened this issue Oct 3, 2023 · 0 comments · Fixed by #2799
Assignees
@danielrbradley
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone
0.95

Comments

@danielrbradley
Copy link
Member

danielrbradley commented Oct 3, 2023 •
edited
Loading

Started failing on the 28th September:

PR is generated but the dotnet SDK fails to build:

Error: /home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/ServiceFabric/V20230901Preview/GetManagedCluster.cs(175,48): error CS0234: The type or namespace name 'IPTagResponse' does not exist in the namespace 'Pulumi.AzureNative.ServiceFabric.V20230901Preview.Outputs' (are you missing an assembly reference?) [/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/Pulumi.AzureNative.csproj]
Error: /home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/ServiceFabric/V20230901Preview/GetManagedCluster.cs(297,36): error CS0234: The type or namespace name 'IPTagResponse' does not exist in the namespace 'Pulumi.AzureNative.ServiceFabric.V20230901Preview.Outputs' (are you missing an assembly reference?) [/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/Pulumi.AzureNative.csproj]
Error: /home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/ServiceFabric/V20230901Preview/Inputs/IpConfigurationPublicIPAddressConfigurationArgs.cs(24,33): error CS0234: The type or namespace name 'IpTagArgs' does not exist in the namespace 'Pulumi.AzureNative.ServiceFabric.V20230901Preview.Inputs' (are you missing an assembly reference?) [/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/Pulumi.AzureNative.csproj]
Error: /home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/ServiceFabric/V20230901Preview/Inputs/IpConfigurationPublicIPAddressConfigurationArgs.cs(19,34): error CS0234: The type or namespace name 'IpTagArgs' does not exist in the namespace 'Pulumi.AzureNative.ServiceFabric.V20230901Preview.Inputs' (are you missing an assembly reference?) [/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/Pulumi.AzureNative.csproj]
Error: /home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/ServiceFabric/V20230901Preview/ManagedCluster.cs(166,46): error CS0234: The type or namespace name 'IPTagResponse' does not exist in the namespace 'Pulumi.AzureNative.ServiceFabric.V20230901Preview.Outputs' (are you missing an assembly reference?) [/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/Pulumi.AzureNative.csproj]

This has been caused by the addition of a new ServiceFabric version: Azure/azure-rest-api-specs#25779.

This version introduces two versions of the IP Tag definition - in nodetype.json and managedcluster.json.
In managedcluster.json it's named #/definitions/IPTag.
In nodetype.json it's named #/definitions/IpTag.

Have notified upstream to the issue, but we'll likely need to normalize this our side too.
@danielrbradley danielrbradley added kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer labels Oct 3, 2023
@danielrbradley danielrbradley self-assigned this Oct 3, 2023
@danielrbradley danielrbradley mentioned this issue Oct 3, 2023
Merged
@mikhailshilkov mikhailshilkov added this to the 0.95 milestone Oct 4, 2023
danielrbradley added a commit that referenced this issue Oct 4, 2023
@danielrbradley
Capture and correct type case conflicts (#2799)
78c6b20 
1. Introduce a type for normalising case sensitive tokens. This just
uses the first variant it sees.
2. Declare this collection globally and pass down into each module
generation.
3. Normalise the type token before visiting and generating each type.
4. Add report to list any time we change the case of a type.

Fixes #2796 

Tested locally having rebased on top of latest nightly branch.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrbradley danielrbradley

Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.95
Development

Successfully merging a pull request may close this issue.

Capture and correct type case conflicts pulumi/pulumi-azure-native
3 participants
@danielrbradley @mikhailshilkov @pulumi-bot