-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Publish private branch 'JeetendraJoshi-MSFT-mobilenetwork-Microsoft.MobileNetwork-2023-09-01' #26133
Conversation
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/14661 |
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
attachedDataNetwork.json | 2023-09-01(883e137) | 2023-06-01(main) |
attachedDataNetwork.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
common.json | 2023-09-01(883e137) | 2023-06-01(main) |
common.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
dataNetwork.json | 2023-09-01(883e137) | 2023-06-01(main) |
dataNetwork.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
diagnosticsPackage.json | 2023-09-01(883e137) | 2023-06-01(main) |
mobileNetwork.json | 2023-09-01(883e137) | 2023-06-01(main) |
mobileNetwork.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
operation.json | 2023-09-01(883e137) | 2023-06-01(main) |
operation.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
packetCapture.json | 2023-09-01(883e137) | 2023-06-01(main) |
packetCoreControlPlane.json | 2023-09-01(883e137) | 2023-06-01(main) |
packetCoreControlPlane.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
packetCoreDataPlane.json | 2023-09-01(883e137) | 2023-06-01(main) |
packetCoreDataPlane.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
service.json | 2023-09-01(883e137) | 2023-06-01(main) |
service.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
sim.json | 2023-09-01(883e137) | 2023-06-01(main) |
simGroup.json | 2023-09-01(883e137) | 2023-06-01(main) |
simPolicy.json | 2023-09-01(883e137) | 2023-06-01(main) |
simPolicy.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
site.json | 2023-09-01(883e137) | 2023-06-01(main) |
slice.json | 2023-09-01(883e137) | 2023-06-01(main) |
slice.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
ts29571.json | 2023-09-01(883e137) | 2023-06-01(main) |
ts29571.json | 2023-09-01(883e137) | 2022-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/listSimIds' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L315:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/sites/{siteName}' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L367:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/mobileNetworks/{mobileNetworkName}/sites' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L576:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L621:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MobileNetwork/simGroups' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L818:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L857:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}/sims/{simName}' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L899:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MobileNetwork/simGroups/{simGroupName}/sims' removed or restructured? Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1056:5 |
|
The new version is missing a definition that was found in the old version. Was 'SimGroup' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimGroupPropertiesFormat' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'KeyVaultKey' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'Sim' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimPropertiesFormat' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'Site' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SitePropertiesFormat' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimPolicyResourceId' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'SimState' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'MobileNetworkResourceId' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'UserAssignedIdentities' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentityType' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L316:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/mobileNetwork.json#L1102:3 |
|
The new version is missing a definition that was found in the old version. Was 'KeyVaultCertificate' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L630:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3 |
|
The new version is missing a definition that was found in the old version. Was 'MobileNetworkResourceId' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L630:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3 |
|
The new version is missing a definition that was found in the old version. Was 'TagsObject' removed or renamed? New: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L630:3 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L392:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'SimGroupNameParameter' removed or renamed? New: azure-rest-api-specs/blob/883e1379882fc217f77fd294cf1f86f444f053ce/revision#L1053:2 Old: azure-rest-api-specs/blob/main/revision#L2960:2 |
|
The new version is missing a client parameter that was found in the old version. Was 'SimNameParameter' removed or renamed? New: azure-rest-api-specs/blob/883e1379882fc217f77fd294cf1f86f444f053ce/revision#L1053:2 Old: azure-rest-api-specs/blob/main/revision#L2960:2 |
|
The new version is missing a client parameter that was found in the old version. Was 'SiteNameParameter' removed or renamed? New: azure-rest-api-specs/blob/883e1379882fc217f77fd294cf1f86f444f053ce/revision#L1053:2 Old: azure-rest-api-specs/blob/main/revision#L2960:2 |
|
The operation id has been changed from 'PacketCoreControlPlaneVersions_ListByResourceGroup' to 'PacketCoreControlPlaneVersions_List'. This will impact generated code. New: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L512:7 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L356:7 |
|
The '$ref' property points to different models in the old and new versions. New: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L1047:9 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L539:9 |
|
The '$ref' property points to different models in the old and new versions. New: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L201:13 Old: Microsoft.MobileNetwork/preview/2022-04-01-preview/packetCoreControlPlane.json#L201:13 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2023-09 | package-2023-09(883e137) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/attachedDataNetwork.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/attachedDataNetwork.json#L68 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/dataNetwork.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/dataNetwork.json#L65 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/diagnosticsPackage.json#L134 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/diagnosticsPackage.json#L161 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/mobileNetwork.json#L62 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.MobileNetwork/stable/2023-09-01/operation.json#L53 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCapture.json#L143 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCapture.json#L170 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCapture.json#L225 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L62 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L343 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L392 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L450 |
ResourceNameRestriction |
The resource name parameter 'versionName' should be defined with a 'pattern' restriction. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L471 |
ResourceNameRestriction |
The resource name parameter 'versionName' should be defined with a 'pattern' restriction. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreControlPlane.json#L547 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreDataPlane.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/packetCoreDataPlane.json#L65 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/service.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/service.json#L65 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/sim.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/sim.json#L65 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/sim.json#L276 |
PostResponseCodes |
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/sim.json#L298 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/sim.json#L334 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.MobileNetwork/stable/2023-09-01/sim.json#L395 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.MobileNetwork/stable/2023-09-01/simGroup.json#L38 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
3644551
to
e47eef0
Compare
For the ARM reviewer - this PR takes changes from the private repo into the public repo. All changes in this PR have already been reviewed in https://github.com/Azure/azure-rest-api-specs-pr/pull/14661 and https://github.com/Azure/azure-rest-api-specs-pr/pull/15079. |
/pr RequestMerge |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
…work-Microsoft.MobileNetwork-2023-09-01' (#26133) * add or modify files * Added Packet Capture Updates to 2023-09-01-Base * Updated ReadME
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.