[mgmt] mobilenetwork release #27604
[mgmt] mobilenetwork release #27604
Conversation
kazrael2119
requested review from
ckairen,
deyaaeldeen,
jeremymeng,
bterlson and
xirzec
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| @@ -3292,7 +3412,7 @@ export const PacketCapture: coreClient.CompositeMapper = { | |||
| defaultValue: 67108864, | |||
| constraints: { | |||
| InclusiveMaximum: 4294967295, | |||
| InclusiveMinimum: 0 | |||
| InclusiveMinimum: 1000 | |||
There was a problem hiding this comment.
feel like this is a breaking change. because what used to work like under 1000 but not now.
There was a problem hiding this comment.
this change is approved in api level Azure/azure-rest-api-specs#26133 (comment)
There was a problem hiding this comment.
we should bump major version here.
There was a problem hiding this comment.
We never released PacketCapture in the old API, so we are safe to release without a major bump.
There was a problem hiding this comment.
the last release version is 2023-06-01 which contains PacketCapture, so I think we should bump a major version
last release request: https://github.com/Azure/sdk-release-request/issues/4278
https://github.com/Azure/sdk-release-request/issues/4650