Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-10-02-preview #26610

Conversation

FumingZhang
Copy link
Member

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

FumingZhang and others added 11 commits November 8, 2023 10:28
…eview/2023-09-02-preview to version 2023-10-02-preview
* Add flexible virtualMachines profile and status to AP properties

* add new line

* fix

* fix

---------

Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
…6415)

* Adding privatedns to allowedresource types for dnsZoneResourceIds

* fix style
* impl

* fix

* fix

* fix

* fix

* fix
* update CRGID definition

* change CRGID to CapacityReservationGroupID

---------

Co-authored-by: tong chen <tonche@microsoft.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
* impl

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Wen Huang <wenhuang@microsoft.com>
Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 12 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
managedClusters.json 2023-10-02-preview(79de171) 2023-10-01(main)
managedClusters.json 2023-10-02-preview(79de171) 2023-09-02-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4569:9
Old: aks/stable/2023-10-01/managedClusters.json#L3618:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4573:9
Old: aks/stable/2023-10-01/managedClusters.json#L3646:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4577:9
Old: aks/stable/2023-10-01/managedClusters.json#L3663:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4581:9
Old: aks/stable/2023-10-01/managedClusters.json#L3690:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4586:9
Old: aks/stable/2023-10-01/managedClusters.json#L3713:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4642:9
Old: aks/stable/2023-10-01/managedClusters.json#L3787:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4673:11
Old: aks/stable/2023-10-01/managedClusters.json#L3836:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: aks/preview/2023-10-02-preview/managedClusters.json#L5559:13
Old: aks/stable/2023-10-01/managedClusters.json#L4625:13


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4063:9
Old: aks/preview/2023-09-02-preview/managedClusters.json#L3792:9
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: aks/preview/2023-10-02-preview/managedClusters.json#L4063:9
Old: aks/preview/2023-09-02-preview/managedClusters.json#L3792:9
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: aks/preview/2023-10-02-preview/managedClusters.json#L8270:5
Old: aks/preview/2023-09-02-preview/managedClusters.json#L7998:5
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'expanders' renamed or removed?
New: aks/preview/2023-10-02-preview/managedClusters.json#L5538:11
Old: aks/preview/2023-09-02-preview/managedClusters.json#L5261:11
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 42 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-10 package-preview-2023-10(79de171) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
⚠️ RequiredReadOnlySystemData The response of operation:'Machines_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1458
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2478
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2481
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2484
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2523
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2526
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2529
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2535
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2568
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2571
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2574
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2583
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get OperationStatusResult
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2600
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L3968
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: aks/preview/2023-10-02-preview/managedClusters.json#L4680
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L4683
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: aks/preview/2023-10-02-preview/managedClusters.json#L4709
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L5515
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L5544
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L5549
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L5554
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L5846
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7136
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7153
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7156
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7163
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7166
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7485
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7771
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L7831


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L52
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L53
ParametersInPointGet Query parameter resource-type should be removed. Point Get's MUST not have query parameters other than api version.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L80
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L137
ResourceNameRestriction The resource name parameter 'roleName' should be defined with a 'pattern' restriction.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L278
ParametersInPost server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L336
ParametersInPost server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L381
ParametersInPost format is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L381
ParametersInPost server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L429
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L553
PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L660
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L679
LroPatch202 The async patch operation should return 202.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L689
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L699
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L749
ResourceNameRestriction The resource name parameter 'configName' should be defined with a 'pattern' restriction.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L809
PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L979
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1023
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1175
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1291
OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1510
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1530
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1549
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1595
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1611
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1658
PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1674
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1715
PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1731
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1768
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/containerservice/armcontainerservice - Approved - 5.0.0
+	Function `*timeRFC3339.Parse` has been removed
+	Function `*timeRFC3339.UnmarshalText` has been removed
+	Function `timeRFC3339.MarshalText` has been removed

azure-sdk-for-python-track2 - track2_azure-mgmt-containerservice - Approved - 27.0.0
+	Renamed operation TrustedAccessRoleBindingsOperations.create_or_update to TrustedAccessRoleBindingsOperations.begin_create_or_update
+	Renamed operation TrustedAccessRoleBindingsOperations.delete to TrustedAccessRoleBindingsOperations.begin_delete
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 8cd51b5. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-containerservice [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation AgentPoolsOperations.begin_delete_machines
    info	[Changelog]   - Added operation ManagedClustersOperations.get_guardrails_versions
    info	[Changelog]   - Added operation ManagedClustersOperations.list_guardrails_versions
    info	[Changelog]   - Added operation group OperationStatusResultOperations
    info	[Changelog]   - Model AgentPool has a new parameter artifact_streaming_profile
    info	[Changelog]   - Model AgentPool has a new parameter capacity_reservation_group_id
    info	[Changelog]   - Model AgentPool has a new parameter enable_custom_ca_trust
    info	[Changelog]   - Model AgentPool has a new parameter gpu_profile
    info	[Changelog]   - Model AgentPool has a new parameter message_of_the_day
    info	[Changelog]   - Model AgentPool has a new parameter network_profile
    info	[Changelog]   - Model AgentPool has a new parameter node_initialization_taints
    info	[Changelog]   - Model AgentPool has a new parameter security_profile
    info	[Changelog]   - Model AgentPool has a new parameter virtual_machine_nodes_status
    info	[Changelog]   - Model AgentPool has a new parameter virtual_machines_profile
    info	[Changelog]   - Model AgentPool has a new parameter windows_profile
    info	[Changelog]   - Model AgentPoolUpgradeSettings has a new parameter node_soak_duration_in_minutes
    info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter kube_proxy_config
    info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter monitoring
    info	[Changelog]   - Model ManagedCluster has a new parameter ai_toolchain_operator_profile
    info	[Changelog]   - Model ManagedCluster has a new parameter creation_data
    info	[Changelog]   - Model ManagedCluster has a new parameter enable_namespace_resources
    info	[Changelog]   - Model ManagedCluster has a new parameter guardrails_profile
    info	[Changelog]   - Model ManagedCluster has a new parameter ingress_profile
    info	[Changelog]   - Model ManagedCluster has a new parameter metrics_profile
    info	[Changelog]   - Model ManagedCluster has a new parameter node_provisioning_profile
    info	[Changelog]   - Model ManagedCluster has a new parameter node_resource_group_profile
    info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter enable_vnet_integration
    info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter subnet_id
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter artifact_streaming_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter capacity_reservation_group_id
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter enable_custom_ca_trust
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter gpu_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter message_of_the_day
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter network_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter node_initialization_taints
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter security_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter virtual_machine_nodes_status
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter virtual_machines_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter windows_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter artifact_streaming_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter capacity_reservation_group_id
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter enable_custom_ca_trust
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter gpu_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter message_of_the_day
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter network_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter node_initialization_taints
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter security_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter virtual_machine_nodes_status
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter virtual_machines_profile
    info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter windows_profile
    info	[Changelog]   - Model ManagedClusterAzureMonitorProfile has a new parameter logs
    info	[Changelog]   - Model ManagedClusterAzureMonitorProfileMetrics has a new parameter app_monitoring_open_telemetry_metrics
    info	[Changelog]   - Model ManagedClusterHTTPProxyConfig has a new parameter effective_no_proxy
    info	[Changelog]   - Model ManagedClusterLoadBalancerProfile has a new parameter backend_pool_type
    info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_empty_nodes
    info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_occupied_nodes
    info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter ignore_daemonsets_utilization
    info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter custom_ca_trust_certificates
    info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter image_integrity
    info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter node_restriction
    info	[Changelog]   - Model ManagedClusterStorageProfileDiskCSIDriver has a new parameter version
    info	[Changelog]   - Model ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler has a new parameter addon_autoscaling
    info	[Changelog]   - Operation AgentPoolsOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
    info	[Changelog]   - Operation ManagedClustersOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Renamed operation TrustedAccessRoleBindingsOperations.create_or_update to TrustedAccessRoleBindingsOperations.begin_create_or_update
    info	[Changelog]   - Renamed operation TrustedAccessRoleBindingsOperations.delete to TrustedAccessRoleBindingsOperations.begin_delete
️⚠️ azure-sdk-for-java warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 8cd51b5. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/containerservice/armcontainerservice [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Function `timeRFC3339.MarshalText` has been removed
    info	[Changelog] - Function `*timeRFC3339.Parse` has been removed
    info	[Changelog] - Function `*timeRFC3339.UnmarshalText` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `BackendPoolType` with values `BackendPoolTypeNodeIP`, `BackendPoolTypeNodeIPConfiguration`
    info	[Changelog] - New enum type `Protocol` with values `ProtocolTCP`, `ProtocolUDP`
    info	[Changelog] - New enum type `TrustedAccessRoleBindingProvisioningState` with values `TrustedAccessRoleBindingProvisioningStateCanceled`, `TrustedAccessRoleBindingProvisioningStateDeleting`, `TrustedAccessRoleBindingProvisioningStateFailed`, `TrustedAccessRoleBindingProvisioningStateSucceeded`, `TrustedAccessRoleBindingProvisioningStateUpdating`
    info	[Changelog] - New function `*ClientFactory.NewTrustedAccessRoleBindingsClient() *TrustedAccessRoleBindingsClient`
    info	[Changelog] - New function `*ClientFactory.NewTrustedAccessRolesClient() *TrustedAccessRolesClient`
    info	[Changelog] - New function `NewTrustedAccessRoleBindingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TrustedAccessRoleBindingsClient, error)`
    info	[Changelog] - New function `*TrustedAccessRoleBindingsClient.BeginCreateOrUpdate(context.Context, string, string, string, TrustedAccessRoleBinding, *TrustedAccessRoleBindingsClientBeginCreateOrUpdateOptions) (*runtime.Poller[TrustedAccessRoleBindingsClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*TrustedAccessRoleBindingsClient.BeginDelete(context.Context, string, string, string, *TrustedAccessRoleBindingsClientBeginDeleteOptions) (*runtime.Poller[TrustedAccessRoleBindingsClientDeleteResponse], error)`
    info	[Changelog] - New function `*TrustedAccessRoleBindingsClient.Get(context.Context, string, string, string, *TrustedAccessRoleBindingsClientGetOptions) (TrustedAccessRoleBindingsClientGetResponse, error)`
    info	[Changelog] - New function `*TrustedAccessRoleBindingsClient.NewListPager(string, string, *TrustedAccessRoleBindingsClientListOptions) *runtime.Pager[TrustedAccessRoleBindingsClientListResponse]`
    info	[Changelog] - New function `NewTrustedAccessRolesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TrustedAccessRolesClient, error)`
    info	[Changelog] - New function `*TrustedAccessRolesClient.NewListPager(string, *TrustedAccessRolesClientListOptions) *runtime.Pager[TrustedAccessRolesClientListResponse]`
    info	[Changelog] - New function `dateTimeRFC3339.MarshalText() ([]byte, error)`
    info	[Changelog] - New function `*dateTimeRFC3339.Parse(string) error`
    info	[Changelog] - New function `*dateTimeRFC3339.UnmarshalText([]byte) error`
    info	[Changelog] - New struct `AgentPoolNetworkProfile`
    info	[Changelog] - New struct `IPTag`
    info	[Changelog] - New struct `PortRange`
    info	[Changelog] - New struct `TrustedAccessRole`
    info	[Changelog] - New struct `TrustedAccessRoleBinding`
    info	[Changelog] - New struct `TrustedAccessRoleBindingListResult`
    info	[Changelog] - New struct `TrustedAccessRoleBindingProperties`
    info	[Changelog] - New struct `TrustedAccessRoleListResult`
    info	[Changelog] - New struct `TrustedAccessRoleRule`
    info	[Changelog] - New field `CapacityReservationGroupID`, `NetworkProfile` in struct `ManagedClusterAgentPoolProfile`
    info	[Changelog] - New field `CapacityReservationGroupID`, `NetworkProfile` in struct `ManagedClusterAgentPoolProfileProperties`
    info	[Changelog] - New field `BackendPoolType` in struct `ManagedClusterLoadBalancerProfile`
    info	[Changelog]
    info	[Changelog] Total 3 breaking change(s), 45 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 8cd51b5. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-containerservice [View full logs]  [Release SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group TrustedAccessRoleBindings
    info	[Changelog]   - Added operation group TrustedAccessRoles
    info	[Changelog]   - Added Interface AgentPoolNetworkProfile
    info	[Changelog]   - Added Interface ErrorAdditionalInfo
    info	[Changelog]   - Added Interface ErrorDetail
    info	[Changelog]   - Added Interface ErrorResponse
    info	[Changelog]   - Added Interface IPTag
    info	[Changelog]   - Added Interface PortRange
    info	[Changelog]   - Added Interface TrustedAccessRole
    info	[Changelog]   - Added Interface TrustedAccessRoleBinding
    info	[Changelog]   - Added Interface TrustedAccessRoleBindingListResult
    info	[Changelog]   - Added Interface TrustedAccessRoleBindingsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface TrustedAccessRoleBindingsDeleteHeaders
    info	[Changelog]   - Added Interface TrustedAccessRoleBindingsDeleteOptionalParams
    info	[Changelog]   - Added Interface TrustedAccessRoleBindingsGetOptionalParams
    info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListNextOptionalParams
    info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListOptionalParams
    info	[Changelog]   - Added Interface TrustedAccessRoleListResult
    info	[Changelog]   - Added Interface TrustedAccessRoleRule
    info	[Changelog]   - Added Interface TrustedAccessRolesListNextOptionalParams
    info	[Changelog]   - Added Interface TrustedAccessRolesListOptionalParams
    info	[Changelog]   - Added Type Alias BackendPoolType
    info	[Changelog]   - Added Type Alias Protocol
    info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingProvisioningState
    info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsDeleteResponse
    info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsGetResponse
    info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListNextResponse
    info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListResponse
    info	[Changelog]   - Added Type Alias TrustedAccessRolesListNextResponse
    info	[Changelog]   - Added Type Alias TrustedAccessRolesListResponse
    info	[Changelog]   - Interface AgentPool has a new optional parameter capacityReservationGroupID
    info	[Changelog]   - Interface AgentPool has a new optional parameter networkProfile
    info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter capacityReservationGroupID
    info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter networkProfile
    info	[Changelog]   - Interface ManagedClusterLoadBalancerProfile has a new optional parameter backendPoolType
    info	[Changelog]   - Added Enum KnownBackendPoolType
    info	[Changelog]   - Added Enum KnownProtocol
    info	[Changelog]   - Added Enum KnownTrustedAccessRoleBindingProvisioningState
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️❌ azure-resource-manager-schemas failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 8cd51b5. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
    cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
    Error: cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
  • ️✔️containerservice [View full logs
  • ️✔️containerservice [View full logs
    error	Fatal error: cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
    error	The following packages are still pending:
    error		containerservice
    error		containerservice
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 8cd51b5. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.containerservice.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.containerservice.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/containerservice/armcontainerservice https://apiview.dev/Assemblies/Review/ed09f6bc4e5b48edb4205471ad11f1e8
Java azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated https://apiview.dev/Assemblies/Review/c63161a302d848b9bae6c2015aa8e2e3
.Net Azure.ResourceManager.ContainerService There is no API change compared with the previous version
JavaScript @azure/arm-containerservice https://apiview.dev/Assemblies/Review/947fd56880c94b59932b4cd075756012

@zizw123
Copy link

zizw123 commented Nov 8, 2023

  "post": {

Why is this being modeled as POST? Can you add some context? Instead can you use DELETE?


Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-10-02-preview/managedClusters.json:1352 in 79de171. [](commit_id = 79de171, deletion_comment = False)

@zizw123 zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 8, 2023
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 8, 2023
@xuexu6666
Copy link
Contributor

xuexu6666 commented Nov 9, 2023

  "post": {

Why is this being modeled as POST? Can you add some context? Instead can you use DELETE?

Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-10-02-preview/managedClusters.json:1352 in 79de171. [](commit_id = 79de171, deletion_comment = False)

https://learn.microsoft.com/en-us/rest/api/compute/virtual-machine-scale-sets/delete-instances?view=rest-compute-2023-07-01&tabs=HTTP

The above link is a very similar API in VMSS, where user can delete multiple instances from VMSS. The reason we model it as post is 1. We want to align with current VMSS implementation. 2. Since we want to delete multiple machines from an agent pool, user need to provide a list of machine names like "machines": { "machineNames": [ "aks-nodepool1-42263519-vmss00000a", "aks-nodepool1-42263519-vmss00000b" ] } as request body.

@zizw123

@FumingZhang FumingZhang removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 9, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 9, 2023
@FumingZhang
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@zizw123 zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 9, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 9, 2023
@FumingZhang
Copy link
Member Author

FumingZhang commented Nov 13, 2023

@raych1 could you please help approve the SDK breaking change - go?

image

@raych1 raych1 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 14, 2023
@FumingZhang
Copy link
Member Author

/pr RequestMerge

@TimLovellSmith TimLovellSmith merged commit 8cd51b5 into main Nov 14, 2023
27 of 30 checks passed
@TimLovellSmith TimLovellSmith deleted the FumingZhang-containerservice-Microsoft.ContainerService-2023-10-02-preview branch November 14, 2023 22:05
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

zman-ms pushed a commit that referenced this pull request Jan 10, 2024
…add version preview/2023-10-02-preview (#26610)

* Add virtualMachines profile and status to AP properties (#26386)
* Add flexible virtualMachines profile and status to AP properties
* feat: add init taints to swagger spec for agent pool properties (#26430)
* AKS Operations Status Result (#26456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.