Spark Job mfe contract to 2024-04-01 GA version #27930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Compared specs (v0.10.5) | new version | base version |
|---|---|---|
| mfe.json | 2024-04-01(ba1de6a) | 2023-10-01(main) |
| mfe.json | 2024-04-01(ba1de6a) | 2024-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L12:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L57:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups/{groupId}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L105:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/marketplaceSubscriptions' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L2945:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/marketplaceSubscriptions/{name}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L2996:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models/{modelName}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L3853:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9344:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9430:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9727:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9779:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9844:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints/{endpointName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9938:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10268:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10362:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10690:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10749:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11298:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11356:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/exportLabels' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11542:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/pause' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11626:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/resume' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11678:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/models/{name}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L12339:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/schedules/{name}/trigger' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L13944:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14008:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14059:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14356:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14409:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/regenerateKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14462:5 |
|
| The new version is missing a definition that was found in the old version. Was 'AuthMode' removed or renamed? New: Microsoft.MachineLearningServices/stable/2024-04-01/mfe.json#L11145:3 Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14548:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutoDeleteCondition' removed or renamed? New: Microsoft.MachineLearningServices/stable/2024-04-01/mfe.json#L11145:3 Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14548:3 |
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Feb 26, 2024
This was referenced Feb 26, 2024
AzureRestAPISpecReview
added
ARMReview
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ms-zhenhua
reviewed
Feb 28, 2024
| "default": { | ||
| "description": "Error", | ||
| "schema": { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Why change the order? Normally, default should always be at the last one
There was a problem hiding this comment.
This is auto generated code and 22k+ lines .. I have not made this change .. I am not sure if we can merge as generated or you want me to rearrange order.
There was a problem hiding this comment.
As per our team TSG we should not change this file manually and this file should be auto generated. Some how autogeneration is not in right order. I already notified owning team. This should not impact in actual behavior, only order change. Please review it. Thanks, VJ
There was a problem hiding this comment.
thousands of lines of order changes w/o content changes will seriously slow down the review speed. Please update the PR to only show changed content.
There was a problem hiding this comment.
This is autogenerated code so I cannot change it manually as per policy there is work item to fix auto gen tool and avoid order change. Order change should not impact on any functionality.
ms-zhenhua
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
vaibhj
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-zhenhua
added
ARMChangesRequested
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
openapi-pipeline-app
bot
added
Purview
Recovery Services Backup
Recovery Services Site-Recovery
RecoveryServices
Redis Cache
Relay
Scheduler
Search
Service Bus
Service Fabric
Service Map
SQL
Storage
|
Hi @vaibhj and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to arcboard@microsoft.com. |
raosuhas
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
Just adding the tag to remove it from the review queue. Please abandon this PR once your other PR is signed off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.