-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy App Gateway Examples from 2018-01-01 to 2018-02-01 #2822
Conversation
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
@@ -40,6 +40,11 @@ | |||
"ApplicationGateways" | |||
], | |||
"operationId": "ApplicationGateways_Delete", | |||
"x-ms-examples": { | |||
"Delete ApplicationGateway": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Spaces are not recommended as json keys,
consider naming this as Delete ApplicationGateway
This applies to all examples here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new change? Every example name we have across all our specs have spaces in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a new change, but moving forward it would be nice :) won't block on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks. I'll look at doing this in April or May version. Thanks!
@lmazuel if you can check on that soon I can make any corrections right away. Thanks. |
Looks like an issue with AutoRest itself. @olydis will fix the CI soon. |
ok, understood. Am I able to submit a PR into the 2018-04-01 branch without triggering this error? I want to get these examples into that branch before its gets pushed as a new version. thanks. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger