-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy App Gateway Examples from 2018-01-01 to 2018-02-01 #2822
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
be105bf
Copy App Gateway Examples from 2018-01-01 to 2018-02-01
markjbrown 623efb8
Fixed version
markjbrown c87db16
Fixed version
markjbrown 8faa834
Fixed version
markjbrown 4e655e2
Fixed version
markjbrown 41f9a92
Fixed version
markjbrown fdc4451
Update ApplicationGatewayList.json
markjbrown 6dc5ae2
Fixed version
markjbrown d51d91a
Fixed version
markjbrown 98d4082
Fixed version
markjbrown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
...crosoft.Network/stable/2018-02-01/examples/ApplicationGatewayAvailableWafRuleSetsGet.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-02-01", | ||
| "subscriptionId": "subid" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "OWASP_3.0", | ||
| "id": "/subscriptions//resourceGroups//providers/Microsoft.Network/applicationGatewayAvailableWafRuleSets/", | ||
| "type": "Microsoft.Network/applicationGatewayAvailableWafRuleSets", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "ruleSetType": "OWASP", | ||
| "ruleSetVersion": "3.0", | ||
| "ruleGroups": [ | ||
| { | ||
| "ruleGroupName": "General", | ||
| "description": "", | ||
| "rules": [ | ||
| { | ||
| "ruleId": 200004, | ||
| "description": "Possible Multipart Unmatched Boundary." | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
57 changes: 57 additions & 0 deletions
57
...ager/Microsoft.Network/stable/2018-02-01/examples/ApplicationGatewayBackendHealthGet.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-02-01", | ||
| "subscriptionId": "subid", | ||
| "resourceGroupName": "appgw", | ||
| "applicationGatewayName": "appgw" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "backendAddressPools": [ | ||
| { | ||
| "backendAddressPool": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/applicationGateways/appgw/backendaddressPools/MFAnalyticsPool" | ||
| }, | ||
| "backendHttpSettingsCollection": [ | ||
| { | ||
| "backendHttpSettings": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/applicationGateways/appgw/backendHttpSettingsCollection/MFPoolSettings" | ||
| }, | ||
| "servers": [ | ||
| { | ||
| "address": "10.220.1.8", | ||
| "health": "Up" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "backendAddressPool": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/applicationGateways/appgw/backendaddressPools/MFPool" | ||
| }, | ||
| "backendHttpSettingsCollection": [ | ||
| { | ||
| "backendHttpSettings": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/applicationGateways/appgw/backendHttpSettingsCollection/MFPoolSettings" | ||
| }, | ||
| "servers": [ | ||
| { | ||
| "address": "10.220.1.4", | ||
| "health": "Up" | ||
| }, | ||
| { | ||
| "address": "10.220.1.5", | ||
| "health": "Up" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "202": {} | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Spaces are not recommended as json keys,
consider naming this as
Delete ApplicationGatewayThis applies to all examples here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new change? Every example name we have across all our specs have spaces in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a new change, but moving forward it would be nice :) won't block on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks. I'll look at doing this in April or May version. Thanks!