Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure SignalR - Adding new api-version 2024-01-01-preview #28259

Merged
merged 4 commits into from
Mar 25, 2024

Trivial change : adjust readonly position

bca9ac1
Select commit
Loading
Failed to load commit list.
Merged

Azure SignalR - Adding new api-version 2024-01-01-preview #28259

Trivial change : adjust readonly position
bca9ac1
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff succeeded Mar 20, 2024 in 6m 15s

~[NotRequired_Staging] Swagger LintDiff succeeded

ppe/LintDiff
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-2024-01-01-preview package-2024-01-01-preview(bca9ac1) default(main)
package-2024-01-01-preview package-2024-01-01-preview(bca9ac1) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ AllProxyResourcesShouldHaveDelete The resource SharedPrivateLinkResource does not have a corresponding delete operation.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L3060		 RPC-Delete-V1-05
⚠️ NonApplicationJsonType Only content-type 'application/json' is supported by ARM
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1709
⚠️ AllProxyResourcesShouldHaveDelete The resource SharedPrivateLinkResource does not have a corresponding delete operation.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L3373		 RPC-Delete-V1-05
⚠️ NonApplicationJsonType Only content-type 'application/json' is supported by ARM
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1932


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L3398
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L3375
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L3299
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L3169
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L2085
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L2060
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L2033
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1823
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1775
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1547
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1505
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:resourceStopped.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1505
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:regionEndpointEnabled.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1505
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1505
❌ PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1196
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1123
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1096
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L1041
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L877
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L846
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L779
❌ ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L779
❌ ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L508
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L410
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:resourceStopped.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L410
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:regionEndpointEnabled.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L410
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:publicNetworkAccess.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L410
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:connectionTimeoutInSeconds.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L410
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:enabled.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L410
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L410
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L372
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L348
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L328
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L283
❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json#L28
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L2308
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L2283
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L2256
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L2046
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1998
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1770
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1728
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:resourceStopped.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1728
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:regionEndpointEnabled.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1728
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1728
❌ PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1419
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1346
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1319
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1264
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json#L1100
View more details on openapi-pipeline-app