Bring the missing change caused by [Update 20240401 mfe.json schema for adding Datacollector] #28314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.5) | new version | base version |
|---|---|---|
| mfe.json | 2024-04-01(0b09dca) | 2023-10-01(main) |
| mfe.json | 2024-04-01(0b09dca) | 2024-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L12:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L57:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups/{groupId}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L105:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/marketplaceSubscriptions' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L2945:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/marketplaceSubscriptions/{name}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L2996:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models/{modelName}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L3853:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9344:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9430:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9727:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9779:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9844:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints/{endpointName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L9938:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10268:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10362:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10690:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L10749:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11298:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11356:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/exportLabels' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11542:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/pause' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11626:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/resume' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L11678:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/models/{name}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L12339:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/schedules/{name}/trigger' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L13944:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14008:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14059:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14356:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14409:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/regenerateKeys' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14462:5 |
|
| The new version is missing a definition that was found in the old version. Was 'AuthMode' removed or renamed? New: Microsoft.MachineLearningServices/stable/2024-04-01/mfe.json#L11145:3 Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14548:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutoDeleteCondition' removed or renamed? New: Microsoft.MachineLearningServices/stable/2024-04-01/mfe.json#L11145:3 Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/mfe.json#L14548:3 |
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Mar 19, 2024
hujiulin
changed the title
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
ms-zhenhua
reviewed
Mar 20, 2024
| "type": "string", | ||
| "x-nullable": true | ||
| }, | ||
| "settings": { |
There was a problem hiding this comment.
Dictionaries are not allowed in Azure unless they satisfy the following criteria. Otherwise, it should be defined as a model or model array.
- The schema is not owned by your service
- The keys of the dictionary are not validated by your service
- The property represents an opaque property that is not interpreted by your service and is purely a pass thru.
There was a problem hiding this comment.
I just bring the changes of this PR: 913cc60 back.
| "modelAsString": true, | ||
| "values": [ | ||
| { | ||
| "value": "Model" |
There was a problem hiding this comment.
where is the model with "x-ms-discriminator-value": "Model" defined?
There was a problem hiding this comment.
I just bring the changes of this PR: 913cc60 back.
There was a problem hiding this comment.
ms-zhenhua This emergency PR is a fixing an error that was introduced by the following PR that was merged 2 days ago.
- Update 20240401 mfe.json schema for adding Datacollector #28262
If you look at the changes in that PR around lines 11000-12000, you can see that it deletes several definitions related to batch deployments. This should never have been merged, since it is an accidental revert/bash of this PR from last week: - 40a0b44
In conclusion, please ignore standard complains, as this PR is merely re-adding changes that have ALREADY been approved, and were accidentally deleted due to a falsely-approved PR.
ms-zhenhua
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
ms-zhenhua
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-zhenhua
added
Approved-LintDiff
ARMSignedOff
|
approved the lintdiff as this PR is a revert for a mistakenly deleting: #28314 (comment) |
|
/pr RequestMerge |
ms-zhenhua
approved these changes
Mar 21, 2024
ms-zhenhua
merged commit 8ba0227
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01
27 of 28 checks passed
ramoka178
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Adds base for updating Microsoft.MachineLearningServices from version stable/2023-10-01 to version 2024-04-01 * Updates readme * Updates API version in new specs and examples * Add pipeline deployments to mfe.json (#28115) * Add pipeline deployments to mfe.json * Fix diff --------- Co-authored-by: Sunjoli Aggarwal <sunaggar@microsoft.com> * [MFE] Adding OneLake DatastoreType to 2024-04-01 stable (#28092) * Updating MFE 2024-04-01 swagger to include OneLake DatastoreType. Swagger generated from 2024-04-01 MFE REST API contracts. * Ran prettier to format whitespace for the generated mfe.json file. * SparkJob MFE contract changes for 20240401 API version (#28252) * SparkJob MFE contract changes for 20240401 API version * regex * codeid pattern * Suppression request for Swagger LintDiff on mfe.json * Format tag for other AMR ID property * Update 20240401 mfe.json schema for adding Datacollector (#28262) * Add NotificationSetting to JobBase in 2024-04-01 (#28146) * add notification setting to job base in 2024-04-01 * run prettier --------- Co-authored-by: Vanessa Arndorfer <vaarndor@microsoft.com> * Update 20240401 mfe.json schema for adding Datacollector (#28314) Co-authored-by: Jiulin Hu <jiuhu@microsoft.com> * [ML]WRP 2024-04-01 swagger changes (#28312) * Add swagger change for 2024-04-01 * Add examples * Updated operation id * Update Async status * fix rai policy schema * Update missing fix * Add listsecret api * add missing example * remove additional property check for connection response * removed unneeded properties * Update * Fix errors and update property * missing fix * Fix metadata format and add suppression * Update suppression * fix suppression * Update block list related API and example run prettier * Fixing typo and update op id * update supression * Fixed suppression * add sdk-suppressions.yaml * Update PUT status code * Fix --------- Co-authored-by: Alancere <804873052@qq.com> * Fix JS SDK Breaking Change Error for April GA (#28549) * Fix JS SDK Breaking Change Error * Fix_Spacing * Correction * Update specification/machinelearningservices/resource-manager/readme.typescript.md * Update specification/machinelearningservices/resource-manager/readme.typescript.md --------- Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com> * Update sdk-suppressions.yaml (#28558) * Add support for workspace list connection models. (#28513) * [ML]Update the location of connection ids (#28581) * Update the location of connection ids * update examples * Remove connection related APIs (#28660) * Adding AIServices connection category * remove bad line * Update sdk-suppressions.yaml --------- Co-authored-by: Sunjoli Aggarwal <sunjoli.aggarwal@gmail.com> Co-authored-by: Sunjoli Aggarwal <sunaggar@microsoft.com> Co-authored-by: Young Park <youngpark@cs.stanford.edu> Co-authored-by: vaibhj <vaibhj@microsoft.com> Co-authored-by: zemaMSFT <134677286+zemaMSFT@users.noreply.github.com> Co-authored-by: Vanessa Arndorfer <vanessa.arndorfer@gmail.com> Co-authored-by: Vanessa Arndorfer <vaarndor@microsoft.com> Co-authored-by: CodeVillager <tohujiulin@126.com> Co-authored-by: Jiulin Hu <jiuhu@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: ragovada <142325886+ragovada@users.noreply.github.com> Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com> Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.