-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for workspace list connection models. #28513
Merged
rkmanda
merged 1 commit into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01
from
ZhidaLiu:user/zhili/wrp-2024-04-01-addListConnection
Apr 2, 2024
Merged
Add support for workspace list connection models. #28513
rkmanda
merged 1 commit into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01
from
ZhidaLiu:user/zhili/wrp-2024-04-01-addListConnection
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Mar 29, 2024
/pr RequestMerge |
rkmanda
approved these changes
Apr 2, 2024
6a3b700
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01
25 of 27 checks passed
ramoka178
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Adds base for updating Microsoft.MachineLearningServices from version stable/2023-10-01 to version 2024-04-01 * Updates readme * Updates API version in new specs and examples * Add pipeline deployments to mfe.json (#28115) * Add pipeline deployments to mfe.json * Fix diff --------- Co-authored-by: Sunjoli Aggarwal <sunaggar@microsoft.com> * [MFE] Adding OneLake DatastoreType to 2024-04-01 stable (#28092) * Updating MFE 2024-04-01 swagger to include OneLake DatastoreType. Swagger generated from 2024-04-01 MFE REST API contracts. * Ran prettier to format whitespace for the generated mfe.json file. * SparkJob MFE contract changes for 20240401 API version (#28252) * SparkJob MFE contract changes for 20240401 API version * regex * codeid pattern * Suppression request for Swagger LintDiff on mfe.json * Format tag for other AMR ID property * Update 20240401 mfe.json schema for adding Datacollector (#28262) * Add NotificationSetting to JobBase in 2024-04-01 (#28146) * add notification setting to job base in 2024-04-01 * run prettier --------- Co-authored-by: Vanessa Arndorfer <vaarndor@microsoft.com> * Update 20240401 mfe.json schema for adding Datacollector (#28314) Co-authored-by: Jiulin Hu <jiuhu@microsoft.com> * [ML]WRP 2024-04-01 swagger changes (#28312) * Add swagger change for 2024-04-01 * Add examples * Updated operation id * Update Async status * fix rai policy schema * Update missing fix * Add listsecret api * add missing example * remove additional property check for connection response * removed unneeded properties * Update * Fix errors and update property * missing fix * Fix metadata format and add suppression * Update suppression * fix suppression * Update block list related API and example run prettier * Fixing typo and update op id * update supression * Fixed suppression * add sdk-suppressions.yaml * Update PUT status code * Fix --------- Co-authored-by: Alancere <804873052@qq.com> * Fix JS SDK Breaking Change Error for April GA (#28549) * Fix JS SDK Breaking Change Error * Fix_Spacing * Correction * Update specification/machinelearningservices/resource-manager/readme.typescript.md * Update specification/machinelearningservices/resource-manager/readme.typescript.md --------- Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com> * Update sdk-suppressions.yaml (#28558) * Add support for workspace list connection models. (#28513) * [ML]Update the location of connection ids (#28581) * Update the location of connection ids * update examples * Remove connection related APIs (#28660) * Adding AIServices connection category * remove bad line * Update sdk-suppressions.yaml --------- Co-authored-by: Sunjoli Aggarwal <sunjoli.aggarwal@gmail.com> Co-authored-by: Sunjoli Aggarwal <sunaggar@microsoft.com> Co-authored-by: Young Park <youngpark@cs.stanford.edu> Co-authored-by: vaibhj <vaibhj@microsoft.com> Co-authored-by: zemaMSFT <134677286+zemaMSFT@users.noreply.github.com> Co-authored-by: Vanessa Arndorfer <vanessa.arndorfer@gmail.com> Co-authored-by: Vanessa Arndorfer <vaarndor@microsoft.com> Co-authored-by: CodeVillager <tohujiulin@126.com> Co-authored-by: Jiulin Hu <jiuhu@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: ragovada <142325886+ragovada@users.noreply.github.com> Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com> Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-JavaScript-Sdk
BreakingChange-JavaScript-Sdk-Approved
BreakingChange-Python-Sdk
BreakingChange-Python-Sdk-Approved
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.