Update `securityPostureReference` in VMScaleSet API #28891

martinezdylan · 2024-04-29T16:24:47Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-04-29T16:24:51Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-04-29T16:24:51Z

Swagger Validation Report

️❌BreakingChange: 14 Errors, 1 Warnings failed [Detail]

Compared specs (v0.10.9)	new version	base version
virtualMachineScaleSet.json	2024-03-01(8434bfb)	2024-03-01(main)

Rule	Message
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6347:11 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6343:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6340:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6336:7
`❌` 1026 - TypeChanged	The new version has a different type 'string' than the previous one ''. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6347:11 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6343:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'properties' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'location' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'id' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'name' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'type' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'tags' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'id' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5182:9 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5182:9
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'id' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6338:5 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6334:5
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'isOverridable' in response that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6340:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6336:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'securityPostureReference' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5196:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5196:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'isOverridable' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6340:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6336:7
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6347:11 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6343:11

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-2024-03-01	package-2024-03-01(8434bfb)	package-2024-03-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6352
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6376

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L297
`❌` LroPatch202	The async patch operation should return 202. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L350
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L374
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L413
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L439
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L506
`❌` ParametersInPost	hibernate is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L512
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L554
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L576
`❌` ParametersInPost	forceDeletion is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L582
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L624
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L646
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L677
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L822
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:secretUrl. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L854
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:sourceVault. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L854
`❌` LroPatch202	The async patch operation should return 202. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L866
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L896
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L935
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L964
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1235
`❌` ParametersInPost	skipShutdown is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1241
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1284
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1306
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1347
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1369
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1410
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1432
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1494
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1535

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2024-03-01

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-29T16:24:52Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️⚠️ azure-sdk-for-net-track2 warning [Detail]

⚠️Warning in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact

️✔️Azure.ResourceManager.Compute [Preview SDK Changes] Breaking Change Detected

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Compute/Debug/netstandard2.0/Azure.ResourceManager.Compute.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0]

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-compute [Preview SDK Changes] Breaking Change Detected

azure-mgmt-compute-31.0.0.zip
azure_mgmt_compute-31.0.0-py3-none-any.whl

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model SecurityPostureReference has a new parameter is_overridable
info	[Changelog]   - Model VirtualMachineScaleSetUpdateVMProfile has a new parameter security_posture_reference
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Parameter id of model SecurityPostureReference is now required

Present SDK breaking changes suppressions
Parameter id of model SecurityPostureReference is now required

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-compute-generated-1.0.0-beta.1.jar

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [Preview SDK Changes] Breaking Change Detected

azure-arm-compute-22.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface SecurityPostureReferenceUpdate
info	[Changelog]   - Interface SecurityPostureReference has a new optional parameter isOverridable
info	[Changelog]   - Interface VirtualMachineScaleSetUpdateVMProfile has a new optional parameter securityPostureReference
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Parameter id of interface SecurityPostureReference is now required
info	[Changelog]   - Type of parameter excludeExtensions of interface SecurityPostureReference is changed from VirtualMachineExtension[] to string[]

Present SDK breaking changes suppressions
Parameter id of interface SecurityPostureReference is now required
Type of parameter excludeExtensions of interface SecurityPostureReference is changed from VirtualMachineExtension[] to string[]

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `SecurityPostureReferenceUpdate`
info	[Changelog] - New field `IsOverridable` in struct `SecurityPostureReference`
info	[Changelog] - New field `SecurityPostureReference` in struct `VirtualMachineScaleSetUpdateVMProfile`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 4 additive change(s).

Present SDK breaking changes suppressions
Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string`

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️❌ azure-resource-manager-schemas failed [Detail]

❌Code Generator Failed in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

️❌ azure-powershell failed [Detail]

❌Code Generator Failed in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
error	Script return with result [failed] code [2] signal [null] cwd [azure-powershell]: sh ./tools/SwaggerCI/init.sh
warn	File azure-powershell_tmp/initOutput.json not found to read
error	Fatal error: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'
ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'
error	Fatal error: Error: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'    at Object.openSync (node:fs:596:3)    at Object.writeFileSync (node:fs:2322:35)    at writeTmpJsonFile (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/fsUtils.js:125:18)    at workflowCallGenerateScript (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:582:36)    at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:235:46)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)    at async workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:107:9)    at async sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:217:13)    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-29T16:24:53Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/compute/armcompute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-compute-generated	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-compute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger	Microsoft.Compute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2024-04-29T16:35:23Z

This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Learn more at aka.ms/azsdk/pr-arm-review.

martinezdylan · 2024-04-29T16:59:12Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR has at least one breaking change (label: BreakingChangeReviewRequired). See the PR description for help.

❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Can we skip BreakingChange review as this feature is not currently used by any customers? Original feature addition was placed in public repo however this property is consumed by Security Posture which is in pursuit of Private Preview. The securityPostureReference will be ignored by CRP for VMSS provisioning as it's behind AFEC and Regional Flags.

raych1 · 2024-05-30T07:17:08Z

@martinezdylan , the type change of excludeExtensions property will cause breaking change to SDK. Are you saying security posture feature is in private preview and because it is behind feature flag, it doesn't have real customer impact? Is this a service behavior change?

martinezdylan · 2024-05-30T19:36:31Z

@martinezdylan , the type change of excludeExtensions property will cause breaking change to SDK. Are you saying security posture feature is in private preview and because it is behind feature flag, it doesn't have real customer impact? Is this a service behavior change?

Hi @raych1 , understood & exactly absolutely no customers have been onboarded to the service as we haven't even reached private preview as of yet. Zero customer impact. Much better CX whenever we do release.

grizzlytheodore · 2024-06-03T20:53:24Z

who can we ping about go sdk breaking change sign off?

martinezdylan · 2024-06-05T15:28:26Z

/pr RequestMerge

* update securityPostureRef properties in VMScaleSet spec * add securityPostureReference to UpdateVMProfile definition and fix min version * add prettier changes * remove unsupported 'major.*' from spec * add optional fields in security posture example * add required fields * correct minimum api version * add prettier fixes * remove extensionsSettings property * create new Update model for security posture reference & update * fix validation issue * Create sdk-suppressions.yaml * add azure-sdk-for-go suppression * Update sdk-suppressions.yaml --------- Co-authored-by: Dylan Martinez <dymartinez@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

@secret

* Update package.json and scripts * Add typespec-azure-portal-core * Fix some deprecations from valueof PR (#29126) * [apicenter] Regen swagger to add "title" properties * [cognitiveservices] Use TypeSpec array (#[]) instead of tuple ([]) (#29213) * fix * Suppress failing rules * Fix shouldn't have `Content-Type` header * Pin typespec versioning to 0.57.0-dev.6 * Switch back to next tag for versioning library * Add new networking code owner (#29281) * Sherylueen appcomplianceautomation microsoft.app compliance automation 2024 06 27 (#28981) * Adds base for updating Microsoft.AppComplianceAutomation from version preview/2022-11-16-preview to version 2024-06-27 * Updates readme * Updates API version in new specs and examples * add new stable version for Microsoft.AppComplianceAutomation * remove the useless example file * fix spell check * remove query in get evidence api * remove the singleton annotation * fix compile error * fix compile error of v56 * fix compile error * fix all compile error and make the swagger align with before * tsp prettier * change scoping name * upgrade the commontypes from v3 to v5 * change commonTypes version to v3 * add service-dir * format tspconfig.yaml * modify tspconfig.yaml * remove custom operations * modify re pattern of snapshot name * make the resource x-ms-client-name properties * format typespec * remove suffix of snapshot * use requestBody replace parameters * Revert "use requestBody replace parameters" This reverts commit e4dd975. * tsp format * remove dotnet from tspconfig.yaml and add azure-sdk-for-net-track2 in readme * add sdk-suppressions.yaml * Update tspconfig.yaml * Update tspconfig.yaml * rename operationid * rename getScopingQuestions and move model reportBaseProperties to alias --------- Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> * Microsoft.ScVmm TypeSpec onboarding (#26644) * Init tsp for Microsoft.ScVmm * Some changes towards passing tsv * Updates to fix lint errors, remove unused types, regenerate examples, etc. * Created shareable 'force' param * Figured out the incantation to rename a file case-sensitively * Restored string bool enums. * Removed all examples * Regenerate examples * Updated ARM ID properties. Added script to sort output to compare with sorted old swagger * Additional changes. * Removed unused XXUpdate models, Added @secret for password, * Fixed #8, #6, #5 * Fixed #2 * Update swagger to be in sync with previous fixes. * Workaround for CloudCapacity readonly * Additional fixes. * fix ModelValidation * update void * VM Instance Update Properties changes * spell check and prettier validation fix * fix for identifier bug * workaround for Azure/typespec-azure#449 * format * spell and prettier check improvements * use encodedName replace projectdName * Add summary annotations * summary * update kind and void * lro azure-async-operation * fix * tsp compilation warning * TypeSpec Validation fix * Update tspconfig.yaml * config change * Removed Read Only Property from Examples to fix Swagger ModelValidation * Revert Boolean to Enum with type Union in TypeSpec * specs-pr repo PR review changes to specs repo * Remove sorted json file used for comparison * Fix TypeSpec PR pipeline failure * make extendedLocation for VM Instance read and create * typespec validation fix --------- Co-authored-by: Will Temple <will@wtemple.net> Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: Harshit Surana <hsurana@microsoft.com> * Imagebuilder API Release 2024-02-01 (#28896) * Copy files from stable/2023-07-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-02-01 Updated the API version from stable/2023-07-01 to stable/2024-02-01. * Added tag for 2024-02-01 in readme file * copying over 2024-02-01 changes from ADO * Revert "copying over 2024-02-01 changes from ADO" This reverts commit aa54d74. * adding changes from ado * adding autorun as custom word * adding autorun to custom-words.txt * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error * changing type from string back to object * changing type from string back to object * Revert "changing type from string back to object" This reverts commit b0b5122. revert commit * Revert "fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error" This reverts commit 0e52ddf. * referencing examples file * writing suppression for lintdiff * removing userassignedidentity * fixing bad version mismatch * fixing suppression * prettier changes * fixing where syntax * fixing where suppress 2 * where suppress 3 * where supress 4 * where suppress 5 * suppressing entire file * Update readme.md to show up documentation for preview version (#29165) * Update readme.python.md (#29309) * Update readme.python.md * Update readme.md --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update readme.md (#29313) * Add info about `SDK azure-sdk-for-*` checks and `SDK azure-powershell` to `ci-fix` doc; Clean up markdownlint rules and `ci-fix` doc. (#29311) * Update ci-fix.md: clarify that `SDK azure-powershell` is owned by `Azure.Core`. (#29318) * Update ci-fix.md * Update ci-fix.md * Update ci-fix.md * RouteMatrix 2024-06-01-preview (#29153) * first commit * fix * Add operationType * rename to pointType * fix * update * Update example * update * update description for default value * update description * Remove axleCount for RouteMatrix * Update vehicleSpec * update description * Update description * remove async result * Revert "remove async result" This reverts commit b7b2728. * Remove Summary * follow azure's convention * Remove Accept-Language for RouteMatrix * Update retention period to 24 hours * Add createdDateTime * Add suppressions * Update description --------- Co-authored-by: Will Huang <huangwill@microsoft.com> Co-authored-by: Joel Hendrix <jhendrix@microsoft.com> * [OAI-Assistant] Added Missing annotation and delete unnecessary annotation (#29297) * fixed the error * npx tsp compile updates --------- Co-authored-by: Travis Wilson <travisw@microsoft.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> * [OpenAI] [Inference] TSP definition updates for `v2024_05_01_preview` service release (#29182) * Azure OpenAI: 2024-04-01-preview updates * add audio formats * post-merge fix incl. tool update for enum conversion to union * minor: spellcheck fix * refine duration encoding for word start/end * enable serialization into azure json and rename customization class name * Added new customBlockList filter and fields to OYD * Adding changes to authentication for Vector Search * Adjusted docs for OYD vector search auth models * Added missing field and retrieved documents * Examples added * corrected examples api-versions in json * Reformat * Recompile after reformat * PR comments: wrong plural and type precision * Revert added tab to service spec Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * Added readme entry for generated openAPI doc * Trying to improve folder structure * Removed moved and renamed generated.json files * Reverted last 3 commits * Added entry for generated.json swagger in the readme * Changed enum to nonExpandable * Ran formatter --------- Co-authored-by: Travis Wilson <travisw@microsoft.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Shawn Fang <shafang@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * Add v3.2 for Speech to text (3.2p2 as base) (#28664) * Add v3.2 for Speech to text (3.2p2 as base) * Update swagger with new changes and updated version number * Update readme.md with new version * Added evaluation token errors * Revert ttl changes for transcriptions * Finalized api changes for GA * Try fix avocado error * Add new api-version 2024-02-01-preview to main (#29105) * Add 2024-02-01-preview to main * fix typespec errors * remove operations.json * fix linters * delete unusued file * edit readme * remove suppressions * Update specification/azurestackhci/Operations.Management/tspconfig.yaml Co-authored-by: Mike Harder <mharder@microsoft.com> * Update specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml Co-authored-by: Mike Harder <mharder@microsoft.com> * ID to id * remove unnecessary suppress * fix examples * copy private folder changes --------- Co-authored-by: Mike Harder <mharder@microsoft.com> * Storage STG 94 (#28327) * added swagger (#28199) * [STG94] Updated STG94 Files Readme (#28201) * added swagger * updated readme * small fix * added new blob swagger (#28245) * added blob readme (#28246) * Ran prettier on the 2024-08-04 files swagger file (#28358) * Added AuthenticationErrorDetail to StorageError (#28360) * NFS Share Snapshot (#28362) * Added GetAccountInfo() API to Container and Blob level (#28297) * Storage Error Codes for Copies (#28359) * Revert "Storage Error Codes for Copies (#28359)" This reverts commit 8b14ba4. --------- Co-authored-by: Tamer Sherif <69483382+tasherif-msft@users.noreply.github.com> * Storage Task Assignment Swagger Updates (#29050) * SDK team improvements * Report APIs contain filtering * PR comment add more examples * Fix example path * Fix duplicate schema issue --------- Co-authored-by: Tricia Rosario <trrosari@microsoft.com> * Update virtualMachine.json (#29112) remove "feature in preview" Co-authored-by: Theodore Chang <thchan@microsoft.com> * Merge release api management 2023 09 01 preview - Active (#29184) * Adds base for updating Microsoft.ApiManagement from version preview/2023-05-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples * feat(apim): Introduce gateway resource (#27757) * WIP * Update sample * WIP * Add GatewayNameParameter * Clean up * Update sample * Add another sample * Add sample for delete gateway * Remove endpoints * Fix typo * Add list sample * Clean up Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Add disclaimer Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Make it pretty 💄 Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Refer to new file Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Add missing ApiManagementGatewayListResult Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Update sample reference Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Remove ApiManagementGatewayIdentity + List by operation Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Add more sample Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Latest version of common types Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Remove 200 for delete Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Formatting and re-order Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Align with spec Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Align sample with spec Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Error response from common types Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Rename SKU name * Have seperate SKU for patch to not make it mandatory * Remove empty required * Improve note * Rename schema * Remove unused type * sku.capacity should not be required --------- Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Add loggers, diagnostics, certificates and backends to workspace (#27262) * Add loggers to workspaces * Add diagnostics to workspace * Add certificates to workspace * Add backends to workspaces * Change DiagnosticContract to DiagnosticContractProperties in patch * Revert back DiagnosticContractProperties to DiagnosticContract * Fix CI and add files to readme * Fix example * remove reconnect endpoint * Add suppressions * Try different suppression where * Try different suppression * Try other suppression * another test * finally working suppression * remove unwanted line * remove secret examples (#28409) * Modify CircuitBreaker and BackendPool Contract (#28397) * md cb contract * modify pool contract * correct the limits --------- Co-authored-by: Samir Solanki <samirsolanki@outlook.com> * Common Error Response (#28408) * add operation statuses resource (#28591) * add operation statuses resource * fix api-version * Add locations/operationsResults endpoint for DELETE workflow (#28808) * add operation results * fix spec * operationresults * fix file name * feat(Workspace): Add new SkuType for Workspace (#28903) * new skutype * virtualNetworkType * remove default from patch * List skus API * add model for sku * caps enums * feat)Gateway): Adding gateway config resource (#28478) * added gateway config resource * removing Head gateway Config call * updates * resolving errors * trying to resolve more model validations * resolving some model validations * resolving model validations * resoloving delete example errors * Swagger Prettier * prettier * updating so patch has same response as get and put * removing path for gateway config * addressing comment * addressing comments * nit * path updatess * updating as per comments * Adding workspaceLinks * resolving some of the errors * resolved some errors * resolving some of the errors * resolving some more errors * npx prettier * addressing comments * updated based on comments * lint updates * nit updates --------- Co-authored-by: Samir Solanki <samirsolanki@outlook.com> * Fix generation errors (#29207) * fix(apim): Remove duplicate ErrorResponse schema due to move to common schema * Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway * Revert "Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway" This reverts commit 8d4753d. * Remove ApiManagement Prefix for GatewayConfigConnections * Revert "Remove ApiManagement Prefix for GatewayConfigConnections" This reverts commit 3e8197f. * Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway * Create sdk-suppressions.yaml --------- Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Rafał Mielowski <rmielowski@microsoft.com> Co-authored-by: Mahsa Sadi <mahsasadi@microsoft.com> Co-authored-by: Vidisha Shah <102258037+vidishamsft@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Fixed typo in documentation (#29341) * Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) * Rename enum to functionsDeploymentStorageType * Update enum name to camel case * Update enum names to camel case * Update `securityPostureReference` in VMScaleSet API (#28891) * update securityPostureRef properties in VMScaleSet spec * add securityPostureReference to UpdateVMProfile definition and fix min version * add prettier changes * remove unsupported 'major.*' from spec * add optional fields in security posture example * add required fields * correct minimum api version * add prettier fixes * remove extensionsSettings property * create new Update model for security posture reference & update * fix validation issue * Create sdk-suppressions.yaml * add azure-sdk-for-go suppression * Update sdk-suppressions.yaml --------- Co-authored-by: Dylan Martinez <dymartinez@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com> * [Microsoft.AzureStackHCI] Add 2024-04-01 for StackHCI (#29110) * Add 2024-04-01 for StackHCI * add missing properties * add log collection job type * changes in sdk suppressions * sdk suppression changes * Enable stream-stype serialization for Java Communication Job Router (#29328) * Azure Map Rendering 20240401 (#27950) * Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01 * Updates readme * Updates API version in new specs and examples * update static map API doc * small change on static map doc * update tilesetId section * add static map supported tilesetid and trafficLayer * update range table and static image example * fix typo * add additional static image example * error fix * run prettier on static image example json * set tilesetId as optional * update max/min latitude/longitude table * update Accept header for static image API * error fix * add explanation for Accept header * typo * add parameter limitation * improve wording * add path and pin parameter type * fix tables * improve on example * typo fix * run prettier * wording fix * map attribution description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * state tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map tileset description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright caption description change Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright bounding description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * weather radar tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * weather infrared tiles description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright world description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * remove pricing tiers applies * Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01 * Updates readme * Updates API version in new specs and examples * update static map API doc * small change on static map doc * update tilesetId section * add static map supported tilesetid and trafficLayer * update range table and static image example * fix typo * add additional static image example * error fix * run prettier on static image example json * set tilesetId as optional * update max/min latitude/longitude table * update Accept header for static image API * error fix * add explanation for Accept header * typo * add parameter limitation * improve wording * add path and pin parameter type * fix tables * improve on example * typo fix * run prettier * wording fix * map attribution description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * state tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map tileset description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright caption description change Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright bounding description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * weather radar tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * weather infrared tiles description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright tile description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * map copyright world description update Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * remove pricing tiers applies * reduce get copyright example length * add summary for render 20240401 * remove summary from static image * remove please from language and view * add package-2024-04-01 to readme * revert back common change * revert changes in maps readme * \n fix Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * typo fix Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * typo fix for map copyright caption Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * typo fix for statetile Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> * typo fix for map copyright world Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> --------- Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> Co-authored-by: Joel Hendrix <jhendrix@microsoft.com> * Update directory-structure.md: clarify service, service group, uniform versioning. (#28929) * [ACS][Communication][Chat] 2024-06-05-preview public preview API spec (#28875) * Update for autorest lro support * Format * Fix issues with oracle spec from main * Update format * Update for latest dev version * Fixing typespec-next for June 2024 release (#29427) * green typespec-next * Fix DeviceRegistry * upgrade monitor to v4. Taking arm-id and subId uuid SDK breaking change. This should get rid of ModelValidation error * Update package.json --------- Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> Co-authored-by: Joanna-Yang-Art <137839107+Joanna-Yang-Art@users.noreply.github.com> Co-authored-by: Sherylueen <warmflyingheart@gmail.com> Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: Will Temple <will@wtemple.net> Co-authored-by: Harshit Surana <hsurana@microsoft.com> Co-authored-by: zdelacerda-microsoft <90284189+zdelacerda-microsoft@users.noreply.github.com> Co-authored-by: raghumunukutla <55466801+raghumunukutla@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> Co-authored-by: will <koyasu221b@gmail.com> Co-authored-by: Will Huang <huangwill@microsoft.com> Co-authored-by: Joel Hendrix <jhendrix@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: Travis Wilson <travisw@microsoft.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Shawn Fang <shafang@microsoft.com> Co-authored-by: Ralf Beckers <bexxx@users.noreply.github.com> Co-authored-by: shraddhasun <128851887+shraddhasun@users.noreply.github.com> Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com> Co-authored-by: Tamer Sherif <69483382+tasherif-msft@users.noreply.github.com> Co-authored-by: Tricia Rosario <triciapsr@gmail.com> Co-authored-by: Tricia Rosario <trrosari@microsoft.com> Co-authored-by: jaclin1111 <jacobyslin@gmail.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: Samir Solanki <samirsolanki@outlook.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Rafał Mielowski <rmielowski@microsoft.com> Co-authored-by: Mahsa Sadi <mahsasadi@microsoft.com> Co-authored-by: Vidisha Shah <102258037+vidishamsft@users.noreply.github.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Dylan Martinez <martinez.dylanj@gmail.com> Co-authored-by: Dylan Martinez <dymartinez@microsoft.com> Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: Priyanshi Jain <87351063+priyjain358@users.noreply.github.com> Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com> Co-authored-by: miaxzhitong <146033271+miaxzhitong@users.noreply.github.com> Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com> Co-authored-by: Jim Chou <77021369+jimchou-dev@users.noreply.github.com>

Azure/sdk-release-request#5301 breaking caused by Azure/azure-rest-api-specs#28891

martinezdylan requested review from Sandido, dkulkarni-ms, haagha, MS-syh2qs and grizzlytheodore as code owners April 29, 2024 16:24

martinezdylan force-pushed the release-compute-Microsoft.Compute-stable/2024-03-01-securitypostureref branch from b9fc59a to b71e51f Compare April 29, 2024 16:26

azure-sdk added the BreakingChange-Go-Sdk label Apr 29, 2024

azure-sdk mentioned this pull request Apr 29, 2024

[AutoPR Azure.ResourceManager.Compute] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-net#7862

Closed

This was referenced Apr 29, 2024

[AutoPR azure-resourcemanager-compute-generated] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-java#10335

Closed

[AutoPR @azure/arm-compute] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-js#9711

Closed

azure-sdk added the BreakingChange-JavaScript-Sdk label Apr 29, 2024

azure-sdk mentioned this pull request Apr 29, 2024

[AutoPR Az.compute.DefaultTag] Update securityPostureReference in VMScaleSet API azure-sdk/azure-powershell#6506

Closed

azure-sdk mentioned this pull request Apr 29, 2024

[AutoPR azure-mgmt-compute] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-python#7028

Closed

martinezdylan added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label May 1, 2024

martinezdylan force-pushed the release-compute-Microsoft.Compute-stable/2024-03-01-securitypostureref branch from b71e51f to 7161eff Compare May 1, 2024 18:38

AzureRestAPISpecReview added NotReadyForARMReview and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels May 1, 2024

azure-sdk removed the BreakingChange-Python-Sdk label May 29, 2024

msyyc added the BreakingChange-Python-Sdk-Suppression-Approved label May 29, 2024

add azure-sdk-for-go suppression

3c59e22

openapi-pipeline-app bot added the BreakingChange-Go-Sdk-Suppression label May 29, 2024

azure-sdk removed the BreakingChange-Go-Sdk label May 29, 2024

Update sdk-suppressions.yaml

8434bfb

openapi-pipeline-app bot added the BreakingChange-JavaScript-Sdk-Suppression label May 30, 2024

azure-sdk removed the BreakingChange-JavaScript-Sdk label May 30, 2024

qiaozha added Approved-SdkBreakingChange-JavaScript BreakingChange-JavaScript-Sdk-Suppression-Approved labels May 31, 2024

raych1 added the BreakingChange-Go-Sdk-Suppression-Approved label Jun 4, 2024

microsoft-github-policy-service bot added the MergeRequested label Jun 5, 2024

rkmanda approved these changes Jun 5, 2024

View reviewed changes

rkmanda merged commit 491e00d into main Jun 5, 2024
27 of 32 checks passed

rkmanda deleted the release-compute-Microsoft.Compute-stable/2024-03-01-securitypostureref branch June 5, 2024 22:03

AkhilaIlla mentioned this pull request Jun 24, 2024

Akhilailla/fix properties type object no definition false negatives Azure/azure-openapi-validator#718

Merged

Alancere mentioned this pull request Jul 10, 2024

[Release] sdk/resourcemanager/compute/armcompute/6.0.0 Azure/azure-sdk-for-go#23129

Merged

weidongxu-microsoft mentioned this pull request Jul 16, 2024

Remove useref and Fleet update changes #29493

Merged

7 tasks

kazrael2119 mentioned this pull request Jul 25, 2024

[mgmt] compute release Azure/azure-sdk-for-js#30423

Merged

MaryGao pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 26, 2024

[mgmt] compute release (#30423)

1591f79

Azure/sdk-release-request#5301 breaking caused by Azure/azure-rest-api-specs#28891

martinezdylan mentioned this pull request Sep 4, 2024

Update Security Posture Reference on az vmss create and az vmss update commands Azure/azure-cli#29846

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `securityPostureReference` in VMScaleSet API #28891

Update `securityPostureReference` in VMScaleSet API #28891

martinezdylan commented Apr 29, 2024

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading

openapi-workflow-bot bot commented Apr 29, 2024

martinezdylan commented Apr 29, 2024

Next Steps to Merge

raych1 commented May 30, 2024

martinezdylan commented May 30, 2024

grizzlytheodore commented Jun 3, 2024

martinezdylan commented Jun 5, 2024

Update securityPostureReference in VMScaleSet API #28891

Update securityPostureReference in VMScaleSet API #28891

Conversation

martinezdylan commented Apr 29, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Apr 29, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Apr 29, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 29, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Apr 29, 2024 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 29, 2024

martinezdylan commented Apr 29, 2024

Next Steps to Merge

raych1 commented May 30, 2024

martinezdylan commented May 30, 2024

grizzlytheodore commented Jun 3, 2024

martinezdylan commented Jun 5, 2024

Update `securityPostureReference` in VMScaleSet API #28891

Update `securityPostureReference` in VMScaleSet API #28891

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 29, 2024 •

edited

Loading