Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] Add API for adding external storage account configurations to a web app #3423

Closed
wants to merge 24 commits into from

Conversation

ebencarek
Copy link
Contributor

@ebencarek ebencarek commented Jul 16, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • recoveryservicesbackup/resource-manager
  • automation/resource-manager
  • streamanalytics/resource-manager
  • storage/resource-manager
  • apimanagement/resource-manager
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • compute/resource-manager
  • hanaonazure/resource-manager
  • alertsmanagement/resource-manager
  • security/resource-manager
  • iothub/resource-manager
  • hdinsight/resource-manager
  • cognitiveservices/resource-manager
  • powerbiembedded/resource-manager
  • web/resource-manager
  • containerservices/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • botservice/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • servicefabricmesh/resource-manager
  • azsadmin/resource-manager/azurebridge/Microsoft.AzureBridge.Admin
  • sql/resource-manager

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-ruby

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • streamanalytics/resource-manager
  • cognitiveservices/resource-manager
  • storage/resource-manager
  • web/resource-manager
  • botservice/resource-manager
  • powerbiembedded/resource-manager
  • alertsmanagement/resource-manager
  • servicefabricmesh/resource-manager
  • sql/resource-manager
  • recoveryservicesbackup/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • apimanagement/resource-manager
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • azsadmin/resource-manager/azurebridge/Microsoft.AzureBridge.Admin
  • automation/resource-manager
  • hdinsight/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • iothub/resource-manager
  • compute/resource-manager
  • hanaonazure/resource-manager
  • containerservices/resource-manager
  • security/resource-manager

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • apimanagement/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • security/resource-manager
  • compute/resource-manager
  • iothub/resource-manager
  • servicefabricmesh/resource-manager
  • sql/resource-manager
  • alertsmanagement/resource-manager
  • botservice/resource-manager
  • hdinsight/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • web/resource-manager
  • powerbiembedded/resource-manager
  • azsadmin/resource-manager/azurebridge/Microsoft.AzureBridge.Admin
  • automation/resource-manager
  • containerservices/resource-manager
  • hanaonazure/resource-manager
  • storage/resource-manager
  • streamanalytics/resource-manager
  • cognitiveservices/resource-manager
  • recoveryservicesbackup/resource-manager

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • powerbiembedded/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • apimanagement/resource-manager
  • botservice/resource-manager
  • servicefabricmesh/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • web/resource-manager
  • hanaonazure/resource-manager
  • automation/resource-manager
  • storage/resource-manager
  • sql/resource-manager
  • cognitiveservices/resource-manager
  • hdinsight/resource-manager
  • security/resource-manager
  • compute/resource-manager
  • azsadmin/resource-manager/azurebridge/Microsoft.AzureBridge.Admin
  • containerservices/resource-manager
  • streamanalytics/resource-manager
  • recoveryservicesbackup/resource-manager
  • iothub/resource-manager
  • alertsmanagement/resource-manager

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2018

Automation for azure-sdk-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • storage/resource-manager
  • azsadmin/resource-manager/azurebridge/Microsoft.AzureBridge.Admin
  • iothub/resource-manager
  • cognitiveservices/resource-manager
  • recoveryservicesbackup/resource-manager
  • streamanalytics/resource-manager
  • sql/resource-manager
  • hdinsight/resource-manager
  • apimanagement/resource-manager
  • alertsmanagement/resource-manager
  • compute/resource-manager
  • botservice/resource-manager
  • automation/resource-manager
  • powerbiembedded/resource-manager
  • servicefabricmesh/resource-manager
  • web/resource-manager
  • hanaonazure/resource-manager
  • azsadmin/resource-manager/network/Microsoft.Network.Admin
  • security/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • containerservices/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service

solankisamir and others added 15 commits July 17, 2018 14:25
* add revision description

* fixed missing file reference

* add the missing file
* Added BackupValidateOperation API

* Added BackupValidateOperation API

* Fix casing in validateOperationResponse

* Fix casing in validateOperationResponse

* Fix casing in swagger example file path

* Use ValidateRequest instead of Resource<ValidateRequest>

* Update operationid of validate_Operation to Operation_Validate per feedback

* Update operationid of validate_Operation to Operation_Validate per feedback

* remove additional parameter api-version
* Address CR comments

* Address CR comment

* Address PR comments in C#

* Fix syntax error

* Address CR comments
* Updated webapps swagger with restore deleted site APIs

* Update default package version for WebSiteManagementClient
* Swagger of sensitivity labels APIs

Adding swagger containing APIs of sensitivity labels, as long as usage examples of these APIs.

* Reference common definitions.

Reference common definitions.
@ebencarek
Copy link
Contributor Author

Messed up commit history. Abandoned this PR, created new PR #3444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.