Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AKS] remove "KeyVaultSecretRef" and rename to "ManagedClusterServicePrincipalProfile" #3488

Merged
merged 1 commit into from
Jul 26, 2018
Merged

[AKS] remove "KeyVaultSecretRef" and rename to "ManagedClusterServicePrincipalProfile" #3488

merged 1 commit into from
Jul 26, 2018

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jul 24, 2018 •
edited
Loading

This was mistakenly copied from ContainerServiceServicePrincipalProfile and was never supported by AKS.

Since this swagger is built along with the ACS API, this requires renaming the class so their definitions can differ. This may be a breaking change for generated SDKs.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI AutorestCI mentioned this pull request Jul 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2954

@AutorestCI AutorestCI mentioned this pull request Jul 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2848

@azuresdkci azuresdkci requested a review from dsgouda July 24, 2018 16:53
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jul 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2324

dsgouda
dsgouda suggested changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, please address the comments.

...rservices/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json
@@ -750,28 +750,7 @@
"Standard_NV6"
]
},
"KeyVaultSecretRef": {
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A. Please note that this could be a breaking change in the SDKs generated
B. Please check if you need to update any of the examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda I did check the examples, but we weren't using keyVaultSecretRef anywhere so this change still passes oav validate-example.

I did note that this is a breaking change in the PR message. Should I mention it elsewhere? Change to package-version: 5.0.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it is ackowledged, shouldn't be a blocker

dsgouda
dsgouda approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 2f86e91 into Azure:master Jul 26, 2018
@mboersma mboersma deleted the aks-remove-keyvault-secret-ref branch July 26, 2018 21:10
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@jainharsh98
Making User Details and Offer details required fields for Confluent (#…
cfe0e1c 
…3488)

* Making User Details and Offer details required fields

* Removing the all-api-versions tag as it is abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@weinong weinong weinong approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @AutorestCI @weinong @dsgouda