Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] remove "KeyVaultSecretRef" and rename to "ManagedClusterServicePrincipalProfile" #3488

Merged
merged 1 commit into from
Jul 26, 2018
Merged

[AKS] remove "KeyVaultSecretRef" and rename to "ManagedClusterServicePrincipalProfile" #3488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions ...rvices/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,28 +750,7 @@
"Standard_NV6"
]
},
"KeyVaultSecretRef": {
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A. Please note that this could be a breaking change in the SDKs generated
B. Please check if you need to update any of the examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda I did check the examples, but we weren't using keyVaultSecretRef anywhere so this change still passes oav validate-example.

I did note that this is a breaking change in the PR message. Should I mention it elsewhere? Change to package-version: 5.0.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it is ackowledged, shouldn't be a blocker

"vaultID": {
"type": "string",
"description": "Key vault identifier."
},
"secretName": {
"type": "string",
"description": "The secret name."
},
"version": {
"type": "string",
"description": "The secret version."
}
},
"description": "Reference to a secret stored in Azure Key Vault.",
"required": [
"vaultID",
"secretName"
]
},
"ContainerServiceServicePrincipalProfile": {
"ManagedClusterServicePrincipalProfile": {
"properties": {
"clientId": {
"type": "string",
Expand All @@ -780,13 +759,9 @@
"secret": {
"type": "string",
"description": "The secret password associated with the service principal in plain text."
},
"keyVaultSecretRef": {
"$ref": "#/definitions/KeyVaultSecretRef",
"description": "Reference to a secret stored in Azure Key Vault."
}
},
"description": "Information about a service principal identity for the cluster to use for manipulating Azure APIs. Either secret or keyVaultSecretRef must be specified.",
"description": "Information about a service principal identity for the cluster to use for manipulating Azure APIs.",
"required": [
"clientId"
]
Expand Down Expand Up @@ -1121,8 +1096,8 @@
"description": "Profile for Linux VMs in the container service cluster."
},
"servicePrincipalProfile": {
"$ref": "#/definitions/ContainerServiceServicePrincipalProfile",
"description": "Information about a service principal identity for the cluster to use for manipulating Azure APIs. Either secret or keyVaultSecretRef must be specified."
"$ref": "#/definitions/ManagedClusterServicePrincipalProfile",
"description": "Information about a service principal identity for the cluster to use for manipulating Azure APIs."
},
"addonProfiles": {
"additionalProperties": {
Expand Down