Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoNotMerge] Add Allowed Connections REST API #3626

Closed
wants to merge 8 commits into from
Closed

[DoNotMerge] Add Allowed Connections REST API #3626

wants to merge 8 commits into from

Conversation

snhaphil
Copy link
Contributor

Adding allowed connections Rest API for Azure Security Center.
TFS item: https://msazure.visualstudio.com/One/_workitems/edit/2745880

@AutorestCI
Copy link

AutorestCI commented Aug 12, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 12, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Aug 12, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 12, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 12, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2653

@snhaphil snhaphil changed the title Add Allowed Connections REST API [DoNotMerge] Add Allowed Connections REST API Aug 12, 2018
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@chlahav chlahav self-requested a review August 12, 2018 13:22
@chlahav chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 12, 2018
@marstr
Copy link
Member

marstr commented Aug 16, 2018

Howdy @chlahav. I'm looking into the CI failures, but I'm not seeing anything that it was introduced by your PR. I'm going to reach-out internally to see if this is a known issue. If I don't get back to you by Monday, please ping this thread to remind me!

@marstr
Copy link
Member

marstr commented Aug 24, 2018

I'm still not sure why CI is failing. Also, I'm going to be OOF all next week.

For that reason, my recommendation is that this PR be closed and re-opened in a new PR. It will automatically get reassigned, and CI will be given a fresh shot.

How's that sound @chlahav? If not, I'll mark it for reassignment.

@marstr
Copy link
Member

marstr commented Sep 10, 2018

Closing as stale, please re-open as a new PR if you'd like it to be evaluated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants