Add Allowed Connections REST API #4106

snhaphil · 2018-10-09T07:12:07Z

Reopening the previously closed PR:
#3626

Adding allowed connections Rest API for Azure Security Center.
TFS item: https://msazure.visualstudio.com/One/_workitems/edit/2745880

…pecs

AutorestCI · 2018-10-09T07:12:24Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#471

AutorestCI · 2018-10-09T07:12:34Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3782

AutorestCI · 2018-10-09T07:13:08Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-10-09T07:14:02Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4079

azuresdkci · 2018-10-09T07:14:05Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-09T07:14:42Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

chlahav · 2018-10-09T10:29:51Z

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

+                }
+            }
+        },
+        "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/locations/{ascLocation}/allowedConnections/{connectionsType}": {


please change connectionsType parameter name to connectionType

@snhaphil @yanivid3 was not resolved yet

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

chlahav · 2018-10-09T10:33:09Z

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

+                        }
+                    }
+                }
+            }


missing "list by resource group" path and "list by resource group and home region" path

Chen, list by RG is implicitly defined when we have list by Susbcription, ins't ? We do not have in other API's list by RG (although supported)

@yanivn3 if it's not defined in the swagger it will not be documented and will not be available to any generated client. if the path is supported then it should be available in the swagger.

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

chlahav · 2018-10-09T11:55:25Z

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

+                "inboundConnectedResources": {
+                    "type": "array",
+                    "readOnly": true,
+                    "description": "The list of azure resources that the resource has inbound allowed connection from",


please replace "azure" with "Azure" in all occurrences

@snhaphil reminder

chlahav · 2018-10-09T11:59:06Z

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

+            "name": "connectionsType",
+            "type": "string",
+            "in": "path",
+            "description": "The type of allowed connections.",


please add allowed values in the description as well since it is not visible in the documentation yet

chlahav · 2018-10-09T12:00:55Z

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

+            "in": "path",
+            "description": "The type of allowed connections.",
+            "required": true,
+            "enum": [


add the "x-ms-enum" properties like the other enums in this file

...ty/preview/2015-06-01-preview/examples/AllowedConnections/GetAllowedConnections_example.json

chlahav · 2018-10-09T12:07:48Z

...ty/preview/2015-06-01-preview/examples/AllowedConnections/GetAllowedConnections_example.json

+    "responses": {
+        "200": {
+            "body": {
+                "value": [


value field should not be present - this is a get single

…pecs

AutorestCI · 2018-10-16T08:03:40Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3274

KrisBash · 2018-10-17T17:45:01Z

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

@@ -1437,6 +1437,132 @@
                    }
                }
            }
+        },
+        "/subscriptions/{subscriptionId}/providers/Microsoft.Security/allowedConnections": {


Wouldn't it make sense to allow a $filter property to filter the results at this scope?

KrisBash · 2018-10-17T17:45:43Z

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json

@@ -1437,6 +1437,132 @@
                    }
                }
            }
+        },
+        "/subscriptions/{subscriptionId}/providers/Microsoft.Security/allowedConnections": {
+            "get": {


Are these resources system-generated? The user can't update/delete them?

Correct. It is a read only collection. User get only see the outcome of the computation we perform.

@KrisBash , This API was reviewed by Gaurav more than 6m ago and it is already deployed. We issued the PR here in order to add it to ASC SDK and to update documentation.

KrisBash

Signing off, but please review comments. In the future, please schedule a review with the ARM API review alias for new resource types.

yanivn3 · 2018-10-18T10:59:44Z

@chlahav , Can you approve the PR as well and remove the DoNoMerge ?

anuchandy · 2018-10-22T18:03:05Z

@snhaphil, @yanivn3, @chlahav - are we good to merge this? any more changes?

chlahav

please address the comments

This reverts commit 2389da3.

* Revert "Add maximum chunk size to data lake store docs. (#4464)" This reverts commit ab9c6ff. * Revert "Add latest authorization tag to java config (#4406)" This reverts commit 7f0fd16. * Revert "Mdb 20181029 statepropdescriptions (#4452)" This reverts commit 90db24c. * Revert "fixing invalid location in examples (#4415)" This reverts commit ffaf595. * Revert "/identity endpoint added (#4460)" This reverts commit 4f93dee. * Revert "Added missing PATCH operation to Api Issue resource (#4440)" This reverts commit 7df0ce5. * Revert "Adds storage account quick failover API (#4457)" This reverts commit 10ec74f. * Revert "DataFactory: add table name in dataset (#4424)" This reverts commit f8465de. * Revert "Update README.md (#4421)" This reverts commit fa6a584. * Revert "Move Ruby SDK config to its own config file (#4451)" This reverts commit 2ca50c8. * Revert "[CognitiveServices] enable Bing Search/CustomSearch products to specify Endpoint (#4401)" This reverts commit dc782b3. * Revert "Add GeoRegion property to DeletedSite model (#4448)" This reverts commit a079367. * Revert " Azure Container Instance: Add start container group API (#4423)" This reverts commit 2ea3e9e. * Revert "add guidance for example names (#4432)" This reverts commit 6780e8a. * Revert "Remove security contact phone field mandatory fields (#4417)" This reverts commit eaf464e. * Revert "Add Allowed Connections REST API (#4106)" This reverts commit 2389da3. * Revert "Make NIC VM readOnly (#4444)" This reverts commit 2d83450. * Revert "Remove readonly attribute from identities collection in users (#4442)" This reverts commit 7577df9. * Revert "Add spec for alert repair/remediate (#4084)" This reverts commit 3f568b4. * Revert "Py conf in its own file (#4439)" This reverts commit 3373760. * Revert "Split Python conf in it's own file (#4438)" This reverts commit 77cf607. * Revert "Adding ManagedInstanceVulnerabilityAssessments and ServerVulnerabilityAssessments (#4416)" This reverts commit dec7549. * Revert "WebApps: Snapshots API for DR stamps (#4291)" This reverts commit 916ff2e. * Revert "Swagger closure for Azure Migration Hub Operations (#4330)" This reverts commit badd1de.

snhaphil and others added 8 commits August 7, 2018 14:59

Added allowed connections to security.json

8672bb0

Added allowed connections to security.json

53c48d2

added examples

749cc7c

Merge branch 'master' of https://github.com/snhaphil/azure-rest-api-s…

2d973eb

…pecs

modified the examples resources name

63bd3e6

Modified the asclocation in the examples file

1b32e8a

reformatted and added newline at the EOF

81ffdfe

modified examples description in security.json

6bebd1b

azuresdkci assigned anuchandy Oct 9, 2018

azuresdkci requested a review from anuchandy October 9, 2018 07:13

snhaphil changed the title ~~[DoNotMerge] Add Allowed Connections REST API~~ Add Allowed Connections REST API Oct 9, 2018

chlahav self-requested a review October 9, 2018 10:26

chlahav requested changes Oct 9, 2018

View reviewed changes

chlahav added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required DoNotMerge <valid label in PR review process> use to hold merge after approval labels Oct 9, 2018

Chen Lahav and others added 3 commits October 10, 2018 15:27

Fixing additionalProperties configuration to match type verification

1c8d0c5

pr fixes

d151347

Merge branch 'master' of https://github.com/snhaphil/azure-rest-api-s…

a11fb22

…pecs

anuchandy requested a review from ravbhatnagar October 12, 2018 19:31

modified the description to be aligned with ASC doc.

3361226

AutorestCI mentioned this pull request Oct 16, 2018

[AutoPR security/resource-manager] Add Allowed Connections REST API Azure/azure-sdk-for-go#3029

Closed

KrisBash reviewed Oct 17, 2018

View reviewed changes

KrisBash approved these changes Oct 17, 2018

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 17, 2018

inserted topologies addition to security.json

b52ae61

AutorestCI mentioned this pull request Oct 21, 2018

[AutoPR security/resource-manager] Add Allowed Connections REST API Azure/azure-sdk-for-go#3094

Closed

merged from master

8462480

chlahav requested changes Oct 23, 2018

View reviewed changes

chlahav removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 11, 2018

chlahav approved these changes Nov 11, 2018

View reviewed changes

anuchandy approved these changes Nov 12, 2018

View reviewed changes

anuchandy merged commit 2389da3 into Azure:master Nov 12, 2018

lmazuel added a commit that referenced this pull request Nov 15, 2018

Revert "Add Allowed Connections REST API (#4106)"

04affae

This reverts commit 2389da3.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Allowed Connections REST API #4106

Add Allowed Connections REST API #4106

snhaphil commented Oct 9, 2018

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 9, 2018 •

edited

Loading

azuresdkci commented Oct 9, 2018

AutorestCI commented Oct 9, 2018 •

edited

Loading

chlahav Oct 9, 2018

snhaphil Oct 10, 2018

chlahav Oct 23, 2018

chlahav Oct 9, 2018

snhaphil Oct 10, 2018

yanivn3 Oct 18, 2018

chlahav Oct 23, 2018

chlahav Oct 9, 2018

chlahav Oct 23, 2018

chlahav Oct 9, 2018

chlahav Oct 9, 2018

chlahav Oct 9, 2018

AutorestCI commented Oct 16, 2018 •

edited

Loading

KrisBash Oct 17, 2018

KrisBash Oct 17, 2018

yanivn3 Oct 18, 2018

yanivn3 Oct 18, 2018

KrisBash left a comment

yanivn3 commented Oct 18, 2018

anuchandy commented Oct 22, 2018

chlahav left a comment

Add Allowed Connections REST API #4106

Add Allowed Connections REST API #4106

Conversation

snhaphil commented Oct 9, 2018

AutorestCI commented Oct 9, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Oct 9, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Oct 9, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Oct 9, 2018 • edited Loading

Automation for azure-sdk-for-node

azuresdkci commented Oct 9, 2018

AutorestCI commented Oct 9, 2018 • edited Loading

Automation for azure-sdk-for-java

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Oct 16, 2018 • edited Loading

Automation for azure-sdk-for-go

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

yanivn3 commented Oct 18, 2018

anuchandy commented Oct 22, 2018

chlahav left a comment

Choose a reason for hiding this comment

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 9, 2018 •

edited

Loading

AutorestCI commented Oct 16, 2018 •

edited

Loading