-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Allowed Connections REST API #4106
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8672bb0
Added allowed connections to security.json
snhaphil 53c48d2
Added allowed connections to security.json
snhaphil 749cc7c
added examples
snhaphil 2d973eb
Merge branch 'master' of https://github.com/snhaphil/azure-rest-api-s…
snhaphil 63bd3e6
modified the examples resources name
snhaphil 1b32e8a
Modified the asclocation in the examples file
snhaphil 81ffdfe
reformatted and added newline at the EOF
snhaphil 6bebd1b
modified examples description in security.json
snhaphil 1c8d0c5
Fixing additionalProperties configuration to match type verification
d151347
pr fixes
snhaphil a11fb22
Merge branch 'master' of https://github.com/snhaphil/azure-rest-api-s…
snhaphil 3361226
modified the description to be aligned with ASC doc.
snhaphil b52ae61
inserted topologies addition to security.json
snhaphil 8462480
merged from master
snhaphil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
65 changes: 65 additions & 0 deletions
65
...review/examples/AllowedConnections/GetAllowedConnectionsSubscriptionLocation_example.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2015-06-01-preview", | ||
| "subscriptionId": "3eeab341-f466-499c-a8be-85427e154bad", | ||
| "ascLocation": "centralus" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "type": "Microsoft.Security/locations/allowedConnections", | ||
| "properties": { | ||
| "calculatedDateTime": "2018-08-06T14:55:32.3518545Z", | ||
| "connectableResources": [ | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "inboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ], | ||
| "outboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "inboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ], | ||
| "outboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine3", | ||
| "inboundConnectedResources": [], | ||
| "outboundConnectedResources": [] | ||
| } | ||
| ] | ||
| }, | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Security/locations/centralus/allowedConnections/Internal", | ||
| "name": "Internal", | ||
| "location": "centralus" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
64 changes: 64 additions & 0 deletions
64
...-06-01-preview/examples/AllowedConnections/GetAllowedConnectionsSubscription_example.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2015-06-01-preview", | ||
| "subscriptionId": "3eeab341-f466-499c-a8be-85427e154bad" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "type": "Microsoft.Security/locations/allowedConnections", | ||
| "properties": { | ||
| "calculatedDateTime": "2018-08-06T14:55:32.3518545Z", | ||
| "connectableResources": [ | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "inboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ], | ||
| "outboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "inboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ], | ||
| "outboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine3", | ||
| "inboundConnectedResources": [], | ||
| "outboundConnectedResources": [] | ||
| } | ||
| ] | ||
| }, | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Security/locations/centralus/allowedConnections/Internal", | ||
| "name": "Internal", | ||
| "location": "centralus" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
67 changes: 67 additions & 0 deletions
67
...preview/2015-06-01-preview/examples/AllowedConnections/GetAllowedConnections_example.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2015-06-01-preview", | ||
| "subscriptionId": "3eeab341-f466-499c-a8be-85427e154bad", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "ascLocation": "centralus", | ||
| "topologyResourceName": "Internal" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "type": "Microsoft.Security/locations/allowedConnections", | ||
| "properties": { | ||
| "calculatedDateTime": "2018-08-06T14:55:32.3518545Z", | ||
| "connectableResources": [ | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "inboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ], | ||
| "outboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine2", | ||
| "inboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ], | ||
| "outboundConnectedResources": [ | ||
| { | ||
| "connectedResourceId": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine1", | ||
| "tcpPorts": "[0-21,23-3388,3390-5984,5987-65535]", | ||
| "udpPorts": "[0-21,23-3388,3390-5984,5987-65535]" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/virtaulMachine3", | ||
| "inboundConnectedResources": [], | ||
| "outboundConnectedResources": [] | ||
| } | ||
| ] | ||
| }, | ||
| "id": "/subscriptions/3eeab341-f466-499c-a8be-85427e154baf/resourceGroups/myResourceGroup/providers/Microsoft.Security/locations/westcentralus/allowedConnections/Internal", | ||
snhaphil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "name": "Internal", | ||
| "location": "centralus" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value field should not be present - this is a get single