Added missing PATCH operation to Api Issue resource #4440

promoisha · 2018-11-09T22:44:01Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

openapi-portal-comment · 2018-11-09T22:44:02Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-11-09T22:45:08Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-11-09T22:45:32Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3106

azuresdkci · 2018-11-09T22:45:32Z

Can one of the admins verify this patch?

AutorestCI · 2018-11-09T22:46:42Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1898

solankisamir

Please rebase your branch, 2018-01-01 changes went into the stable branch folder.
also you would need to update the 2018-06-01-preview, as that is files, we will use to create our next stable version. Also currently documentation is driven out of 2018-06-01-preview version.

AutorestCI · 2018-11-09T22:48:00Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#491

solankisamir · 2018-11-09T22:48:20Z

...tion/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2018-01-01/apimapis.json

+        "operationId": "ApiIssue_Update",
+        "description": "Updates an existing issue for an API.",
+        "x-ms-examples": {
+          "ApiManagementCreateApiIssue": {


fix Example Name ApiManagementUpdateApiIssue

solankisamir · 2018-11-09T22:51:08Z

...management/resource-manager/Microsoft.ApiManagement/preview/2018-06-01-preview/apimapis.json

+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/IssueContract"


For Update you will need to create a separate contract, as the IssueContract has the following required properties
title
description
userId

Maybe you can take out commonn properties into base properties.

AutorestCI · 2018-11-09T22:51:46Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3297

AutorestCI · 2018-11-09T22:52:40Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4099

annatisch · 2018-11-09T23:00:27Z

Thanks @promoisha - please rebase your branch, as there are merge conflicts. :)

...ation/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2018-01-01/apimapis.json

...-manager/Microsoft.ApiManagement/stable/2018-01-01/examples/ApiManagementUpdateApiIssue.json

...Microsoft.ApiManagement/preview/2018-06-01-preview/examples/ApiManagementUpdateApiIssue.json

solankisamir

This reverts commit 7df0ce5.

* Revert "Add maximum chunk size to data lake store docs. (#4464)" This reverts commit ab9c6ff. * Revert "Add latest authorization tag to java config (#4406)" This reverts commit 7f0fd16. * Revert "Mdb 20181029 statepropdescriptions (#4452)" This reverts commit 90db24c. * Revert "fixing invalid location in examples (#4415)" This reverts commit ffaf595. * Revert "/identity endpoint added (#4460)" This reverts commit 4f93dee. * Revert "Added missing PATCH operation to Api Issue resource (#4440)" This reverts commit 7df0ce5. * Revert "Adds storage account quick failover API (#4457)" This reverts commit 10ec74f. * Revert "DataFactory: add table name in dataset (#4424)" This reverts commit f8465de. * Revert "Update README.md (#4421)" This reverts commit fa6a584. * Revert "Move Ruby SDK config to its own config file (#4451)" This reverts commit 2ca50c8. * Revert "[CognitiveServices] enable Bing Search/CustomSearch products to specify Endpoint (#4401)" This reverts commit dc782b3. * Revert "Add GeoRegion property to DeletedSite model (#4448)" This reverts commit a079367. * Revert " Azure Container Instance: Add start container group API (#4423)" This reverts commit 2ea3e9e. * Revert "add guidance for example names (#4432)" This reverts commit 6780e8a. * Revert "Remove security contact phone field mandatory fields (#4417)" This reverts commit eaf464e. * Revert "Add Allowed Connections REST API (#4106)" This reverts commit 2389da3. * Revert "Make NIC VM readOnly (#4444)" This reverts commit 2d83450. * Revert "Remove readonly attribute from identities collection in users (#4442)" This reverts commit 7577df9. * Revert "Add spec for alert repair/remediate (#4084)" This reverts commit 3f568b4. * Revert "Py conf in its own file (#4439)" This reverts commit 3373760. * Revert "Split Python conf in it's own file (#4438)" This reverts commit 77cf607. * Revert "Adding ManagedInstanceVulnerabilityAssessments and ServerVulnerabilityAssessments (#4416)" This reverts commit dec7549. * Revert "WebApps: Snapshots API for DR stamps (#4291)" This reverts commit 916ff2e. * Revert "Swagger closure for Azure Migration Hub Operations (#4330)" This reverts commit badd1de.

* Update hpcworkbench * Update interdomain on custom words to fix spell check * Update hpcworkbench.json (#4440) Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

azuresdkci assigned annatisch Nov 9, 2018

azuresdkci requested a review from annatisch November 9, 2018 22:45

AutorestCI mentioned this pull request Nov 9, 2018

[AutoPR apimanagement/resource-manager] Added missing PATCH operation to Api Issue resource Azure/azure-sdk-for-python#3773

Merged

AutorestCI mentioned this pull request Nov 9, 2018

[AutoPR apimanagement/resource-manager] Added missing PATCH operation to Api Issue resource Azure/azure-sdk-for-ruby#1893

Closed

solankisamir requested changes Nov 9, 2018

View reviewed changes

AutorestCI mentioned this pull request Nov 9, 2018

[AutoPR apimanagement/resource-manager] Added missing PATCH operation to Api Issue resource Azure/azure-sdk-for-js#462

Closed

solankisamir reviewed Nov 9, 2018

View reviewed changes

This was referenced Nov 9, 2018

[AutoPR apimanagement/resource-manager] Added missing PATCH operation to Api Issue resource Azure/azure-sdk-for-go#3269

Merged

[AutoPR apimanagement/resource-manager] Added missing PATCH operation to Api Issue resource Azure/azure-sdk-for-node#4070

Merged

annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 9, 2018

promoisha force-pushed the glfeokti_apiissues_patch_operation branch from 73c3ebb to dcb5eb7 Compare November 9, 2018 23:25

solankisamir requested changes Nov 9, 2018

View reviewed changes

Added missing PATCH operation to Api Issue resource

ccc27d4

promoisha force-pushed the glfeokti_apiissues_patch_operation branch from dcb5eb7 to ccc27d4 Compare November 9, 2018 23:39

solankisamir approved these changes Nov 10, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 12, 2018

annatisch approved these changes Nov 14, 2018

View reviewed changes

annatisch merged commit 7df0ce5 into Azure:master Nov 14, 2018

AutorestCI mentioned this pull request Nov 14, 2018

[AutoPR apimanagement/resource-manager] Added missing PATCH operation to Api Issue resource Azure/azure-sdk-for-js#490

Merged

lmazuel added a commit that referenced this pull request Nov 15, 2018

Revert "Added missing PATCH operation to Api Issue resource (#4440)"

7fba260

This reverts commit 7df0ce5.

solankisamir mentioned this pull request Nov 21, 2018

Add ApiIssueUpdateContract, support for OpenId auth in ApiContract Azure/azure-sdk-for-net#5047

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added missing PATCH operation to Api Issue resource #4440

Added missing PATCH operation to Api Issue resource #4440

promoisha commented Nov 9, 2018

openapi-portal-comment bot commented Nov 9, 2018

AutorestCI commented Nov 9, 2018 •

edited

Loading

AutorestCI commented Nov 9, 2018 •

edited

Loading

azuresdkci commented Nov 9, 2018

AutorestCI commented Nov 9, 2018 •

edited

Loading

solankisamir left a comment

AutorestCI commented Nov 9, 2018 •

edited

Loading

solankisamir Nov 9, 2018

promoisha Nov 9, 2018

solankisamir Nov 9, 2018

promoisha Nov 9, 2018

AutorestCI commented Nov 9, 2018 •

edited

Loading

AutorestCI commented Nov 9, 2018 •

edited

Loading

annatisch commented Nov 9, 2018

solankisamir left a comment

Added missing PATCH operation to Api Issue resource #4440

Added missing PATCH operation to Api Issue resource #4440

Conversation

promoisha commented Nov 9, 2018

Latest improvements:

Contribution checklist:

openapi-portal-comment bot commented Nov 9, 2018

AutorestCI commented Nov 9, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Nov 9, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Nov 9, 2018

AutorestCI commented Nov 9, 2018 • edited Loading

Automation for azure-sdk-for-ruby

solankisamir left a comment

Choose a reason for hiding this comment

AutorestCI commented Nov 9, 2018 • edited Loading

Automation for azure-sdk-for-js

solankisamir Nov 9, 2018

Choose a reason for hiding this comment

promoisha Nov 9, 2018

Choose a reason for hiding this comment

solankisamir Nov 9, 2018

Choose a reason for hiding this comment

promoisha Nov 9, 2018

Choose a reason for hiding this comment

AutorestCI commented Nov 9, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Nov 9, 2018 • edited Loading

Automation for azure-sdk-for-node

annatisch commented Nov 9, 2018

solankisamir left a comment

Choose a reason for hiding this comment

AutorestCI commented Nov 9, 2018 •

edited

Loading

AutorestCI commented Nov 9, 2018 •

edited

Loading

AutorestCI commented Nov 9, 2018 •

edited

Loading

AutorestCI commented Nov 9, 2018 •

edited

Loading

AutorestCI commented Nov 9, 2018 •

edited

Loading

AutorestCI commented Nov 9, 2018 •

edited

Loading