[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #3864

blueww · 2018-09-11T09:31:10Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

Rest Spec: https://microsoft.sharepoint.com/teams/AzureStorage/_layouts/15/Doc.aspx?sourcedoc=%7B00d45481-7f25-4170-a95e-82dbc6a3041d%7D&action=default&slrid=0d385f9e-a0fa-0000-758b-e5dde88dbd09

Pass review on private repo:
New Kind: https://github.com/Azure/azure-rest-api-specs-pr/pull/538
FileAAdIntegration: https://github.com/Azure/azure-rest-api-specs-pr/pull/508

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

… Ignite

AutorestCI · 2018-09-11T09:32:24Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3352

azuresdkci · 2018-09-11T09:35:18Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-11T09:56:15Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

lmazuel · 2018-09-11T18:28:46Z

specification/storage/resource-manager/Microsoft.Storage/stable/2018-07-01/storage.json

+        "tags": [
+          "Usage"
+        ],
+        "operationId": "Usage_List",


Why this renaming from "Usages" to "Usage"? That's a SDK breaking change.

Ok, just see that it was "Usage", and then it was renamed in 2018-03-01-preview as "Usages", and now rename back to "Usage". So I guess it's ok

it should be usages. I will fix it.

lmazuel · 2018-09-11T18:41:23Z

Hi @blueww
What is the status of 2018-03-01-preview? I see that management policies methods are not here in this PR. Does it mean it's missing here (and PR needs to be updated), or that management policies should be still called from 2018-03-01-preview? If the later is the truth, this means there is some Readme configuration to do to mix-up 2018-03-01-preview/2018-07-01 for SDK release.

AutorestCI · 2018-09-11T20:31:39Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-09-11T21:28:10Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-11T22:18:30Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3605

lmazuel · 2018-09-11T23:18:08Z

specification/storage/resource-manager/Microsoft.Storage/stable/2018-07-01/storage.json

+        },
+        "isHnsEnabled": {
+          "type": "boolean",
+          "default": false,


Based on a recent issue found by @williexu in the CLI, please also remove this default value.

lmazuel · 2018-09-11T23:18:12Z

specification/storage/resource-manager/Microsoft.Storage/stable/2018-07-01/storage.json

+        },
+        "supportsHttpsTrafficOnly": {
+          "type": "boolean",
+          "default": false,


Based on a recent issue found by @williexu in the CLI, please also remove this default value.

blueww · 2018-09-12T02:35:30Z

@lmazuel
Management policies is not supported on 2018-07-01, it's only on 2018-03-01-preview now, so there will be a breaking change.
I have discussed with Management policies feature PM and SRP team, and get agreement not support Management policies on 2018-07-01 and the SRP SDK based on it.

We will add back Management policies to a stable api version when the feature GA in the future.

…-api-specs into newkindFileaad

… 2018-07-01

blueww · 2018-09-13T08:32:17Z

@lmazuel
I have added the Management policy feature back. And remove Global Usage list since not supported in new api version (as location usage added).
Please help to review.

specification/storage/resource-manager/Microsoft.Storage/stable/2018-07-01/storage.json

lmazuel · 2018-09-13T16:30:53Z

specification/storage/resource-manager/readme.md

+input-file:
+- Microsoft.Storage/stable/2018-07-01/storage.json
+- Microsoft.Storage/stable/2018-07-01/blob.json
+- Microsoft.Storage/stable/2018-07-01/managementpolicy.json


Please put the new split file in “2018-03-01-preview” folder, and just reference it from here:

Microsoft.Storage/stable/2018-07-01/storage.json

Microsoft.Storage/stable/2018-07-01/blob.json

Microsoft.Storage/stable/2018-03-01-preview/managementpolicy.json

blueww · 2018-09-14T01:53:53Z

@lmazuel
I have fixed the management policy swagger location. And for Usage -> Usages, it's required by OneSDK team since "Using non-plural name for operation group is against SDK guideline ", I think we should keep using "Usages".
I also added new Sku "Premium_ZRS" per feature team requirement.

Since the release is target Ignite, and we need to raise and review SDK PR after the swagger PR is in, would you please help to review and merge the PR asap if no other issues.

Thanks very much!

lmazuel · 2018-09-14T16:20:16Z

@hovsepm , since you already approved, merging the PR. Thanks!

hassanbabaie · 2018-10-06T14:18:22Z

@blueww Hi Wei, just a quick question I see this AAD support coming to AzureFiles, is this the same as what was just released at ignite as that also required the use of Azure Active Directory Domain Services which is a real pain compared to say the new AAD for object storage which doesn't

Please let me know your thoughts

Hass

blueww · 2018-10-08T02:05:16Z

@hassanbabaie
You can find more details for the feature in https://azure.microsoft.com/en-us/blog/azure-active-directory-integration-for-smb-access-now-in-public-preview/
If you have any question or suggestions for this feature, you can contact AzureFiles@microsoft.com

hassanbabaie · 2018-10-08T02:25:34Z

Thank you for the quick response and that answers my questions as it still uses Azure AD Domain Services (AAD DS) however I will also follow up to the e-mail address with feedback

Hass

…#3864) * Added sku/dev (for MIAA/PG) and uploadWatermark (for data controller) in swagger * set proper default boolean value for sku.dev * fix an issue flagged by prettier Co-authored-by: Yuqing Li <yuqingli@ntdev.microsoft.com>

blueww added 5 commits September 11, 2018 15:07

[Storage] Add api version 2018-07-01

98c150d

[Storage] update api version 2018-07-01

1af1dfd

[Storage] Add new Storage Account Kind and Sku

09b8af9

[Storage] Remove the sku Premium_ZRS change as it won't be release in…

7594046

… Ignite

[Storage] Support FileAadIntegration

b302acf

AutorestCI mentioned this pull request Sep 11, 2018

[AutoPR storage/resource-manager] [Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration Azure/azure-sdk-for-python#3318

Merged

azuresdkci assigned hovsepm Sep 11, 2018

azuresdkci requested a review from hovsepm September 11, 2018 09:43

Storage Python conf

3007b14

hovsepm approved these changes Sep 11, 2018

View reviewed changes

lmazuel reviewed Sep 11, 2018

View reviewed changes

AutorestCI mentioned this pull request Sep 11, 2018

[AutoPR storage/resource-manager] [Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration Azure/azure-sdk-for-node#3567

Merged

lmazuel reviewed Sep 11, 2018

View reviewed changes

blueww added 2 commits September 12, 2018 11:11

[Storage] modify per comments

db16a83

Merge branch 'newkindFileaad' of https://github.com/blueww/azure-rest…

3499e47

…-api-specs into newkindFileaad

blueww force-pushed the newkindFileaad branch from ee55d36 to 3499e47 Compare September 12, 2018 06:15

blueww added 3 commits September 12, 2018 14:48

[Storage] Add the parameter location changes in 2018-03-01-preview to…

d6c754a

… 2018-07-01

[Storage] Add back Management Policy from 2017-03-01-preview

3bf8f24

[Storage] remove global usage as server change

fc863cb

blueww force-pushed the newkindFileaad branch from 7a5b7c3 to fc863cb Compare September 13, 2018 07:47

blueww mentioned this pull request Sep 13, 2018

[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration Azure/azure-sdk-for-net#4760

Merged

9 tasks

lmazuel reviewed Sep 13, 2018

View reviewed changes

specification/storage/resource-manager/Microsoft.Storage/stable/2018-07-01/storage.json Show resolved Hide resolved

lmazuel reviewed Sep 13, 2018

View reviewed changes

blueww added 2 commits September 14, 2018 09:44

[Storage] Add new Sku Premium_ZRS

ea7b5de

[Storage] move Management policy swagger to 2018-03-01-preview folder

d6eb4ce

lmazuel approved these changes Sep 14, 2018

View reviewed changes

lmazuel merged commit 8d4e4c2 into Azure:master Sep 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #3864

[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #3864

blueww commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

azuresdkci commented Sep 11, 2018

AutorestCI commented Sep 11, 2018 •

edited

Loading

lmazuel Sep 11, 2018

lmazuel Sep 11, 2018

blueww Sep 12, 2018

lmazuel commented Sep 11, 2018

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

lmazuel Sep 11, 2018

lmazuel Sep 11, 2018

blueww commented Sep 12, 2018

blueww commented Sep 13, 2018

lmazuel Sep 13, 2018

blueww Sep 14, 2018

blueww commented Sep 14, 2018

lmazuel commented Sep 14, 2018

hassanbabaie commented Oct 6, 2018

blueww commented Oct 8, 2018

hassanbabaie commented Oct 8, 2018

[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #3864

[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #3864

Conversation

blueww commented Sep 11, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Sep 11, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Sep 11, 2018

AutorestCI commented Sep 11, 2018 • edited Loading

Automation for azure-sdk-for-ruby

lmazuel Sep 11, 2018

Choose a reason for hiding this comment

lmazuel Sep 11, 2018

Choose a reason for hiding this comment

blueww Sep 12, 2018

Choose a reason for hiding this comment

lmazuel commented Sep 11, 2018

AutorestCI commented Sep 11, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Sep 11, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 11, 2018 • edited Loading

Automation for azure-sdk-for-node

lmazuel Sep 11, 2018

Choose a reason for hiding this comment

lmazuel Sep 11, 2018

Choose a reason for hiding this comment

blueww commented Sep 12, 2018

blueww commented Sep 13, 2018

lmazuel Sep 13, 2018

Choose a reason for hiding this comment

blueww Sep 14, 2018

Choose a reason for hiding this comment

blueww commented Sep 14, 2018

lmazuel commented Sep 14, 2018

hassanbabaie commented Oct 6, 2018

blueww commented Oct 8, 2018

hassanbabaie commented Oct 8, 2018

blueww commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading