[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
suggested changes
Sep 13, 2018
| @@ -7,7 +7,7 @@ | |||
| <PackageId>Microsoft.Azure.Management.Storage</PackageId> | |||
| <Description>Microsoft Azure Management Storage Library</Description> | |||
| <AssemblyName>Microsoft.Azure.Management.Storage</AssemblyName> | |||
| <Version>8.1.0-preview</Version> | |||
| <Version>9.0.0-preview</Version> | |||
| <PackageTags>Microsoft Azure Storage management;Storage;Storage management;</PackageTags> | |||
| <PackageReleaseNotes>See https://aka.ms/asdotnetsdkchangelog for release notes.</PackageReleaseNotes> | |||
There was a problem hiding this comment.
Please update the changelog
There was a problem hiding this comment.
Fixed, now change log is updated.
| new Tuple<string, string, string>("Storage", "StorageAccounts", "2018-03-01-preview"), | ||
| new Tuple<string, string, string>("Storage", "Usages", "2018-03-01-preview"), | ||
| new Tuple<string, string, string>("Storage", "BlobContainers", "2018-07-01"), | ||
| new Tuple<string, string, string>("Storage", "ManagementPolicies", "2018-03-01-preview"), |
There was a problem hiding this comment.
Please ensure that one of the services is still preview
There was a problem hiding this comment.
Yes, ManagementPolicies feature is not supported in 2017-07-01 api version, and only supported in 2018-03-01-preview. So to keep the feature in SRP SDK, we add it from 2018-03-01-preview api version.
|
The swagger PR is merged, and I have updated this PR with merged swagger PR. |
|
Thanks for the help to review and merge it! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new storage account kind and fileaadintegration support to new api version 2017-08-01
Swagger PR: Azure/azure-rest-api-specs#3864, still in review.
This is generated from my personal repo, send this for an early review, to reduce the risk for release this in Ignite. I will update the SDK when swagger PR merged (should not have much code change).
There's breaking change so upgrade version to 9.0. See details below.
This checklist is used to make sure that common guidelines for a pull request are followed.
Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.
Since the Management Policy not supported in 2018-07-01 (only support on 2018-03-01-preview), I also add it to SDK SRP but with different Opeartion ID (per suggestion of lmazuel). This is breaking.The Global Usage also removed, since will not support in new api versions (as location usage added).I have upgrade SDK version to 9.0 for the breaking change.General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.