[Datafactory]Adding get Dataplane access API #3957

hvermis · 2018-09-19T19:31:05Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-19T19:31:22Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#543

AutorestCI · 2018-09-19T19:32:22Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-09-19T19:32:45Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3648

AutorestCI · 2018-09-19T19:33:09Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-19T19:39:13Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

AutorestCI · 2018-09-19T19:39:28Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3360

azuresdkci · 2018-09-19T19:41:14Z

Can one of the admins verify this patch?

hvermis · 2018-09-20T01:08:35Z

Please review but do not merge yet. We want to get ARM team's review on this API.

ravbhatnagar · 2018-10-02T20:58:31Z

Looks good. Signing off from ARM.

hvermis · 2018-10-02T21:00:06Z

I need to make more changes for this, please hold off the merge

marstr · 2018-10-10T21:00:22Z

What's the status of this PR?

hvermis · 2018-11-07T03:50:01Z

@marstr we have made updates to the API and are ready to merge, can you please review again?

marstr · 2018-11-11T20:27:23Z

I'm no longer in the Swagger Review pool, I've marked this PR for reassignment.

hvermis · 2018-11-20T19:02:32Z

@arangan12, @anuchandy This PR has been reassigned for long time - can one of you review it please?

hvermis · 2018-11-20T20:06:58Z

@sarangan12

anuchandy · 2018-11-20T21:25:15Z

Had offline conversation with @hvermis. The work-item to add examples for existing operations are in the backlog (see Model Validator result).

@hvermis I will create a GitHub issue to track this from spec side as well and tag you.

anuchandy · 2018-11-19T05:29:42Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+          "type": "string"
+        }
+      }
+    },


Since this model is only used as response, we could mark properties as readonly

Adding get Dataplane readonly token API

bd07c0c

azuresdkci assigned marstr Sep 19, 2018

azuresdkci requested a review from marstr September 19, 2018 19:42

Updated the casing and the example

19c65d6

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 20, 2018

marstr approved these changes Sep 20, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2018

hvermis changed the title ~~Adding get Dataplane readonly token API~~ [Do not merge]Adding get Dataplane readonly token API Oct 2, 2018

marstr added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 2, 2018

hvermis added 3 commits November 6, 2018 16:50

Updating dataplane access APIs

cde33e6

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

dd7057a

Updating examples

066ef32

hvermis changed the title ~~[Do not merge]Adding get Dataplane readonly token API~~ [Datafactory]Adding get Dataplane access API Nov 7, 2018

This was referenced Nov 7, 2018

[AutoPR datafactory/resource-manager] [Do not merge]Adding get Dataplane readonly token API Azure/azure-sdk-for-go#3251

Closed

[AutoPR datafactory/resource-manager] [Do not merge]Adding get Dataplane readonly token API Azure/azure-sdk-for-js#423

Closed

hvermis removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 7, 2018

marstr added the Reassign label Nov 11, 2018

marstr removed their assignment Nov 11, 2018

azuresdkci assigned sarangan12 Nov 11, 2018

azuresdkci requested a review from sarangan12 November 11, 2018 20:31

azuresdkci assigned anuchandy and unassigned sarangan12 Nov 13, 2018

azuresdkci requested a review from anuchandy November 13, 2018 21:43

anuchandy approved these changes Nov 20, 2018

View reviewed changes

anuchandy merged commit c93ec80 into Azure:master Nov 20, 2018

This was referenced Nov 20, 2018

[AutoPR datafactory/resource-manager] [Datafactory]Adding get Dataplane access API Azure/azure-sdk-for-go#3359

Merged

[AutoPR datafactory/resource-manager] [Datafactory]Adding get Dataplane access API Azure/azure-sdk-for-js#543

Closed

meiyan-Li mentioned this pull request Dec 8, 2018

[Azure Data Factory] Adding refresh and get IntegrationRuntimeObjectMetadata API #4724

Merged

5 tasks

meiyan-Li mentioned this pull request Jan 15, 2019

[Azure Data Factory] Generate new SDK Azure/azure-sdk-for-net#5142

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Datafactory]Adding get Dataplane access API #3957

[Datafactory]Adding get Dataplane access API #3957

hvermis commented Sep 19, 2018

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

azuresdkci commented Sep 19, 2018

hvermis commented Sep 20, 2018

ravbhatnagar commented Oct 2, 2018

hvermis commented Oct 2, 2018

marstr commented Oct 10, 2018

hvermis commented Nov 7, 2018

marstr commented Nov 11, 2018

hvermis commented Nov 20, 2018

hvermis commented Nov 20, 2018

anuchandy commented Nov 20, 2018

anuchandy Nov 19, 2018

[Datafactory]Adding get Dataplane access API #3957

[Datafactory]Adding get Dataplane access API #3957

Conversation

hvermis commented Sep 19, 2018

PR information

Quality of Swagger

AutorestCI commented Sep 19, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Sep 19, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 19, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Sep 19, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 19, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 19, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Sep 19, 2018

hvermis commented Sep 20, 2018

ravbhatnagar commented Oct 2, 2018

hvermis commented Oct 2, 2018

marstr commented Oct 10, 2018

hvermis commented Nov 7, 2018

marstr commented Nov 11, 2018

hvermis commented Nov 20, 2018

hvermis commented Nov 20, 2018

anuchandy commented Nov 20, 2018

anuchandy Nov 19, 2018

Choose a reason for hiding this comment

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading

AutorestCI commented Sep 19, 2018 •

edited

Loading