Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Data Factory] Generate new SDK #5142

Merged
merged 3 commits into from
Jan 17, 2019
Merged

Conversation

meiyan-Li
Copy link
Contributor

@meiyan-Li meiyan-Li commented Jan 15, 2019

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@@ -61,18 +60,5 @@ public StoredProcedureParameter(object value, string type = default(string))
[JsonProperty(PropertyName = "type")]
public string Type { get; set; }

/// <summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. Needs a major version bump,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How to do major version bump? Any documents I can refer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the versioning guidelines we follow.
Essentially the Nuget version must be set to 3.0.0. Please make sure to update the AssemblyInfo.cs file too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Deepak. Updated to 3.0.0

@dsgouda
Copy link
Contributor

dsgouda commented Jan 16, 2019

@meiyan-Li How was this code generated, did you use a generate.ps1 script?

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from versioning

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,6 +1,20 @@
# Changelog for the Azure Data Factory V2 .NET SDK

## Current version
## Version 3.0.0

### Feature Additions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the names of activities to be upper case and fix some other casings - Delete activity, Validation activity, Exposure Control API-s, SSIS, WinAuth

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meiyan-Li I will fix these once @dsgouda merges this PR.

<AssemblyName>Microsoft.Azure.Management.DataFactory</AssemblyName>
<PackageTags>Microsoft Azure resource management;Data Factory;ADF;</PackageTags>
<PackageReleaseNotes>Taking dependency on 10.0.3 version of Newtonsoft nuget package.</PackageReleaseNotes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the white spaces and fix casing here as well. These notes will be the release notes for the new nuget package.

@hvermis
Copy link
Contributor

hvermis commented Jan 17, 2019

@dsgouda Can you please merge this PR? I will update the release notes once you merge this so I can start our release.

@dsgouda dsgouda merged commit f0a1c90 into Azure:psSdkJson6 Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants