Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Data Factory] Add winauth support in SSIS Activity #5031

Merged
merged 9 commits into from
Jan 14, 2019
Merged

[Azure Data Factory] Add winauth support in SSIS Activity #5031

merged 9 commits into from
Jan 14, 2019

Conversation

meiyan-Li
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Jan 14, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from dsgouda January 14, 2019 02:43
@AutorestCI AutorestCI mentioned this pull request Jan 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI AutorestCI mentioned this pull request Jan 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3865

@AutorestCI AutorestCI mentioned this pull request Jan 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 14, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

@AutorestCI AutorestCI mentioned this pull request Jan 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 14, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4190

@AutorestCI AutorestCI mentioned this pull request Jan 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 14, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

@meiyan-Li
Copy link
Contributor Author

@hvermis Could you please help review this PR? Thanks!

nschonni
nschonni reviewed Jan 14, 2019
View reviewed changes
.../resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json
"description": "SSIS package execution credential.",
"properties": {
"domain": {
"type": "object",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be object, as we need support string or expression.

.../resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json
"description": "Domain for windows authentication."
},
"userName": {
"type": "object",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
"description": "SSIS package execution credential.",
"properties": {
"domain": {
"type": "object",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
"description": "Domain for windows authentication."
},
"userName": {
"type": "object",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

dsgouda
dsgouda approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 31a6f06 into Azure:master Jan 14, 2019
@meiyan-Li meiyan-Li mentioned this pull request Jan 15, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@meiyan-Li @AnuTalluri
[Azure Data Factory] Add winauth support in SSIS Activity (Azure#5031)
b55b7e9 
* Adding refresh and get IntegrationRuntimeObjectMetadata API

* Change ssis to upper case

* Fix model validation issue

* Adding refresh and get IntegrationRuntimeObjectMetadata API

* Change ssis to upper case

* Fix model validation issue

* Winauth Support in SSIS Activity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meiyan-Li @AutorestCI @azuresdkci @nschonni @dsgouda