Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support two apiversion for container service #4237

Merged
merged 20 commits into from
Oct 19, 2018

Conversation

zqingqing1
Copy link
Member

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3378

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#253

@azuresdkci azuresdkci requested a review from annatisch October 15, 2018 21:31
@annatisch annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 15, 2018
@annatisch
Copy link
Member

Adding @ravbhatnagar for ARM review of new API version.

@zqingqing1 - the changes you made to the readme have removed the OpenShiftManagedClusters spec - was this intentional?

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3089

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3875

@zqingqing1
Copy link
Member Author

@annatisch , thanks for reminding, it should be included.

@zqingqing1
Copy link
Member Author

Hi, @annatisch @ravbhatnagar please help to review :)

@annatisch
Copy link
Member

@zqingqing1 - please address the model validation errors in the CI:

error:
operationId: ManagedClusters_List
scenario: List Managed Clusters
source: response
responseCode: '200'
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  message: 'Additional properties not allowed: storageProfile'

error:
operationId: ManagedClusters_ListByResourceGroup
scenario: Get Managed Clusters by Resource Group
source: response
responseCode: '200'
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  message: 'Additional properties not allowed: storageProfile'

error:
operationId: ManagedClusters_Get
scenario: Get Managed Cluster
source: response
responseCode: '200'
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  message: 'Additional properties not allowed: storageProfile'

error:
operationId: ManagedClusters_CreateOrUpdate
scenario: Create/Update Managed Cluster
source: response
responseCode: '200'
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  message: 'Additional properties not allowed: storageProfile'

error:
operationId: ManagedClusters_CreateOrUpdate
scenario: Create/Update Managed Cluster
source: response
responseCode: '201'
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  message: 'Additional properties not allowed: storageProfile'

error:
operationId: ManagedClusters_UpdateTags
scenario: Update Managed Cluster Tags
source: response
responseCode: '200'
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  message: 'Additional properties not allowed: storageProfile'

@@ -179,58 +179,6 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/accessProfiles/{roleName}/listCredential": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be deprecation of an API from a stable version. Do you have a deprecation policy in place? Has this been communicated?

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments on API deprecation

@zqingqing1
Copy link
Member Author

@annatisch @KrisBash error has been address, can you review again?

@zqingqing1
Copy link
Member Author

@KrisBash , I just saw your comments about api deprecation from email. Not sure why I cannot see the comments here. Anyway, for your question:

@@ -179,58 +179,6 @@
}
}
},

  • "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/accessProfiles/{roleName}/listCredential": {
    This appears to be deprecation of an API from a stable version. Do you have a deprecation policy in place? Has this been communicated?

No, right now we don't have the deprecation policy. This is a long-term work item, and needs extra discussion with PM team. For now, we just keep it there.

@zqingqing1
Copy link
Member Author

@annatisch @KrisBash @jhendrixMSFT, I am blocked by this. Can anyone of you help to merge the PR? Thanks in advance.

@annatisch
Copy link
Member

@zqingqing1 - the PR name implies that you wish to support two api versions - yet the readme changes do no reflect this. What is your intention here?

@zqingqing1
Copy link
Member Author

Synced up with @lmazuel before, after this PR gets merged, he will help to support both apiversion for Azure-SDK-for-Python.

@annatisch
Copy link
Member

Thanks @zqingqing1 - I see you've removed the property "storageProfile" from ManagedClusterAgentPoolProfile and made "count" a required property. This would be a breaking change in the generated SDKs and would require a major version bump - is this your intention?

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor things :)

@zqingqing1
Copy link
Member Author

@annatisch , I changed the tag back to 2018-09-30-preview, so it won't break generated SDK. Meanwhile, After PR merged, @lmazuel can help to support multi api version for SDK-for-python.

@zqingqing1 zqingqing1 closed this Oct 19, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@annatisch
Copy link
Member

annatisch commented Oct 19, 2018

Thanks @zqingqing1 - I see be reverting the tag back to 2018-09-30-preview this means that your new spec is excluded from the generated clients for now. Is this to mitigate the breaking changes until you are ready for a major version bump?

@zqingqing1
Copy link
Member Author

@annatisch , yes.

@annatisch
Copy link
Member

Thanks @zqingqing1 - This will result in your new public API not being available in other SDKs.

Adding multi-api support only affects Python - whereas reverting the tag will make the public API not available in other languages. If this API is live and public, the SDK generation tags should reflect this and then you can work further with @lmazuel around the specifics of the Python release.

@annatisch annatisch merged commit 6a54671 into Azure:master Oct 19, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants