fix Go SDK codegen for containerservices #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
vladbarosan
approved these changes
Oct 19, 2018
jhendrixMSFT
added a commit
to zqingqing1/azure-rest-api-specs
that referenced
this pull request
Oct 19, 2018
annatisch
pushed a commit
that referenced
this pull request
Oct 19, 2018
* add 2018-08-01-preview * modify readme to support 2 api version for python * change back multp-api, use new api * remove accessprofile and getaccessprofile api, add autoscaler and vmss datamodel * format change to enum * add osMC resource in the readme * modify the example json files * add listcredential api back * fix Go SDK codegen * correct typo and remove default for agentpooltype * change default tag to 2018-09-30-preview * fix Go SDK codegen for containerservices (#4296) * try to put both api in the 2018-08-preview tag * both api in same tag, not working, revert back * udpate tag to lastest version
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
* New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * Add base version of swagger spec * Add "graphService" to custom-words.txt for spellCheck * Add changes made by prettier * Add openapi-subtype and fixed avocado inconsistent api version * Add Create resource example to spec * Fix example url * Add provisioningState and long running ops params to resources * Fix semantic validation for provisioningState * Fix model validation for Create resource example * Run prettier * Remove async fields from create resource * Change create to 201 for long running operation * Changed paths to camelCase * Add default error responses * Add object types and x-ms-pageable * Add systemData to resources * Add list extension resources by subscription * add standard operation and operationList definitions referenced from common-types * Remove double underscore from operation names * change name to resource type for model validation and avocado run prettier * Change example file name * Remove 'required' from patch request bodies * Add operation examples and implement delete example * Add delete example to resource * Add Get example to resource * Add List examples for resource * Add update resource example * Change response code for examples * Remove extension and nested resources * Fix update example params * Add operations list example * Remove Extension and Nested resource definitions * Add -privatepreview suffix * Change suffix in readme and examples * Remove ErrorResponse duplicate definition * Change example resource payload name to BillableAzureAdApplication * Change delete to long running operation * Change operation id names to start with mayus. Conflict with ApiDocPreview * Change x-ms-example names to reflect actual operation * remove go and azcli sdk generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger