Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix public swagger issues #6396

Merged
merged 10 commits into from
Jun 26, 2019
Merged

fix public swagger issues #6396

merged 10 commits into from
Jun 26, 2019

Conversation

Yiliu-microsoft
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 76032c5)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5143

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hvermis
Copy link
Contributor

hvermis commented Jun 20, 2019

All types being removed here are new, they have not been released in any of the SDKs yet. They are being removed as we found issues with them. Please help getting this PR in as soon as possible to expedite our SDK release.

@hvermis
Copy link
Contributor

hvermis commented Jun 20, 2019

@shahabhijeet FYI

@hvermis
Copy link
Contributor

hvermis commented Jun 20, 2019

@sergey-shandar Can you please merge this as soon as you can? It's blocking our our SDK release.

@sergey-shandar sergey-shandar added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 24, 2019
@hvermis
Copy link
Contributor

hvermis commented Jun 25, 2019

@sergey-shandar FYI, The types and properties being removed here have not been released in any SDKs yet.

@zhangyd2015
Copy link
Contributor

@sergey-shandar This PR is actually a critical bugfix, which fixed the bugs introduced in previous PR, so basically it is not breaking change, and no customer is using it. The SDK build is blocked by this bug.

@hvermis
Copy link
Contributor

hvermis commented Jun 26, 2019

@sergey-shandar How can we expedite the review for this PR?

@nschonni
Copy link
Contributor

@hvermis from the PR template

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on [API review process](https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderOnboardingAPIRevieworkflow.html).

@ravbhatnagar
Copy link
Contributor

As per comment from @hvermis, the properties being removed were accidently added. They have not been released in any SDK. So, it will not be breaking change for any customer. Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2019
@sergey-shandar sergey-shandar merged commit a0dc416 into Azure:master Jun 26, 2019
@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
This was referenced Jun 28, 2019
Merged
Closed
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@Yiliu-microsoft @celikcigdem
fix public swagger issues (Azure#6396)
404f1eb 
* Modify the public swagger by reference to private swagger

* modify swagger

* Change XxxSetting to XxxSettings in private swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Assignees

@sergey-shandar sergey-shandar

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Yiliu-microsoft @AutorestCI @azuresdkci @hvermis @zhangyd2015 @nschonni @ravbhatnagar @sergey-shandar