Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory]SDK for Object Type and Readsettings name change #6743

Merged
merged 3 commits into from
Jul 3, 2019
Merged

[DataFactory]SDK for Object Type and Readsettings name change #6743

merged 3 commits into from
Jul 3, 2019

Conversation

wenbof-zz
Copy link

SDK generated based on the swagger change: Azure/azure-rest-api-specs#6396

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your project has been excluded from build.


Either delete that property or set it to false.

Similarly check your test project and make sure they are set to build and execute tests.
This test was excluded because it was failing to build and execute tests.

@wenbof-zz
Copy link
Author

Your project has been excluded from build.

  azure-sdk-for-net/sdk/datafactory/Microsoft.Azure.Management.DataFactory/src/Microsoft.Azure.Management.DataFactory.csproj


     Line 28
  in
  4cd52b6





    
      
       <ExcludeFromBuild>True</ExcludeFromBuild> 

Either delete that property or set it to false.
Similarly check your test project and make sure they are set to build and execute tests.
This test was excluded because it was failing to build and execute tests.
Updated. Thanks. also updated ExcludeFromTest of test project to false which I assume that needs to be updated as well.

@wenbof-zz wenbof-zz closed this Jul 1, 2019
@wenbof-zz wenbof-zz reopened this Jul 1, 2019
@hvermis
Copy link
Contributor

hvermis commented Jul 1, 2019

@wenbof Please also update the changes in


And also make this:
True
into
False

@hvermis
Copy link
Contributor

hvermis commented Jul 1, 2019

@wenbof My previous comment doesn't show up properly. It was about this line:

The true should be changed to false here.

@hvermis
Copy link
Contributor

hvermis commented Jul 1, 2019

@wenbof please add serialization samples for all the types for below changes:

  1. Added support for the following new datasets in ADF - ParquetDataset, DelimitedTextDataset, SapTableResourceDataset
  2. Added a new property dataProxyProperties to Integration Runtime
  3. Added new SapTable Linked Services type

And at least one of each for below changes:

  1. Added types for Read and Write Connector settings in activities - AzureBlobStorageReadSetting, AzureBlobFSReadSetting, AzureDataLakeStoreReadSetting, AmazonS3ReadSetting, FileServerReadSetting, FtpReadSetting, SftpReadSetting, HttpReadSetting, HdfsReadSetting,
    AzureBlobStorageWriteSetting, AzureBlobFSWriteSetting, AzureDataLakeStoreWriteSetting, FileServerWriteSetting, FormatReadSetting, DelimitedTextReadSetting, FormatWriteSetting, DelimitedTextWriteSetting
  2. Added new Copy sources - SapTableSource, SqlServerSource, AzureSqlSource
  3. Added new Copy sinks - ParquetSink, SqlServerSink, AzureSqlSink

Copy link
Contributor

@hvermis hvermis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet Can you please verify that builds have Datafactory project now and merge this?

@shahabhijeet shahabhijeet merged commit 412049f into Azure:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants