-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Sql to add WorkloadGroups and WorkloadClasifiers to API 2019-06-01-preview #7349
Merged
yaohaizh
merged 15 commits into
Azure:master
from
H-Huang:dev-sql-Microsoft.Sql-2019-06-01-preview
Nov 27, 2019
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9f1e16b
Adds base for updating Microsoft.Sql from version preview/2018-06-01-…
H-Huang da0f89f
Updates readme
H-Huang ed9f7aa
Updates API version in new specs and examples
H-Huang 6096c86
Added workload group / workload classifiers to package tags with incl…
H-Huang fa5597b
Undoing the files that were copied over from 2018-06-01-preview folder
H-Huang 1976a78
Fix linter error for invalid tag
H-Huang 4d76561
updated create or update classifier example with missing field
H-Huang 3a4cdf3
updated examples with correct types, correct workload classifiers to …
H-Huang 6b6722c
modified example resource groups to correct value
H-Huang 286dee1
update types to WorkloadGroups and WorkloadClassifiers
H-Huang f947234
Merge branch 'master' of https://github.com/Azure/azure-rest-api-spec…
H-Huang 4e1c6d6
update readme.md with correct types
H-Huang 8bc7918
merge with master
H-Huang 983daf3
update workload group and workload classifier mutability
H-Huang 9a19e2d
fix typos in error responses
H-Huang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
460 changes: 460 additions & 0 deletions
460
...on/sql/resource-manager/Microsoft.Sql/preview/2019-06-01-preview/WorkloadClassifiers.json
Large diffs are not rendered by default.
Oops, something went wrong.
439 changes: 439 additions & 0 deletions
439
...ication/sql/resource-manager/Microsoft.Sql/preview/2019-06-01-preview/WorkloadGroups.json
Large diffs are not rendered by default.
Oops, something went wrong.
54 changes: 54 additions & 0 deletions
54
...icrosoft.Sql/preview/2019-06-01-preview/examples/CreateOrUpdateWorkloadClassifierMax.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "wlm_workloadgroup", | ||
| "workloadClassifierName": "wlm_workloadclassifier", | ||
| "api-version": "2019-06-01-preview", | ||
| "parameters": { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "test_label", | ||
| "context": "test_context", | ||
| "startTime": "12:00", | ||
| "endTime": "14:00", | ||
| "importance": "high" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "test_label", | ||
| "context": "test_context", | ||
| "startTime": "12:00", | ||
| "endTime": "14:00", | ||
| "importance": "high" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/wlm_workloadclassifier", | ||
| "name": "wlm_workloadclassifier", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "test_label", | ||
| "context": "test_context", | ||
| "startTime": "12:00", | ||
| "endTime": "14:00", | ||
| "importance": "high" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/wlm_workloadclassifier", | ||
| "name": "wlm_workloadclassifier", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| } | ||
| }, | ||
| "202": {} | ||
| } | ||
| } | ||
49 changes: 49 additions & 0 deletions
49
...icrosoft.Sql/preview/2019-06-01-preview/examples/CreateOrUpdateWorkloadClassifierMin.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "wlm_workloadgroup", | ||
| "workloadClassifierName": "wlm_workloadclassifier", | ||
| "api-version": "2019-06-01-preview", | ||
| "parameters": { | ||
| "properties": { | ||
| "memberName": "dbo" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "", | ||
| "context": "", | ||
| "startTime": "", | ||
| "endTime": "", | ||
| "importance": "" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/wlm_workloadclassifier", | ||
| "name": "wlm_workloadclassifier", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "", | ||
| "context": "", | ||
| "startTime": "", | ||
| "endTime": "", | ||
| "importance": "" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/wlm_workloadclassifier", | ||
| "name": "wlm_workloadclassifier", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| } | ||
| }, | ||
| "202": {} | ||
| } | ||
| } |
53 changes: 53 additions & 0 deletions
53
...ger/Microsoft.Sql/preview/2019-06-01-preview/examples/CreateOrUpdateWorkloadGroupMax.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "smallrc", | ||
| "api-version": "2019-06-01-preview", | ||
| "parameters": { | ||
| "properties": { | ||
| "minResourcePercent": 0, | ||
| "maxResourcePercent": 100, | ||
| "minResourcePercentPerRequest": 3.0, | ||
| "maxResourcePercentPerRequest": 3.0, | ||
| "importance": "normal", | ||
| "queryExecutionTimeout": 0 | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "minResourcePercent": 0, | ||
| "maxResourcePercent": 100, | ||
| "minResourcePercentPerRequest": 3.0, | ||
| "maxResourcePercentPerRequest": 3.0, | ||
| "importance": "normal", | ||
| "queryExecutionTimeout": 0 | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/smallrc", | ||
| "name": "smallrc", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "properties": { | ||
| "minResourcePercent": 0, | ||
| "maxResourcePercent": 100, | ||
| "minResourcePercentPerRequest": 3.0, | ||
| "maxResourcePercentPerRequest": 3.0, | ||
| "importance": "normal", | ||
| "queryExecutionTimeout": 0 | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/smallrc", | ||
| "name": "smallrc", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups" | ||
| } | ||
| }, | ||
| "202": {} | ||
| } | ||
| } |
50 changes: 50 additions & 0 deletions
50
...ger/Microsoft.Sql/preview/2019-06-01-preview/examples/CreateOrUpdateWorkloadGroupMin.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "smallrc", | ||
| "api-version": "2019-06-01-preview", | ||
| "parameters": { | ||
| "properties": { | ||
| "minResourcePercent": 0, | ||
| "maxResourcePercent": 100, | ||
| "minResourcePercentPerRequest": 3.0 | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "minResourcePercent": 0, | ||
| "maxResourcePercent": 100, | ||
| "minResourcePercentPerRequest": 3.0, | ||
| "maxResourcePercentPerRequest": 3.0, | ||
| "importance": "normal", | ||
| "queryExecutionTimeout": 0 | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/smallrc", | ||
| "name": "smallrc", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "properties": { | ||
| "minResourcePercent": 0, | ||
| "maxResourcePercent": 100, | ||
| "minResourcePercentPerRequest": 3.0, | ||
| "maxResourcePercentPerRequest": 3.0, | ||
| "importance": "normal", | ||
| "queryExecutionTimeout": 0 | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/smallrc", | ||
| "name": "smallrc", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups" | ||
| } | ||
| }, | ||
| "202": {} | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
...e-manager/Microsoft.Sql/preview/2019-06-01-preview/examples/DeleteWorkloadClassifier.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "wlm_workloadgroup", | ||
| "workloadClassifierName": "wlm_workloadclassifier", | ||
| "api-version": "2019-06-01-preview" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": {}, | ||
| "204": {} | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
...source-manager/Microsoft.Sql/preview/2019-06-01-preview/examples/DeleteWorkloadGroup.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "wlm_workloadgroup", | ||
| "api-version": "2019-06-01-preview" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": {}, | ||
| "204": {} | ||
| } | ||
| } |
28 changes: 28 additions & 0 deletions
28
...urce-manager/Microsoft.Sql/preview/2019-06-01-preview/examples/GetWorkloadClassifier.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "wlm_workloadgroup", | ||
| "workloadClassifierName": "wlm_classifier", | ||
| "api-version": "2019-06-01-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "test_label", | ||
| "context": "test_context", | ||
| "startTime": "12:00", | ||
| "endTime": "14:00", | ||
| "importance": "high" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/wlm_classifier", | ||
| "name": "wlm_classifier", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| } | ||
| } | ||
| } | ||
| } |
57 changes: 57 additions & 0 deletions
57
...-manager/Microsoft.Sql/preview/2019-06-01-preview/examples/GetWorkloadClassifierList.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "wlm_workloadgroup", | ||
| "api-version": "2019-06-01-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "", | ||
| "context": "", | ||
| "startTime": "", | ||
| "endTime": "", | ||
| "importance": "high" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/classifier3", | ||
| "name": "classifier3", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| }, | ||
| { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "test_label", | ||
| "context": "test_context", | ||
| "startTime": "12:00", | ||
| "endTime": "14:00", | ||
| "importance": "high" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/classifier1", | ||
| "name": "classifier1", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| }, | ||
| { | ||
| "properties": { | ||
| "memberName": "dbo", | ||
| "label": "", | ||
| "context": "", | ||
| "startTime": "11:00", | ||
| "endTime": "17:00", | ||
| "importance": "high" | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/wlm_workloadgroup/workloadClassifiers/classifier2", | ||
| "name": "classifier2", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups/workloadClassifiers" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
27 changes: 27 additions & 0 deletions
27
.../resource-manager/Microsoft.Sql/preview/2019-06-01-preview/examples/GetWorkloadGroup.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "Default-SQL-SouthEastAsia", | ||
| "serverName": "testsvr", | ||
| "databaseName": "testdb", | ||
| "workloadGroupName": "smallrc", | ||
| "api-version": "2019-06-01-preview" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "minResourcePercent": 0, | ||
| "maxResourcePercent": 100, | ||
| "minResourcePercentPerRequest": 3.0, | ||
| "maxResourcePercentPerRequest": 3.0, | ||
| "importance": "normal", | ||
| "queryExecutionTimeout": 0 | ||
| }, | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/servers/testsvr/databases/testdb/workloadGroups/smallrc", | ||
| "name": "smallrc", | ||
| "type": "Microsoft.Sql/servers/databases/workloadGroups" | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swagger & ARM team reviewers, what is the guidance for exposing "time of day" (i.e. just time, not date+time)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.