Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Sql to add WorkloadGroups and WorkloadClasifiers to API 2019-06-01-preview #7349

Merged
merged 15 commits into from
Nov 27, 2019
Merged

[Hub Generated] Review request for Microsoft.Sql to add WorkloadGroups and WorkloadClasifiers to API 2019-06-01-preview #7349

merged 15 commits into from
Nov 27, 2019

Conversation

H-Huang
Copy link
Contributor

@H-Huang H-Huang commented Sep 27, 2019 •
edited
Loading

Workload Management

Adding new WorkloadGroups.json and WorkloadClassifiers.json swagger files and their examples. These are also part of a new API version 2019-06-01-preview.

Workload groups and workload classifiers are new objects in Azure SQL Data Warehouse which allow customer to manage their instance resources and workloads.

The new swagger files contain the CRUD operations which include

  • List the workload groups / workload classifiers
  • Get the workload groups / workload classifiers
  • Create or update the workload groups / workload classifiers
  • Delete the workload groups / workload classifiers

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@H-Huang H-Huang requested a review from jaredmoo as a code owner September 27, 2019 18:25
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 27, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 4e1c6d6, Iteration 10)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@H-Huang H-Huang added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 27, 2019
@azuresdkci azuresdkci requested a review from yaohaizh September 27, 2019 18:26
@AutorestCI AutorestCI mentioned this pull request Sep 27, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8720

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6438

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@H-Huang H-Huang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 28, 2019
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 28, 2019
Closed
@yaohaizh
Copy link
Contributor

@H-Huang some examples are ill-formated. https://dev.azure.com/azure-sdk/public/_build/results?buildId=119412&view=logs&jobId=8c9a658c-6596-5897-87e8-abb327497d15

@yaohaizh
Copy link
Contributor

@jaredmoo please help review this PR as the code owner. Thanks for your help a lot.

@ryansbenson ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 1, 2019
@H-Huang H-Huang requested a review from ryansbenson October 2, 2019 17:14
@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 25, 2019
Closed
This was referenced Oct 25, 2019
Open
Closed
@ArcturusZhang ArcturusZhang mentioned this pull request Oct 29, 2019
Merged
@AutorestCI AutorestCI mentioned this pull request Nov 11, 2019
Closed
@H-Huang H-Huang changed the title [Hub Generated] Review request for Microsoft.Sql to add version preview/2019-06-01-preview [Hub Generated] Review request for Microsoft.Sql to add WorkloadGroups and WorkloadClasifiers to API 2019-06-01-preview Nov 12, 2019
@H-Huang H-Huang removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 12, 2019
@H-Huang H-Huang requested a review from beoberha November 12, 2019 18:42
jaredmoo
jaredmoo reviewed Nov 14, 2019
View reviewed changes
...r/Microsoft.Sql/preview/2019-06-01-preview/examples/CreateOrUpdateWorkloadClassifierMax.json
"memberName": "dbo",
"label": "test_label",
"context": "test_context",
"startTime": "12:00",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swagger & ARM team reviewers, what is the guidance for exposing "time of day" (i.e. just time, not date+time)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swagger & ARM team reviewers, what is the guidance for exposing "time of day" (i.e. just time, not date+time)?
@ryansbenson, what is the suggestion here?

@yaohaizh yaohaizh merged commit 07d864d into Azure:master Nov 27, 2019
This was referenced Nov 27, 2019
Closed
Merged
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@H-Huang @AnuTalluri
[Hub Generated] Review request for Microsoft.Sql to add WorkloadGroup…
8bfc018 
…s and WorkloadClasifiers to API 2019-06-01-preview (Azure#7349)

* Adds base for updating Microsoft.Sql from version preview/2018-06-01-preview to version 2019-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Added workload group / workload classifiers to package tags with included examples

* Undoing the files that were copied over from 2018-06-01-preview folder

* Fix linter error for invalid tag

* updated create or update classifier example with missing field

* updated examples with correct types, correct workload classifiers to save with encoding UTF-8

* modified example resource groups to correct value

* update types to WorkloadGroups and WorkloadClassifiers

* update readme.md with correct types

* update workload group and workload classifier mutability

* fix typos in error responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamestao jamestao jamestao left review comments

@yaohaizh yaohaizh yaohaizh approved these changes

@jaredmoo jaredmoo jaredmoo approved these changes

@ryansbenson ryansbenson Awaiting requested review from ryansbenson

@beoberha beoberha Awaiting requested review from beoberha

Assignees

@yaohaizh yaohaizh

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@H-Huang @AutorestCI @azuresdkci @yaohaizh @jamestao @jaredmoo @ryansbenson