[AutoPR sql/resource-manager/v2014_04_01] [Hub Generated] Review request for Microsoft.Sql to add version preview/2019-06-01-preview #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
…izer. Add EventHubClient.getEventHubName (#5474) * Add MessageSerializer interface. * Update documentation in EventData. * Rename EventDataUtil -> EventHubMessageSerializer. * Exposing EventHubClient.getEventHubName() as public. * Remove ManagementResponseMapper and consolidate into MessageSerializer. * Removing static public method from EventHubMessageSerializer. * Fix build breaks when passing MessageSerializer to EventHubAsyncProducer. * Adding tests for EventHubMessageSerializer. Fixing NullPointerException. * Move MessageSerializer into azure-core-amqp.
* Add module-info to appconfig * Add license header * Add license header * Add exports to app config
update SB SDK to mention Management client functionality
* Move Reactor handlers into azure-core-amqp. * Move ReactorDispatcher, AmqpErrorCode to azure-core-amqp. * Add correct requires in module-info.java. * Moving implementation specific classes to azure-core-amqp. * Move tests into azure-core-amqp. * Use Mockito instead of concrete class. * Rename host to hostname. * Fix usages of FQDN.
* Fixed the setter and getter method * Remvoe setter
…he lease collection documents. (#5508)
* Fixed the setter and getter method
* Convert credential scopes param to TokenRequest * Fix build errors in event hubs * Change .block() to StepVerifier * Fix tests * checkstyle .* imports
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check * fix issue 5113
* Rename from values to getValues()
* Peering: generate 2019 08 01 preview * fix: compile error
* Throw better exceptions in chained token credentials * Fix checkstyle: line too long * Better error message in chained credential * Fix test after new error message
Added File Data Lake package files
* Remove unnessary changes * Added file and samples changes * Minor fix
* Clients and code samples for LeaseClients * Updated tests * Updating unit tests * Using builder pattern for LeaseClients * Fix unit tests * Cleaning up documentation * Fix linting issues and more unit tests * Some moving of clients * Moved test files into correct folder * Moved sub-blob clients to specialized namespace, added BlobBaseClients * Refactoring unit tests * More cleaning up * More cleaning up * Cleaning up linting issues * Addressing PR feedback * Cleaning up Spotbug and linting issues * Updated SpecializedBlobClientBuilder to be a full-fledged builder * Updating CPK variable name and moving specialized test classes to specialized package in test * Cleaning up tests and linting * Fix test order and added exception comment
* Update cosmos versions; up the minor build. * Hot fix version should be 3.2.1
* (Untested) Optimisation for RestProxy createResponse API. * Make the build happy * Introducing LambdaMetaFactory based response cache. * Making LambdaMetaFactory work for Java 9+ * Taking care of concurrent map race * Using singleton MethodType & Signature, using specialized types in function interfaces, replacing Stream with basic loop. * Using singleton MethodHandles.Lookup, adding JMH benchmark for MetaFactory/Reflection * Accomodating removal of core VoidResponse * Adding bench mark for reflection non-cached case * address checkstyle violations in BenchMark tests
* Fix errors caused by upgrading to latest reactor versions * Update netty version to fix failures on linux
* Storage: update 2019 04 01 * Storage: update pom
* Preview 4 change log * Add README and samples for user auth * Add 1.0.0 change log * Change date & Add known issues
* Enable exponential backoff for retry policy in http pipeline * Fix checkstyle * minor refactoring * Update testcases * Update retry policy based on PR feedback * Fix javadoc
* Update documentation in exceptions. * Update documentation in HTTP classes. * Update documentation in policies. * Adding headers to PagedFlux * Update documentation and snippets in PagedFluxBase.
* Fix documentation * fix package name
#5943) * Added UTF-8 encoding for blob names in methods that are used to build blob clients or manipulate blobs. Also added documentation where blob names are part of the flow so that the user knows what is happening in case they are thinking of passing an already encoded name. * Added missing comments about encryption to the Javadoc of some classes. Removed the use of the Utility.urlEncoder() in a couple methods where it was not necessary and would actually cause double encoding. Added one use of said method to BlobAsyncClient. * Changed a few couple Groovy tests that were failing because the expected session records did not account for the newly added encoding * Removed a call to Utility.urlEncode() in BLobContainerAsyncClient that would make blob URLs to be encoded twice. * Broke a couple lines in BlobBatch into two parts to comply with the code style guidelines. * Added missing space to a line in BlobBatch. It was flagged by the CI style checker. * Fixed an issue that made some test cases fail: blobName needs to be encoded when putting together the blobUrl that is passed as a a constructor argument for specialized blob clients. Added blobName decoding before encoding it so that if users pass encoded names we can properly deal with them; little to no overhead was added by this. * Made sure that blob names are decoded from UTF-8 before being returned by getters and modified certain builders to account for this. Added encoding for setting the blobName in BlobServiceSasSignatureValues. Modified and added tests to account for encoding and added the generated session records as well. Corrected a test that did not compile on BlockBlobAPITest. * Because we are doing encoding blob names implicitly, there is no point in telling the user we are doing this, so I removed parts of the Javadoc that referenced the fact. For the sake of clarity, I added the the Javadoc in blob name getters so that users know the returned blob name will always be decoded (it's possible they set an encoded name and expect to see the same value from the get method). Also added a clarification that states blob names must be encoded to UTF-8 to the Javadoc of methods that take blob URLs as an argument. * Made sure that the blobName used to generate a SAS signature is decoded. According to Rick Ley from the Storage team: "storage account name and the resource name must be URL-decoded".
This reverts commit b820645.
* Update Blobs download to return deserialized headers * Update Files download to return deserialized headers * Fix build and linting issue * Split response and reliable download into two classes * Fix linting issue, regenerated File swagger to move model class out of implementation * Updated tests to use deserialized headers and reverted accidental class renaming
* Fix naming for MSI credential. * Adding documentation to azure-identity. * Rename MSI -> Msi. * Clarifying documentation.
KV Keys and Secrets API updates
* generate overview from readme for javadocs * move the pip install of markdown2 into an unconditional step * open file with encoding on 2.x needs an import * update the file write to ensure unicode, works for vers 2 & 3 * Update for relative link replacement in readme files * Remove the failed linter experiment from pom.client.xml and update README.md
* readme and changelog text for GA *
Installation InstructionsYou can install the package Direct DownloadThe generated package artifacts can be directly downloaded from here: |
2 tasks
update readme.md with correct types
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/sql/resource-manager/v2014_04_01@7349
branch
from
9c1af9b to
ef71843
Compare
|
Hi @openapi-sdkautomation[bot]. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
2 similar comments
|
Hi @openapi-sdkautomation[bot]. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @openapi-sdkautomation[bot]. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @openapi-sdkautomation[bot]. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#7349