[AutoPR sql/resource-manager/v2014_04_01] [Hub Generated] Review request for Microsoft.Sql to add version preview/2019-06-01-preview

.azure-pipelines/docs.yml

@@ -11,10 +11,10 @@ jobs:
       skipComponentGovernanceDetection: true
     timeoutInMinutes: 120
     pool:
-      vmImage: 'vs2017-win2016'
+      vmImage: 'windows-2019'
 
     steps:
-      - powershell: |
+      - pwsh: |
           copy eng/repo-docs/index.html $(Build.ArtifactStagingDirectory)
         displayName: 'Copy index to artifact staging'
 
@@ -63,7 +63,7 @@ jobs:
           publishJUnitResults: false
           goals: 'install'
 
-      - powershell: |
+      - pwsh: |
           copy -r target/staging/apidocs $(Build.ArtifactStagingDirectory)/client
         displayName: 'Copy reports to artifact staging'
 
@@ -79,7 +79,7 @@ jobs:
       skipComponentGovernanceDetection: true
     timeoutInMinutes: 120
     pool:
-      vmImage: 'vs2017-win2016'
+      vmImage: 'windows-2019'
 
     steps:
       # We `install` separately from running `site:site site:stage` so that the `install` brings in the non-shipping-modules,
@@ -96,6 +96,18 @@ jobs:
           publishJUnitResults: false
           goals: 'install'
 
+      - task: Maven@3
+        displayName: 'Install azure-sdk-parent'
+        inputs:
+          mavenPomFile: parent/pom.xml
+          options: '$(DefaultOptions) -DskipTests -Dgpg.skip'
+          mavenOptions: '$(LoggingOptions)'
+          javaHomeOption: 'JDKVersion'
+          jdkVersionOption: '1.11'
+          jdkArchitectureOption: 'x64'
+          publishJUnitResults: false
+          goals: 'install'
+
       - task: Maven@3
         displayName: 'Install Data Packages'
         inputs:

.github/CODEOWNERS

@@ -1,5 +1,5 @@
 # Instructions for CODEOWNERS file format and automatic build failure notifications:
-# https://github.com/Azure/azure-sdk/blob/master/docs/engineering-system/codeowners.md
+# https://github.com/Azure/azure-sdk/blob/master/docs/policies/opensource.md#codeowners
 
 ###########
 # SDK
@@ -9,24 +9,29 @@
 /sdk/ @joshfree @jonathangiles
 
 # Service teams
-/sdk/appconfiguration/       @alzimmermsft @conniey @sima-zhu
-/sdk/core/                   @alzimmermsft @jianghaolu @srnagar @hemanttanwar
-/sdk/cosmos/                 @moderakh @christopheranderson @kushagraThapar
-/sdk/eventhubs/              @conniey @srnagar @mssfang
-/sdk/identity/               @jianghaolu @g2vinay @hemanttanwar
-/sdk/keyvault/               @g2vinay @samvaity
-/sdk/servicebus/             @yvgopal @nemakam
-/sdk/tracing/                @samvaity @alzimmermsft
+/sdk/appconfiguration/                            	@mssfang @alzimmermsft @conniey @sima-zhu
+/sdk/batch/                                      	@xingwu1 @bgklein @matthchr
+/sdk/cognitiveservices/ms-azure-cs-inkrecognizer	@minaltolpadi @olduroja @MAtifSaeed
+/sdk/core/                                        	@alzimmermsft @jianghaolu @srnagar @hemanttanwar
+/sdk/cosmos/                                      	@moderakh @christopheranderson @kushagraThapar
+/sdk/eventhubs/                                   	@conniey @srnagar @mssfang
+/sdk/identity/                                    	@jianghaolu @g2vinay @hemanttanwar
+/sdk/keyvault/                                    	@g2vinay @samvaity
+/sdk/servicebus/                                  	@yvgopal @nemakam
+/sdk/tracing/                                    	@samvaity @alzimmermsft
 
-/sdk/storage/                @rickle-msft @jaschrep-msft @alzimmermsft @sima-zhu
+/sdk/storage/                				@rickle-msft @jaschrep-msft @gapra-msft @alzimmermsft @sima-zhu
 
 # Management Plane
-/**/resource-manager/        @yaohaizh
+/**/resource-manager/        				@yaohaizh
 
 ###########
 # Eng Sys
 ###########
-/eng/   @weshaggard @mitchdenny @danieljurek
-/eng/code-quality-reports/ @mssfang @JonathanGiles
+/eng/                               @JimSuplizio @mitchdenny @weshaggard @danieljurek
+/eng/code-quality-reports/          @mssfang @JonathanGiles
+/eng/jacoco-test-coverage/          @srnagar @JonathanGiles
+/eng/spotbugs-aggregate-report/     @srnagar @JonathanGiles
+
 /**/tests.yml   @danieljurek
 /**/ci.yml      @mitchdenny

.gitignore

@@ -4,6 +4,9 @@
 dist/
 .publish/
 
+#javadoc overview files generated from README.md
+readme_overview.html
+
 #External libs
 extlib/
 

README.md

@@ -14,27 +14,33 @@ To get started with a specific library, see the **README.md** file located in th
 For tutorials, samples, quick starts and other documentation, visit [Azure for Java Developers](https://docs.microsoft.com/java/azure/).
 
 ### Prerequisites
-Java 8 or later is required to use the July 2019 client preview libraries, otherwise Java 7 or later is required.
+Java 8 or later is required to use the October 2019 client preview libraries, otherwise Java 7 or later is required.
 
 ## Packages available
 Each service might have a number of libraries available from each of the following categories:
 
-* [Client - July 2019 Preview](#Client-July-2019-Preview)
+* [Client - October 2019 Preview](#Client-October-2019-Preview)
 * [Client - Stable](#Client-Stable)
 * [Management](#Management)
 
-### Client: July 2019 Preview
-New wave of packages that we are currently releasing in **preview**. These libraries follow the [Azure SDK Design Guidelines for Java](https://azuresdkspecs.z5.web.core.windows.net/JavaSpec.html) and share a number of core features such as HTTP retries, logging, transport protocols, authentication protocols, etc., so that once you learn how to use these features in one client library, you will know how to use them in other client libraries. You can learn about these shared features [here](core).
+### Client: October 2019 Preview
+New wave of packages that we are currently releasing in **preview**. These libraries follow the [Azure SDK Design Guidelines for Java](https://azure.github.io/azure-sdk/java/guidelines/) and share a number of core features such as HTTP retries, logging, transport protocols, authentication protocols, etc., so that once you learn how to use these features in one client library, you will know how to use them in other client libraries. You can learn about these shared features [here](core). 
 
 These preview libraries can be easily identified by their folder, package, and namespaces names starting with `azure-`, e.g. `azure-keyvault`.
 
-The libraries released in the July 2019 preview:
+The libraries released in the October 2019 preview:
 - [App Configuration](sdk/appconfiguration/azure-data-appconfiguration/README.md)
 - [Event Hubs](sdk/eventhubs/azure-messaging-eventhubs/README.md)
+- [Event Hubs Checkpoint Store](sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/README.md)
 - [Identity](sdk/identity/azure-identity/README.md)
-- [Key Vault Keys](sdk/keyvault/azure-keyvault-keys/README.md)
-- [Key Vault Secrets](sdk/keyvault/client/azure-keyvault-secrets/README.md)
+- [Key Vault Certificates](sdk/keyvault/azure-security-keyvault-certificates/README.md)
+- [Key Vault Keys](sdk/keyvault/azure-security-keyvault-keys/README.md)
+- [Key Vault Secrets](sdk/keyvault/azure-security-keyvault-secrets/README.md)
 - [Storage Blobs](sdk/storage/azure-storage-blob/README.md)
+- [Storage Blobs Batch](sdk/storage/azure-storage-blob-batch/README.md)
+- [Storage Blobs Cryptography](sdk/storage/azure-storage-blob-cryptography/README.md)
+- [Storage Files](sdk/storage/azure-storage-file/README.md)
+- [Storage Queues](sdk/storage/azure-storage-queue/README.md)
 
 >NOTE: If you need to ensure your code is ready for production, use one of the stable libraries.
 

advisor/resource-manager/v2017_04_19/pom.xml

@@ -15,7 +15,7 @@
         <relativePath>../../../pom.management.xml</relativePath>
     </parent>
     <artifactId>azure-mgmt-advisor</artifactId>
-    <version>1.0.0-beta-1</version>
+    <version>1.0.0-beta-2</version>
     <packaging>jar</packaging>
     <name>Microsoft Azure SDK for Advisor Management</name>
     <description>This package contains Microsoft Advisor Management SDK.</description>
@@ -71,6 +71,8 @@
             <artifactId>azure-arm-client-runtime</artifactId>
             <type>test-jar</type>
             <scope>test</scope>
+            <!--Below version for test jar needs to be removed, this will be done as part of v1-runtime 1.6.7-->
+            <version>1.6.5</version>
         </dependency>
     </dependencies>
     <build>

advisor/resource-manager/v2017_04_19/src/main/java/com/microsoft/azure/management/advisor/v2017_04_19/Category.java

@@ -28,6 +28,9 @@ public final class Category extends ExpandableStringEnum<Category> {
     /** Static value Cost for Category. */
     public static final Category COST = fromString("Cost");
 
+    /** Static value OperationalExcellence for Category. */
+    public static final Category OPERATIONAL_EXCELLENCE = fromString("OperationalExcellence");
+
     /**
      * Creates or finds a Category from its string representation.
      * @param name a name to look for

advisor/resource-manager/v2017_04_19/src/main/java/com/microsoft/azure/management/advisor/v2017_04_19/implementation/ResourceRecommendationBaseInner.java

@@ -27,7 +27,8 @@
 public class ResourceRecommendationBaseInner extends ProxyResource {
     /**
      * The category of the recommendation. Possible values include:
-     * 'HighAvailability', 'Security', 'Performance', 'Cost'.
+     * 'HighAvailability', 'Security', 'Performance', 'Cost',
+     * 'OperationalExcellence'.
      */
     @JsonProperty(value = "properties.category")
     private Category category;
@@ -96,7 +97,7 @@ public class ResourceRecommendationBaseInner extends ProxyResource {
     private Map<String, String> extendedProperties;
 
     /**
-     * Get the category of the recommendation. Possible values include: 'HighAvailability', 'Security', 'Performance', 'Cost'.
+     * Get the category of the recommendation. Possible values include: 'HighAvailability', 'Security', 'Performance', 'Cost', 'OperationalExcellence'.
      *
      * @return the category value
      */
@@ -105,7 +106,7 @@ public Category category() {
     }
 
     /**
-     * Set the category of the recommendation. Possible values include: 'HighAvailability', 'Security', 'Performance', 'Cost'.
+     * Set the category of the recommendation. Possible values include: 'HighAvailability', 'Security', 'Performance', 'Cost', 'OperationalExcellence'.
      *
      * @param category the category value to set
      * @return the ResourceRecommendationBaseInner object itself.

advisor/resource-manager/v2017_04_19/src/main/java/com/microsoft/azure/management/advisor/v2017_04_19/implementation/SuppressionsImpl.java

@@ -64,10 +64,14 @@ public SuppressionContract call(SuppressionContractInner inner) {
     public Observable<SuppressionContract> getAsync(String resourceUri, String recommendationId, String name) {
         SuppressionsInner client = this.inner();
         return client.getAsync(resourceUri, recommendationId, name)
-        .map(new Func1<SuppressionContractInner, SuppressionContract>() {
+        .flatMap(new Func1<SuppressionContractInner, Observable<SuppressionContract>>() {
             @Override
-            public SuppressionContract call(SuppressionContractInner inner) {
-                return wrapModel(inner);
+            public Observable<SuppressionContract> call(SuppressionContractInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((SuppressionContract)wrapModel(inner));
+                }
             }
        });
     }

api-specs.json

@@ -19,6 +19,10 @@
       "source": "specification/applicationinsights/data-plane/readme.md",
       "args": "--payload-flattening-threshold=1"
     },
+  "appplatform/resource-manager": {
+    "source": "specification/appplatform/resource-manager/readme.md",
+    "args": "--multiapi --fluent"
+  },
   "appservice/resource-manager": {
     "source": "specification/web/resource-manager/readme.md",
     "args": "--multiapi --fluent",
@@ -34,6 +38,10 @@
     "source": "specification/authorization/resource-manager/readme.md",
     "args": "--multiapi --fluent"
   },
+  "azure-kusto/resource-manager": {
+    "source": "specification/azure-kusto/resource-manager/readme.md",
+    "args": "--multiapi --fluent"
+  },
   "azurestack/resource-manager": {
     "source": "specification/azurestack/resource-manager/readme.md",
     "args": "--multiapi --fluent"
@@ -191,6 +199,10 @@
     "source": "specification/operationsmanagement/resource-manager/readme.md",
     "args": "--multiapi --fluent"
   },
+  "peering/resource-manager": {
+    "source": "specification/peering/resource-manager/readme.md",
+    "args": "--multiapi --fluent"
+  },
   "policyinsights/resource-manager": {
     "source": "specification/policyinsights/resource-manager/readme.md",
     "args": "--multiapi --fluent"
@@ -272,6 +284,10 @@
     "source": "specification/storage/resource-manager/readme.md",
     "args": "--multiapi --fluent"
   },
+  "storagecache/resource-manager": {
+    "source": "specification/storagecache/resource-manager/readme.md",
+    "args": "--multiapi --fluent"
+  },
   "storageimportexport/resource-manager": {
     "source": "specification/storageimportexport/resource-manager/readme.md",
     "args": "--multiapi --fluent"
@@ -282,5 +298,12 @@
     "fconfig": {
       "\"moduleName\"": "\"StreamAnalytics\""
     }
+  },
+  "vmwarecloudsimple/resource-manager": {
+    "source": "specification/vmwarecloudsimple/resource-manager/readme.md",
+    "args": "--multiapi --fluent",
+    "fconfig": {
+      "\"moduleName\"": "\"VMwareCloudSimple\""
+    }
   }
 }