Dataplane policy states and events API swagger #8562

NarineM · 2020-02-28T20:30:31Z

Latest improvements:

Added data plane events and states API under version 2019-10-01. Added samples.

@pilor

Data plane sample fixes and resolving autorest tool compile errors

Added more examples for dp and minor fixes

Update api version in exisiting events API examples to be 2019-10-01

azure-pipelines · 2020-02-28T20:30:49Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-28T20:32:20Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4996fbd with merge commit 55b21727f58d451f2d033ad23448d7838cef50c7. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.PolicyInsights [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.PolicyInsights.3.1.0.nupkg
- Microsoft.Azure.Management.PolicyInsights.3.1.0.snupkg

openapi-sdkautomation · 2020-02-28T20:32:21Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4996fbd with merge commit 55b21727f58d451f2d033ad23448d7838cef50c7. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-policyinsights [Logs] [Preview SDK Changes]

azure-arm-policyinsights-3.2.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-policyinsights@3.2.0~prepack: cannot run in wd @azure/arm-policyinsights@3.2.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/policyinsights/arm-policyinsights)

openapi-sdkautomation · 2020-02-28T20:32:25Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4996fbd with merge commit 55b21727f58d451f2d033ad23448d7838cef50c7. SDK Automation 13.0.17.20200326.3

️✔️azure-mgmt-policyinsights [Logs] [Preview SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 4.557% size of original (original: 45890 chars, delta: 2091 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model PolicyEvent has a new parameter compliance_state
[ChangeLog]   - Model PolicyEvent has a new parameter components
[ChangeLog]   - Model PolicyState has a new parameter components

openapi-sdkautomation · 2020-02-28T20:32:26Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 4996fbd with merge commit 55b21727f58d451f2d033ad23448d7838cef50c7. SDK Automation 13.0.17.20200326.3
️✔️sdk/policyinsights/mgmt-v2018_04_04 [Logs] [Preview SDK Changes]

⚠️sdk/policyinsights/mgmt-v2018_07_01_preview [Logs] [Preview SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:94: error: '{' expected
[mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
[mvn] [ERROR]                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error: = expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                             ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error:  expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                                           ^
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

⚠️sdk/policyinsights/mgmt-v2019_10_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:99: error: '{' expected
[mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
[mvn] [ERROR]                                ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error: = expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                             ^
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error:  expected
[mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
[mvn] [ERROR]                                                           ^
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

openapi-sdkautomation · 2020-02-28T20:32:29Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 4996fbd with merge commit 55b21727f58d451f2d033ad23448d7838cef50c7. SDK Automation 13.0.17.20200326.3
⚠️policyinsights/mgmt/2018-04-04 [Logs]
```
No file is changed.
```
️✔️policyinsights/mgmt/2019-10-01 [Logs] [Preview SDK Changes]
- policyinsights.mgmt.2019-10-01.zip
⚠️preview/policyinsights/mgmt/2018-07-01-preview [Logs]
```
No file is changed.
```

azuresdkci · 2020-02-28T20:35:49Z

Can one of the admins verify this patch?

Fix model validator errors

azure-pipelines · 2020-02-28T20:47:31Z

Azure Pipelines successfully started running 1 pipeline(s).

Remove aggrigate data plane events and states examples from swagger

azure-pipelines · 2020-02-28T22:17:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-29T00:24:26Z

Azure Pipelines successfully started running 1 pipeline(s).

ravbhatnagar · 2020-03-03T22:24:07Z

@NarineM - can you please set something up with armapireview to go over this? It will be much quicker in person since this is a new type.

NarineM · 2020-03-18T18:59:46Z

@pilor Just pushed a new iteration that addresses your comments. I can see this warning from cli-extension, do you know what it complains about?:
"azure-cli-extensions
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured "

pilor · 2020-03-18T20:23:09Z

@pilor Just pushed a new iteration that addresses your comments. I can see this warning from cli-extension, do you know what it complains about?:
"azure-cli-extensions
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured "

No, I don't know the specifics on that but I have seen it on my own PRs which went through just fine. The SDK reviewer is a better contact.

SDK automation is throwing an error if the parameter descriptions for $expand do not match across PolicyStates and PolicyEvents API.

azure-pipelines · 2020-03-18T21:21:31Z

Azure Pipelines successfully started running 1 pipeline(s).

NarineM · 2020-03-19T19:51:18Z

@raych1 Can you help with this new error from SDK automation log?, it says branch changes need to be squished. Looks like something with the tool. Now this issue impacts all language SDK.

raych1 · 2020-03-20T02:52:39Z

@NullMDR , can you help with the SDK automation failures?

PhoenixHe-NV · 2020-03-21T00:11:34Z

/azp run

azure-pipelines · 2020-03-21T00:11:54Z

Azure Pipelines successfully started running 3 pipeline(s).

NarineM · 2020-03-25T01:37:19Z

@raych1 thanks. So far all PR merge validation issues have been resolved except prettier check. This PR can be merged unless you tell me the prettier check issue is blocking. As of now I can not figure out why the tool is not running or what it complains about. The log says something with formatting, but can not figure out. can you run prettier on your local box for any of the files it complains about and let me know what is the issue? Here is the log that has file names that failed in prettier checks: https://dev.azure.com/azure-sdk/public/_build/results?buildId=326037&view=logs&j=b56e9678-4dad-5642-289c-5530cc4dad11&t=9e18c5d1-dc43-58a1-0344-6ef37d05bd7f&l=65

NarineM · 2020-03-25T01:37:49Z

Please go ahead with merging this PR when you get a chance if you do not find anything with prettier check.

raych1 · 2020-03-25T02:26:18Z

@NarineM, prettierCheck is required to pass. @NullMDR , can you help Narine, he failed to run prettier?

azure-pipelines · 2020-03-25T04:57:23Z

Pull request contains merge conflicts.

PhoenixHe-NV · 2020-03-25T05:01:04Z

@NarineM I've fixed your prettier failure by running
npm run prettier -- --write "specification/policyinsights/**/*.json"
But please fix the merge conflict.

azure-pipelines · 2020-03-26T21:27:02Z

Pull request contains merge conflicts.

azure-pipelines · 2020-03-26T21:50:20Z

Pull request contains merge conflicts.

azure-pipelines · 2020-03-26T22:00:44Z

No commit pushedDate could be found for PR 8562 in repo Azure/azure-rest-api-specs

azure-pipelines · 2020-03-26T22:13:38Z

Pull request contains merge conflicts.

azure-pipelines · 2020-03-26T22:23:38Z

Azure Pipelines successfully started running 1 pipeline(s).

NarineM · 2020-03-26T22:45:53Z

@NullMDR, thank you. I have resolved merge conflicts. The only failure now remaining is related to api version (under breaking change category). As we discussed earlier this change needs to be published for the same api version 2019-10-01. Please go ahead with merging this PR.

PhoenixHe-NV · 2020-03-27T04:49:51Z

@jianyexi Why adding property in response will be considered as breaking change?

NarineM · 2020-03-27T17:29:08Z

@NullMDR It is not breaking change because this property is only appended when the client specifies it in request URL with $expand clause. This functionality is available in the current version of API on the RP side, so it should be published under the same API version 2019-10-01 and not a new version.

NarineM · 2020-04-01T21:38:45Z

@NullMDR , can you go ahead with merging this PR? Let me know what is blocking if anything. thanks.

ArcturusZhang · 2020-04-02T02:48:24Z

@NullMDR It is not breaking change because this property is only appended when the client specifies it in request URL with $expand clause. This functionality is available in the current version of API on the RP side, so it should be published under the same API version 2019-10-01 and not a new version.

I think this is reasonable.

Hi @akning-ms would you please have us merge this PR? This breaking change should be acceptable based on the author's comments

* swagger documentation for data plane PolicyStates API * enable events api in 2019-10-01 api version * data plane events API and data plane states API fixes * Data plane sample fixes and resolving autorest tool compile errors Data plane sample fixes and resolving autorest tool compile errors * Added more examples for dp and minor fixes Added more examples for dp and minor fixes * Update api version in exisiting events API examples Update api version in exisiting events API examples to be 2019-10-01 * Fix model validator errors Fix model validator errors * Remove aggrigate data plane events and states examples from swagger Remove aggrigate data plane events and states examples from swagger * Revert - Add back references to aggrigated component counts Revert - Add back references to aggrigated component counts * Added additional properties bag to data plane json object Added additional properties bag to data plane json object * Added policyEvents for 2019-10-01 in readme * fixed sample ref file path * Addressed PR review feedback Addressed PR review feedback * Fix SDK automation error SDK automation is throwing an error if the parameter descriptions for $expand do not match across PolicyStates and PolicyEvents API. * Fix prettier Co-authored-by: Phoenix He <tih@microsoft.com>

NarineM added 6 commits February 21, 2020 12:48

swagger documentation for data plane PolicyStates API

613f449

enable events api in 2019-10-01 api version

1fe57ca

data plane events API and data plane states API fixes

c0b7604

Data plane sample fixes and resolving autorest tool compile errors

ed299aa

Data plane sample fixes and resolving autorest tool compile errors

Added more examples for dp and minor fixes

ca1f722

Added more examples for dp and minor fixes

Update api version in exisiting events API examples

1c9a8c5

Update api version in exisiting events API examples to be 2019-10-01

openapi-assignment-bot bot assigned ArcturusZhang Feb 28, 2020

This was referenced Feb 28, 2020

[AutoPR @azure/arm-policyinsights] Dataplane policy states and events API swagger AzureSDKAutomation/azure-sdk-for-js#698

Open

[AutoPR azure-mgmt-policyinsights] Dataplane policy states and events API swagger AzureSDKAutomation/azure-sdk-for-python#513

Open

Fix model validator errors

df6f8ea

Fix model validator errors

Remove aggrigate data plane events and states examples from swagger

eed41ae

Remove aggrigate data plane events and states examples from swagger

ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 2, 2020

ravbhatnagar added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReviewMeetingRequired and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Mar 3, 2020

pilor approved these changes Mar 18, 2020

View reviewed changes

Fix SDK automation error

d9845a3

SDK automation is throwing an error if the parameter descriptions for $expand do not match across PolicyStates and PolicyEvents API.

Fix prettier

340ecb0

PhoenixHe-NV self-requested a review March 25, 2020 04:52

Merge branch 'master_upstream' into narinem-dataplane-swagger

4996fbd

akning-ms merged commit 41c4f56 into Azure:master Apr 7, 2020

NarineM mentioned this pull request Oct 23, 2020

Add pagination and data plane support to PolicyInsights states and events APIs Azure/azure-sdk-for-net#15976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dataplane policy states and events API swagger #8562

Dataplane policy states and events API swagger #8562

NarineM commented Feb 28, 2020 •

edited

Loading

azure-pipelines bot commented Feb 28, 2020

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

azuresdkci commented Feb 28, 2020

azure-pipelines bot commented Feb 28, 2020

azure-pipelines bot commented Feb 28, 2020

azure-pipelines bot commented Feb 29, 2020

ravbhatnagar commented Mar 3, 2020

NarineM commented Mar 18, 2020

pilor commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

NarineM commented Mar 19, 2020 •

edited

Loading

raych1 commented Mar 20, 2020

PhoenixHe-NV commented Mar 21, 2020

azure-pipelines bot commented Mar 21, 2020

NarineM commented Mar 25, 2020 •

edited

Loading

NarineM commented Mar 25, 2020

raych1 commented Mar 25, 2020

azure-pipelines bot commented Mar 25, 2020

PhoenixHe-NV commented Mar 25, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

NarineM commented Mar 26, 2020 •

edited

Loading

PhoenixHe-NV commented Mar 27, 2020 •

edited

Loading

NarineM commented Mar 27, 2020 •

edited

Loading

NarineM commented Apr 1, 2020 •

edited

Loading

ArcturusZhang commented Apr 2, 2020

Dataplane policy states and events API swagger #8562

Dataplane policy states and events API swagger #8562

Conversation

NarineM commented Feb 28, 2020 • edited Loading

Latest improvements:

azure-pipelines bot commented Feb 28, 2020

openapi-sdkautomation bot commented Feb 28, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Feb 28, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Feb 28, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Feb 28, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Feb 28, 2020 • edited Loading

azure-sdk-for-go

azuresdkci commented Feb 28, 2020

azure-pipelines bot commented Feb 28, 2020

azure-pipelines bot commented Feb 28, 2020

azure-pipelines bot commented Feb 29, 2020

ravbhatnagar commented Mar 3, 2020

NarineM commented Mar 18, 2020

pilor commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

NarineM commented Mar 19, 2020 • edited Loading

raych1 commented Mar 20, 2020

PhoenixHe-NV commented Mar 21, 2020

azure-pipelines bot commented Mar 21, 2020

NarineM commented Mar 25, 2020 • edited Loading

NarineM commented Mar 25, 2020

raych1 commented Mar 25, 2020

azure-pipelines bot commented Mar 25, 2020

PhoenixHe-NV commented Mar 25, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

NarineM commented Mar 26, 2020 • edited Loading

PhoenixHe-NV commented Mar 27, 2020 • edited Loading

NarineM commented Mar 27, 2020 • edited Loading

NarineM commented Apr 1, 2020 • edited Loading

ArcturusZhang commented Apr 2, 2020

NarineM commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 28, 2020 •

edited

Loading

NarineM commented Mar 19, 2020 •

edited

Loading

NarineM commented Mar 25, 2020 •

edited

Loading

NarineM commented Mar 26, 2020 •

edited

Loading

PhoenixHe-NV commented Mar 27, 2020 •

edited

Loading

NarineM commented Mar 27, 2020 •

edited

Loading

NarineM commented Apr 1, 2020 •

edited

Loading