HybridDataManager - adding API version 2019-06-01 and examples #8676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added updated swagger file for Microsoft.HybridData
Added swagger and examples for API version 2019-06-01 Adding PartiallySucceeded job status
prtank
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can one of the admins verify this patch? |
Ran npm install; npm run prettier -- --write "specification/hybriddatamanager/**/*.json"
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
markcowl
added
the
WaitForARMFeedback
|
@prtank per the checklist above, this PR needs arm feedback. Adding appropriate label |
majastrz
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Diffing with 2016-06-01 shows only a small change. When adding a new API, please make the first commit an unmodified copy of the previous API version at the folder of the new API version. This makes reviews very easy because then we simply diff first commit with last and get the actual delta.
Otherwise, changes look good from ARM side. Signing off...
majastrz
added
ARMSignedOff
markcowl
requested changes
Apr 3, 2020
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "This method gets all the operations.", |
There was a problem hiding this comment.
To be parallel with the other operation results, this description should be 'The list of operations for this provider'
| "tags": [ | ||
| "DataServices" | ||
| ], | ||
| "description": "Gets the data service that match the data service name given.", |
There was a problem hiding this comment.
Suggested change
| "description": "Gets the data service that match the data service name given.", | |
| "description": "Gets the data service that matches the data service name given.", |
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "The data store/repository object.", |
There was a problem hiding this comment.
Completed request for Create/Update.
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "The list of job definitions in that resource.OK", |
There was a problem hiding this comment.
Suggested change
| "description": "The list of job definitions in that resource.OK", | |
| "description": "The list of job definitions in the resource.", |
markcowl
added
the
Reviewed-ChangesRequested
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
markcowl
approved these changes
Apr 3, 2020
markcowl
added
Approved-OkToMerge
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…#8676) * Create hybriddata.json Added updated swagger file for Microsoft.HybridData * Create readme.md * Updated readme files * Update readme.md * Removed unused API endpoints * Updated example files and swagger * Fixed error in path to example files * Fixed Go and Ruby Readme Files * Added suppression for OperationIdNounVerb * Added DataManagers_Update and examples * Added suppression for ARM Violation and updated swagger and example files * Updated swagger to sdk script for ruby * Added Python swagger to sdk * Added PartiallySucceeded status * Added swagger and examples for API Version 2019-06-01 Added swagger and examples for API version 2019-06-01 Adding PartiallySucceeded job status * Removed partially succeeded status from 2016-06-01 swagger * Updating body of 202 response * After running prettier Ran npm install; npm run prettier -- --write "specification/hybriddatamanager/**/*.json" * Updated readme files to include 2019-06 api version * Updated descriptions as per PR comments * Committing Prettier check change Co-authored-by: t-prta <46665688+prerna-tank-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.