-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HybridDataManager - Adding SDK version 1.0.1 to correspond to API version 2019-06-01 #10531
Conversation
PR for spec merge of API version 2019-06-01 is Azure/azure-rest-api-specs#8676 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prtank generally the API spec needs to be merged into master BEFORE you generate SDK and submit this PR.
I noticed that the PR is missing a change to /eng/mgmt/mgmtmetadata/hybriddatamanager_resource-manager.txt
, also the license headers are difference. I suspect it's caused by running autorest
directly, rather that our recommended way: running src/generate.ps1
in your module.
So, please do the following things after the swagger review PR is merged:
- Edit
src/generate.ps1
, change -AutoRestVersion "latest" to "2.0.4413" - Run it to generate SDK
- In case you encounter any error, please refer to our document: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#generating-net-sdk
- Make sure you check in the txt file mentioned above
Thank you
...icrosoft.Azure.Management.HybridDataManager/src/Microsoft.Azure.Management.HybridData.csproj
Outdated
Show resolved
Hide resolved
...ger/Microsoft.Azure.Management.HybridDataManager/src/Generated/HybridDataManagementClient.cs
Show resolved
Hide resolved
kindly ping @prtank |
Hi, I have been waiting for the swagger spec PR to be merged before I take care of these changes. I am expecting that to go through today so I will take care of all these comments before Monday. Thanks for reviewing in advance :) |
I have pushed the changed for AutoRest version 2.0.4413, but am curious as to why we are using that specific version instead of the latest - 3.0.6187 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.