-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM. #1199
Conversation
FYI, @vhvb1989 |
Blocked on Azure/azure-sdk-tools#946 and #1198 |
6 are being fixed by #1198 (although there are a couple of duplicates) |
This latest version of the tool has the BOM fix. |
For src files I understand we would get compilation warnings, |
Consistency (especially around the BOM) and I don't currently see a harm or reason to exclude them. If we find one in the future, we can skip those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a way to simplify scrip by just using recursive grep instead of a loop
Part of #1201
As a follow up to #1198 which fixes any non-ASCII related issues we have, I wanted to enable a CI-validating leg for this so that we stay green.