Update all calls to XDocument.Save to use an XmlTextWriter without a UTF-8 BOM encoding. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UTF-8 BOM encoding.
ahsonkhan
commented
Sep 3, 2020
| @@ -386,7 +388,10 @@ public void CreateSummaryReport(SummaryResult summaryResult) | |||
|
|
|||
| Logger.InfoFormat(Resources.WritingReportFile, targetPath); | |||
|
|
|||
| result.Save(targetPath); | |||
| using (var writer = new XmlTextWriter(targetPath, new UTF8Encoding(encoderShouldEmitUTF8Identifier: false))) | |||
There was a problem hiding this comment.
I am not super familiar with the project layout. Is there a good place to cache this UTF8Encoding so that I can use it everywhere without having to create it repeatedly each time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #380, if the issue is valid for the project :)
cc @danielpalme