Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azcore/policy : Missing default referenced in doc comments: StatusCodesForRetry #18637

Closed
serbrech opened this issue Jul 20, 2022 · 1 comment
Closed

azcore/policy : Missing default referenced in doc comments: StatusCodesForRetry #18637

serbrech opened this issue Jul 20, 2022 · 1 comment
Assignees
@jhendrixMSFT
Labels
Azure.Core Docs
Milestone
2022-08

Comments

@serbrech
Copy link
Member

StatusCodesForRetry seems to be in autorest? I suppose this is a mistake?

azure-sdk-for-go/sdk/azcore/policy/policy.go

Lines 93 to 98 in b386adc

// StatusCodes specifies the HTTP status codes that indicate the operation should be retried.
// The default value is the status codes in StatusCodesForRetry.
// Specifying an empty slice will cause retries to happen only for transport errors.
StatusCodes []int
}

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 20, 2022
@jhendrixMSFT jhendrixMSFT added Docs Azure.Core and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jul 20, 2022
@jhendrixMSFT jhendrixMSFT self-assigned this Jul 20, 2022
@jhendrixMSFT jhendrixMSFT mentioned this issue Jul 20, 2022
Merged
ghost pushed a commit that referenced this issue Jul 20, 2022
@jhendrixMSFT
Doc fixes for policy.RetryOptions (#18651)
8f7fbad 
Fixes:
#18636
#18637
#18638
@jhendrixMSFT
Copy link
Member

Fixes will ship in the August release.

@RickWinter RickWinter added this to the 2022-08 milestone Jul 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Azure.Core Docs
Projects
None yet
Milestone
2022-08
Development

No branches or pull requests
3 participants
@serbrech @RickWinter @jhendrixMSFT